2006-12-15 01:38:52

by Chris Wright

[permalink] [raw]
Subject: [patch 13/24] IPSEC: Fix inetpeer leak in ipv4 xfrm dst entries.

2.6.18-stable review patch. If anyone has any objections, please let us know.
------------------

From: David Miller <[email protected]>

We grab a reference to the route's inetpeer entry but
forget to release it in xfrm4_dst_destroy().

Bug discovered by Kazunori MIYAZAWA <[email protected]>

Signed-off-by: David S. Miller <[email protected]>
Signed-off-by: Chris Wright <[email protected]>
---
commit 26db167702756d0022f8ea5f1f30cad3018cfe31
Author: David S. Miller <[email protected]>
Date: Wed Dec 6 23:45:15 2006 -0800

net/ipv4/xfrm4_policy.c | 2 ++
1 file changed, 2 insertions(+)

--- linux-2.6.18.5.orig/net/ipv4/xfrm4_policy.c
+++ linux-2.6.18.5/net/ipv4/xfrm4_policy.c
@@ -252,6 +252,8 @@ static void xfrm4_dst_destroy(struct dst

if (likely(xdst->u.rt.idev))
in_dev_put(xdst->u.rt.idev);
+ if (likely(xdst->u.rt.peer))
+ inet_putpeer(xdst->u.rt.peer);
xfrm_dst_destroy(xdst);
}


--