2006-12-19 08:46:19

by Akinobu Mita

[permalink] [raw]
Subject: [PATCH] pc110pad: return proper error

According to the comment, "if we find any PCI devices in the machine,
we don't have a PC110" in pc110pad.c, we should return -ENODEV
rather than -ENOENT in this case.

Cc: Dmitry Torokhov <[email protected]>
Cc: Vojtech Pavlik <[email protected]>
Signed-off-by: Akinobu Mita <[email protected]>

---
drivers/input/mouse/pc110pad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: 2.6-mm/drivers/input/mouse/pc110pad.c
===================================================================
--- 2.6-mm.orig/drivers/input/mouse/pc110pad.c
+++ 2.6-mm/drivers/input/mouse/pc110pad.c
@@ -113,7 +113,7 @@ static int __init pc110pad_init(void)
dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, NULL);
if (dev) {
pci_dev_put(dev);
- return -ENOENT;
+ return -ENODEV;
}

if (!request_region(pc110pad_io, 4, "pc110pad")) {


2006-12-21 05:44:15

by Dmitry Torokhov

[permalink] [raw]
Subject: Re: [PATCH] pc110pad: return proper error

On Tuesday 19 December 2006 03:44, Akinobu Mita wrote:
> According to the comment, "if we find any PCI devices in the machine,
> we don't have a PC110" in pc110pad.c, we should return -ENODEV
> rather than -ENOENT in this case.
>

Applied, thank you.

--
Dmitry