2006-12-29 04:13:58

by Balbir Singh

Subject: [PATCH 2.6.20-rc2] Fix set_pte_at arguments in page_mkclean_one

page_mkclean_one() passes vma instead of the expected mm as argument1 to
set_pte_at. Below is a simple fix (tested by compiling the kernel on
powerpc). Please ignore the patch, if a fix has already been applied.

Signed-off-by: Balbir Singh <[email protected]>
---

mm/rmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN mm/rmap.c~fix-set-pte-in-page_mkclean_one mm/rmap.c
--- linux-2.6.20-rc2/mm/rmap.c~fix-set-pte-in-page_mkclean_one 2006-12-29 09:18:26.000000000 +0530
+++ linux-2.6.20-rc2-balbir/mm/rmap.c 2006-12-29 09:25:28.000000000 +0530
@@ -461,7 +461,7 @@ static int page_mkclean_one(struct page
entry = ptep_clear_flush(vma, address, pte);
entry = pte_wrprotect(entry);
entry = pte_mkclean(entry);
- set_pte_at(vma, address, pte, entry);
+ set_pte_at(mm, address, pte, entry);
lazy_mmu_prot_update(entry);
ret = 1;
}
_

--

Balbir Singh,
Linux Technology Center,
IBM Software Labs

2006-12-29 04:57:07

by David Miller

Subject: Re: [PATCH 2.6.20-rc2] Fix set_pte_at arguments in page_mkclean_one

From: Balbir Singh <[email protected]>
Date: Fri, 29 Dec 2006 09:43:10 +0530

> page_mkclean_one() passes vma instead of the expected mm as argument1 to
> set_pte_at. Below is a simple fix (tested by compiling the kernel on
> powerpc). Please ignore the patch, if a fix has already been applied.
>
> Signed-off-by: Balbir Singh <[email protected]>

Good catch.

Signed-off-by: David S. Miller <[email protected]>