2006-12-30 00:05:10

by Adam Megacz

[permalink] [raw]
Subject: OpenAFS gatekeepers request addition of AFS_SUPER_MAGIC to magic.h


Hello,

Jeffrey Altman, one of the gatekeepers of OpenAFS (the open source
project which inherited the Transarc/IBM AFS codebase) has requested
that the magic number 0x5346414F (little endian 'OAFS') be allocated
for the f_type field of the fsinfo structure on Linux:

https://lists.openafs.org/pipermail/openafs-info/2006-December/024829.html

I would like to offer the patch below for inclusion in the source
tree, if possible. The patch adds it to include/linux/magic.h, mostly
as a way of publishing this number and ensuring that no other
filesystem accidentally uses it.

- a


--- include/linux/magic.h 2006-12-29 15:48:50.000000000 -0800
+++ include/linux/magic.h 2006-11-29 13:57:37.000000000 -0800
@@ -3,7 +3,6 @@

#define ADFS_SUPER_MAGIC 0xadf5
#define AFFS_SUPER_MAGIC 0xadff
-#define AFS_SUPER_MAGIC 0x5346414F
#define AUTOFS_SUPER_MAGIC 0x0187
#define CODA_SUPER_MAGIC 0x73757245
#define EFS_SUPER_MAGIC 0x414A53


2006-12-30 00:45:43

by Stephen Frost

[permalink] [raw]
Subject: Re: OpenAFS gatekeepers request addition of AFS_SUPER_MAGIC to magic.h

* Adam Megacz ([email protected]) wrote:
> --- include/linux/magic.h 2006-12-29 15:48:50.000000000 -0800
> +++ include/linux/magic.h 2006-11-29 13:57:37.000000000 -0800
> @@ -3,7 +3,6 @@
>
> #define ADFS_SUPER_MAGIC 0xadf5
> #define AFFS_SUPER_MAGIC 0xadff
> -#define AFS_SUPER_MAGIC 0x5346414F
> #define AUTOFS_SUPER_MAGIC 0x0187
> #define CODA_SUPER_MAGIC 0x73757245
> #define EFS_SUPER_MAGIC 0x414A53

Wouldn't you want a patch which *adds* it, rather than one which
*removes* it...?

Thanks,

Stephen

Attachments:
(No filename) (584.00 B)
 signature.asc (189.00 B)
Digital signature Download all attachments

2006-12-30 02:10:09

by Adam Megacz

[permalink] [raw]
Subject: Re: OpenAFS gatekeepers request addition of AFS_SUPER_MAGIC to magic.h


Drat. Diffed in the wrong direction. Yes, you're right.

- a

Stephen Frost <[email protected]> writes:
> * Adam Megacz ([email protected]) wrote:
>> --- include/linux/magic.h 2006-12-29 15:48:50.000000000 -0800
>> +++ include/linux/magic.h 2006-11-29 13:57:37.000000000 -0800
>> @@ -3,7 +3,6 @@
>>
>> #define ADFS_SUPER_MAGIC 0xadf5
>> #define AFFS_SUPER_MAGIC 0xadff
>> -#define AFS_SUPER_MAGIC 0x5346414F
>> #define AUTOFS_SUPER_MAGIC 0x0187
>> #define CODA_SUPER_MAGIC 0x73757245
>> #define EFS_SUPER_MAGIC 0x414A53
>
> Wouldn't you want a patch which *adds* it, rather than one which
> *removes* it...?
>
> Thanks,
>
> Stephen

--
PGP/GPG: 5C9F F366 C9CF 2145 E770 B1B8 EFB1 462D A146 C380

2006-12-30 09:18:04

by Christoph Hellwig

[permalink] [raw]
Subject: Re: OpenAFS gatekeepers request addition of AFS_SUPER_MAGIC to magic.h

On Fri, Dec 29, 2006 at 03:56:12PM -0800, Adam Megacz wrote:
>
> Hello,
>
> Jeffrey Altman, one of the gatekeepers of OpenAFS (the open source
> project which inherited the Transarc/IBM AFS codebase) has requested
> that the magic number 0x5346414F (little endian 'OAFS') be allocated
> for the f_type field of the fsinfo structure on Linux:
>
> https://lists.openafs.org/pipermail/openafs-info/2006-December/024829.html
>
> I would like to offer the patch below for inclusion in the source
> tree, if possible. The patch adds it to include/linux/magic.h, mostly
> as a way of publishing this number and ensuring that no other
> filesystem accidentally uses it.

We're not allocating these number for any other out of teee junk like vxfs
or gpfs either. So I'd say stay away.


p.s. and please stop that namedropping - beeing a 'gatekeeper' doesn't
make you any more important than just beeing yourself