2007-01-01 14:19:40

by Tilman Schmidt

[permalink] [raw]
Subject: Sparse 0.2 warnings from {asm,net}/checksum.h

With sparse 0.2, my previously sparse-clean driver generates the
following warnings:

include/asm/checksum.h:182:6: warning: symbol 'sum' shadows an earlier one
include/asm/checksum.h:178:28: originally declared here
include/net/checksum.h:33:6: warning: symbol 'sum' shadows an earlier one
include/net/checksum.h:31:27: originally declared here

Architecture is i386. The lines referred to are in the functions
csum_and_copy_to_user() and csum_and_copy_from_user(), but I
don't see why sparse would emit such a warning for that code.

Any chance of getting rid of these?

Thanks
Tilman

--
Tilman Schmidt E-Mail: [email protected]
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Unge?ffnet mindestens haltbar bis: (siehe R?ckseite)


Attachments:
signature.asc (253.00 B)
OpenPGP digital signature

2007-01-01 19:10:19

by Dave Jones

[permalink] [raw]
Subject: Re: Sparse 0.2 warnings from {asm,net}/checksum.h

On Mon, Jan 01, 2007 at 03:23:45PM +0100, Tilman Schmidt wrote:
> With sparse 0.2, my previously sparse-clean driver generates the
> following warnings:
>
> include/asm/checksum.h:182:6: warning: symbol 'sum' shadows an earlier one
> include/asm/checksum.h:178:28: originally declared here
> include/net/checksum.h:33:6: warning: symbol 'sum' shadows an earlier one
> include/net/checksum.h:31:27: originally declared here
>
> Architecture is i386. The lines referred to are in the functions
> csum_and_copy_to_user() and csum_and_copy_from_user(), but I
> don't see why sparse would emit such a warning for that code.

It's complaining about the 'sum' declaration in __range_not_ok
used by access_ok(), which shadows the variable declared in
the prototype of the functions you mention.

Dave

--
http://www.codemonkey.org.uk