Hi all!
[ I'm not subscribed to this list so please CC me on your replies. ]
This is a new version of the patch that adds a search dialog to the
kernel's "make xconfig" configuration applet.
Changes in this release include:
1. Implemented regular expression querying. The GUI includes an option for a
keywords based query, which is not supported yet.
2. Fixed the fact that the top categories in the QListView do not have a
visible
[+] sign next to them to expand them. (Albeit they are expanded upon a double
click).
3. Now resizing the dialog to a larger default size.
To do is:
1. Make sure double clicking an end-item opens and highlights it in the main
application.
2. Eliminate the weird black-outlined rectangle that appears in the top-left
corner of the dialog.
--------
The patch was tested against kernel 2.6.20-rc3.
Enjoy!
Regards,
Shlomi Fish
---------------------------------------------------------------------
Shlomi Fish [email protected]
Homepage: http://www.shlomifish.org/
Chuck Norris wrote a complete Perl 6 implementation in a day but then
destroyed all evidence with his bare hands, so no one will know his secrets.
On Wed, 3 Jan 2007 19:54:36 +0200 Shlomi Fish wrote:
> Hi all!
>
> [ I'm not subscribed to this list so please CC me on your replies. ]
>
> This is a new version of the patch that adds a search dialog to the
> kernel's "make xconfig" configuration applet.
Would you just clarify one thing, please.
xconfig already has a search dialog. Does this one replace it
or fix it or what?
Thanks.
> Changes in this release include:
>
> 1. Implemented regular expression querying. The GUI includes an option for a
> keywords based query, which is not supported yet.
>
> 2. Fixed the fact that the top categories in the QListView do not have a
> visible
> [+] sign next to them to expand them. (Albeit they are expanded upon a double
> click).
>
> 3. Now resizing the dialog to a larger default size.
>
> To do is:
>
> 1. Make sure double clicking an end-item opens and highlights it in the main
> application.
>
> 2. Eliminate the weird black-outlined rectangle that appears in the top-left
> corner of the dialog.
>
> --------
>
> The patch was tested against kernel 2.6.20-rc3.
On Wednesday 03 January 2007 19:54, Randy Dunlap wrote:
> On Wed, 3 Jan 2007 19:54:36 +0200 Shlomi Fish wrote:
> > Hi all!
> >
> > [ I'm not subscribed to this list so please CC me on your replies. ]
> >
> > This is a new version of the patch that adds a search dialog to the
> > kernel's "make xconfig" configuration applet.
>
> Would you just clarify one thing, please.
> xconfig already has a search dialog. Does this one replace it
> or fix it or what?
Interesting. I didn't notice this search dialog before because its menu item
was placed in the "File" menu, which is the wrong place for a find command
(Which should be in an "Edit" or "Search" menu). I believe others have missed
it as well. Also, it is possible it wasn't available when I wrote the
preliminary version of the patch back in March.
Aside from that my search dialog has some advantages:
1. Full text search - if you search for "available" in File->Search you won't
find anything. Searching for it in Edit->Find will find many things. I think
File->Search only searches using the identifiers or at most also the title.
2. Regular expression search.
3. Displaying the results in a tree, with their context.
All that said, I don't mind merging my modifications into the existing code,
or replacing it entirely.
Regards,
Shlomi Fish
>
> Thanks.
>
> > Changes in this release include:
> >
> > 1. Implemented regular expression querying. The GUI includes an option
> > for a keywords based query, which is not supported yet.
> >
> > 2. Fixed the fact that the top categories in the QListView do not have a
> > visible
> > [+] sign next to them to expand them. (Albeit they are expanded upon a
> > double click).
> >
> > 3. Now resizing the dialog to a larger default size.
> >
> > To do is:
> >
> > 1. Make sure double clicking an end-item opens and highlights it in the
> > main application.
> >
> > 2. Eliminate the weird black-outlined rectangle that appears in the
> > top-left corner of the dialog.
> >
> > --------
> >
> > The patch was tested against kernel 2.6.20-rc3.
---------------------------------------------------------------------
Shlomi Fish [email protected]
Homepage: http://www.shlomifish.org/
Chuck Norris wrote a complete Perl 6 implementation in a day but then
destroyed all evidence with his bare hands, so no one will know his secrets.
On Wed, Jan 03, 2007 at 10:01:28PM +0200, Shlomi Fish wrote:
>
> Interesting. I didn't notice this search dialog before because its menu item
> was placed in the "File" menu, which is the wrong place for a find command
> (Which should be in an "Edit" or "Search" menu). I believe others have missed
> it as well. Also, it is possible it wasn't available when I wrote the
> preliminary version of the patch back in March.
>
> Aside from that my search dialog has some advantages:
>
> 1. Full text search - if you search for "available" in File->Search you won't
> find anything. Searching for it in Edit->Find will find many things. I think
> File->Search only searches using the identifiers or at most also the title.
>
> 2. Regular expression search.
>
> 3. Displaying the results in a tree, with their context.
>
> All that said, I don't mind merging my modifications into the existing code,
> or replacing it entirely.
Please merge the best of the existing and the new search dialog.
I would prefer it as separate smaller steps.
So one patch where you move the dialog and another where you improve
the search dialog.
Sam
On Wednesday 03 January 2007 23:05, Sam Ravnborg wrote:
> On Wed, Jan 03, 2007 at 10:01:28PM +0200, Shlomi Fish wrote:
> > Interesting. I didn't notice this search dialog before because its menu
> > item was placed in the "File" menu, which is the wrong place for a find
> > command (Which should be in an "Edit" or "Search" menu). I believe others
> > have missed it as well. Also, it is possible it wasn't available when I
> > wrote the preliminary version of the patch back in March.
> >
> > Aside from that my search dialog has some advantages:
> >
> > 1. Full text search - if you search for "available" in File->Search you
> > won't find anything. Searching for it in Edit->Find will find many
> > things. I think File->Search only searches using the identifiers or at
> > most also the title.
> >
> > 2. Regular expression search.
> >
> > 3. Displaying the results in a tree, with their context.
> >
> > All that said, I don't mind merging my modifications into the existing
> > code, or replacing it entirely.
>
> Please merge the best of the existing and the new search dialog.
>
OK.
> I would prefer it as separate smaller steps.
> So one patch where you move the dialog and another where you improve
> the search dialog.
>
Move the dialog from where, to where, and in what respect?
Regards,
Shlomi Fish
---------------------------------------------------------------------
Shlomi Fish [email protected]
Homepage: http://www.shlomifish.org/
Chuck Norris wrote a complete Perl 6 implementation in a day but then
destroyed all evidence with his bare hands, so no one will know his secrets.
On Fri, 5 Jan 2007 12:44:13 +0200 Shlomi Fish wrote:
> On Wednesday 03 January 2007 23:05, Sam Ravnborg wrote:
> > On Wed, Jan 03, 2007 at 10:01:28PM +0200, Shlomi Fish wrote:
> > > Interesting. I didn't notice this search dialog before because its menu
> > > item was placed in the "File" menu, which is the wrong place for a find
> > > command (Which should be in an "Edit" or "Search" menu). I believe others
> > > have missed it as well. Also, it is possible it wasn't available when I
> > > wrote the preliminary version of the patch back in March.
> > >
> > > Aside from that my search dialog has some advantages:
> > >
> > > 1. Full text search - if you search for "available" in File->Search you
> > > won't find anything. Searching for it in Edit->Find will find many
> > > things. I think File->Search only searches using the identifiers or at
> > > most also the title.
> > >
> > > 2. Regular expression search.
> > >
> > > 3. Displaying the results in a tree, with their context.
> > >
> > > All that said, I don't mind merging my modifications into the existing
> > > code, or replacing it entirely.
> >
> > Please merge the best of the existing and the new search dialog.
> >
>
> OK.
>
> > I would prefer it as separate smaller steps.
> > So one patch where you move the dialog and another where you improve
> > the search dialog.
> >
>
> Move the dialog from where, to where, and in what respect?
>From where it currently is in mainline (File/Find) to where your
patch puts it (Edit/Find). And then "fix" the Find function in a
separate patch.
---
~Randy
On Friday 05 January 2007 11:44, Shlomi Fish wrote:
> > I would prefer it as separate smaller steps.
> > So one patch where you move the dialog and another where you improve
> > the search dialog.
>
> Move the dialog from where, to where, and in what respect?
Move the Find entry to a separate menu and then add improvements on top of the
current find infrastructure and please don't just change the current
behaviour, give the user a choice.
bye, Roman