2007-01-07 15:17:47

by Tino Keitel

[permalink] [raw]
Subject: 2.6.20-rc3 regression: suspend to RAM broken on Mac mini Core Duo

Hi folks,

I tried 2.6.20-rc3 and suspend to RAM is now broken. The screen stays
dark after resume, the same with the network link. It worked with
2.6.18 (I skipped 2.6.19 because of a regression in the sky2 driver).

I enabled pm_trace and did a echo mem > /sys/power/state in single user
mode.

After the reboot, all I got from pm_trace is this:

ACPI: (supports S0 S3 S4 S5)
Magic number: 0:798:636
hash matches drivers/base/power/resume.c:46
Freeing unused kernel memory: 228k freed

This is line 46 in resume.c:

TRACE_RESUME(error);

No information about the device/driver that refuses to resume.

I think that this is a regression, as it worked with 2.6.18 and the
kernel config is the same. The hardare is a Mac mini Core Duo.

Regards,
Tino


2007-01-07 18:21:53

by Lee Revell

[permalink] [raw]
Subject: Re: 2.6.20-rc3 regression: suspend to RAM broken on Mac mini Core Duo

On Sun, 2007-01-07 at 16:17 +0100, Tino Keitel wrote:
> No information about the device/driver that refuses to resume.

You should be able to identify the problematic driver by removing each
driver manually before suspending.

Lee

2007-01-07 20:04:59

by Tino Keitel

[permalink] [raw]
Subject: Re: 2.6.20-rc3 regression: suspend to RAM broken on Mac mini Core Duo

On Sun, Jan 07, 2007 at 13:23:13 -0500, Lee Revell wrote:
> On Sun, 2007-01-07 at 16:17 +0100, Tino Keitel wrote:
> > No information about the device/driver that refuses to resume.
>
> You should be able to identify the problematic driver by removing each
> driver manually before suspending.

I can not reproduce it anymore, resume now works. I really hope that it
will stay so.

Regards,
Tino

2007-01-07 22:27:13

by Tino Keitel

[permalink] [raw]
Subject: Re: 2.6.20-rc3 regression: suspend to RAM broken on Mac mini Core Duo

On Sun, Jan 07, 2007 at 21:04:53 +0100, Tino Keitel wrote:
> On Sun, Jan 07, 2007 at 13:23:13 -0500, Lee Revell wrote:
> > On Sun, 2007-01-07 at 16:17 +0100, Tino Keitel wrote:
> > > No information about the device/driver that refuses to resume.
> >
> > You should be able to identify the problematic driver by removing each
> > driver manually before suspending.
>
> I can not reproduce it anymore, resume now works. I really hope that it
> will stay so.

It didn't. It looks like it is unusable, becuase it isn't reliable in
2.6.20-rc3.

Regards,
Tino

2007-01-07 23:44:42

by Adrian Bunk

[permalink] [raw]
Subject: Re: 2.6.20-rc3 regression: suspend to RAM broken on Mac mini Core Duo

On Sun, Jan 07, 2007 at 11:27:06PM +0100, Tino Keitel wrote:
> On Sun, Jan 07, 2007 at 21:04:53 +0100, Tino Keitel wrote:
> > On Sun, Jan 07, 2007 at 13:23:13 -0500, Lee Revell wrote:
> > > On Sun, 2007-01-07 at 16:17 +0100, Tino Keitel wrote:
> > > > No information about the device/driver that refuses to resume.
> > >
> > > You should be able to identify the problematic driver by removing each
> > > driver manually before suspending.
> >
> > I can not reproduce it anymore, resume now works. I really hope that it
> > will stay so.
>
> It didn't. It looks like it is unusable, becuase it isn't reliable in
> 2.6.20-rc3.

Is this issue still present in -rc4?

> Regards,
> Tino

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

2007-01-08 21:04:31

by Tino Keitel

[permalink] [raw]
Subject: Re: 2.6.20-rc3 regression: suspend to RAM broken on Mac mini Core Duo

On Mon, Jan 08, 2007 at 00:44:45 +0100, Adrian Bunk wrote:
> On Sun, Jan 07, 2007 at 11:27:06PM +0100, Tino Keitel wrote:
> > On Sun, Jan 07, 2007 at 21:04:53 +0100, Tino Keitel wrote:
> > > On Sun, Jan 07, 2007 at 13:23:13 -0500, Lee Revell wrote:
> > > > On Sun, 2007-01-07 at 16:17 +0100, Tino Keitel wrote:
> > > > > No information about the device/driver that refuses to resume.
> > > >
> > > > You should be able to identify the problematic driver by removing each
> > > > driver manually before suspending.
> > >
> > > I can not reproduce it anymore, resume now works. I really hope that it
> > > will stay so.
> >
> > It didn't. It looks like it is unusable, becuase it isn't reliable in
> > 2.6.20-rc3.
>
> Is this issue still present in -rc4?

I used 2.6.20-rc4 in single user mode, and applied 2 patches from
netdev to get wake on LAN support. This way I was able to set up an
automatic suspend/resume loop. It looked good, but after e.g. 20
minutes, the resume hang. So it is reproduceable with 2.6.20-rc4.
Unfortunately, I can not test the same with 2.6.18, as the wake on LAN
patches need 2.6.20-rc.

Regards,
Tino

2007-01-08 21:17:12

by Pavel Machek

[permalink] [raw]
Subject: Re: 2.6.20-rc3 regression: suspend to RAM broken on Mac mini Core Duo

On Sun 2007-01-07 23:27:06, Tino Keitel wrote:
> On Sun, Jan 07, 2007 at 21:04:53 +0100, Tino Keitel wrote:
> > On Sun, Jan 07, 2007 at 13:23:13 -0500, Lee Revell wrote:
> > > On Sun, 2007-01-07 at 16:17 +0100, Tino Keitel wrote:
> > > > No information about the device/driver that refuses to resume.
> > >
> > > You should be able to identify the problematic driver by removing each
> > > driver manually before suspending.
> >
> > I can not reproduce it anymore, resume now works. I really hope that it
> > will stay so.
>
> It didn't. It looks like it is unusable, becuase it isn't reliable in
> 2.6.20-rc3.

What was last working version? Can you pinpoint driver breaking it?

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

2007-01-08 22:02:40

by Tino Keitel

[permalink] [raw]
Subject: Re: 2.6.20-rc3 regression: suspend to RAM broken on Mac mini Core Duo

On Mon, Jan 08, 2007 at 17:17:19 +0100, Pavel Machek wrote:
> On Sun 2007-01-07 23:27:06, Tino Keitel wrote:
> > On Sun, Jan 07, 2007 at 21:04:53 +0100, Tino Keitel wrote:
> > > On Sun, Jan 07, 2007 at 13:23:13 -0500, Lee Revell wrote:
> > > > On Sun, 2007-01-07 at 16:17 +0100, Tino Keitel wrote:
> > > > > No information about the device/driver that refuses to resume.
> > > >
> > > > You should be able to identify the problematic driver by removing each
> > > > driver manually before suspending.
> > >
> > > I can not reproduce it anymore, resume now works. I really hope that it
> > > will stay so.
> >
> > It didn't. It looks like it is unusable, becuase it isn't reliable in
> > 2.6.20-rc3.
>
> What was last working version? Can you pinpoint driver breaking it?

I just used 2.6.18.2 with a manual driven suspend/resume loop and fully
loaded userspace for ca. 40 minutes, without a failure.

I tried to pinpoint the driver with pm_trace, without success (see my
original posting).

Regards,
Tino

2007-01-08 23:28:07

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: 2.6.20-rc3 regression: suspend to RAM broken on Mac mini Core Duo

On Monday, 8 January 2007 23:02, Tino Keitel wrote:
> On Mon, Jan 08, 2007 at 17:17:19 +0100, Pavel Machek wrote:
> > On Sun 2007-01-07 23:27:06, Tino Keitel wrote:
> > > On Sun, Jan 07, 2007 at 21:04:53 +0100, Tino Keitel wrote:
> > > > On Sun, Jan 07, 2007 at 13:23:13 -0500, Lee Revell wrote:
> > > > > On Sun, 2007-01-07 at 16:17 +0100, Tino Keitel wrote:
> > > > > > No information about the device/driver that refuses to resume.
> > > > >
> > > > > You should be able to identify the problematic driver by removing each
> > > > > driver manually before suspending.
> > > >
> > > > I can not reproduce it anymore, resume now works. I really hope that it
> > > > will stay so.
> > >
> > > It didn't. It looks like it is unusable, becuase it isn't reliable in
> > > 2.6.20-rc3.
> >
> > What was last working version? Can you pinpoint driver breaking it?
>
> I just used 2.6.18.2 with a manual driven suspend/resume loop and fully
> loaded userspace for ca. 40 minutes, without a failure.
>
> I tried to pinpoint the driver with pm_trace, without success (see my
> original posting).

Could you please verify if the issue is reproducible when you boot with
init=/bin/bash and suspend with the minimal list of modules loaded?

Rafael


--
If you don't have the time to read,
you don't have the time or the tools to write.
- Stephen King

2007-01-09 14:51:07

by Luming Yu

[permalink] [raw]
Subject: Re: 2.6.20-rc3 regression: suspend to RAM broken on Mac mini Core Duo

> > > It didn't. It looks like it is unusable, becuase it isn't reliable in
> > > 2.6.20-rc3.
> >
> > Is this issue still present in -rc4?
>
> I used 2.6.20-rc4 in single user mode, and applied 2 patches from
> netdev to get wake on LAN support. This way I was able to set up an
> automatic suspend/resume loop. It looked good, but after e.g. 20
> minutes, the resume hang. So it is reproduceable with 2.6.20-rc4.
> Unfortunately, I can not test the same with 2.6.18, as the wake on LAN
> patches need 2.6.20-rc.

Hmm, do you mean this is the first time of this kind of testing?
Is this issue related to LAN driver?
I guess you should be able to set up an automatic suspend/resume loop
with /proc/acpi/alarm, and test similar with 2.6.18.

--Luming

2007-01-10 06:53:44

by Tino Keitel

[permalink] [raw]
Subject: Re: 2.6.20-rc3 regression: suspend to RAM broken on Mac mini Core Duo

On Tue, Jan 09, 2007 at 22:51:04 +0800, Luming Yu wrote:
> >> > It didn't. It looks like it is unusable, becuase it isn't reliable in
> >> > 2.6.20-rc3.
> >>
> >> Is this issue still present in -rc4?
> >
> >I used 2.6.20-rc4 in single user mode, and applied 2 patches from
> >netdev to get wake on LAN support. This way I was able to set up an
> >automatic suspend/resume loop. It looked good, but after e.g. 20
> >minutes, the resume hang. So it is reproduceable with 2.6.20-rc4.
> >Unfortunately, I can not test the same with 2.6.18, as the wake on LAN
> >patches need 2.6.20-rc.
>
> Hmm, do you mean this is the first time of this kind of testing?
> Is this issue related to LAN driver?
> I guess you should be able to set up an automatic suspend/resume loop
> with /proc/acpi/alarm, and test similar with 2.6.18.

Thanks for the hint. I just used /proc/acpi/alarm to set up a
suspend/resume loop and did ca. 100 cycles in a row with 2.6.18.2 in
single user mode, without a failure.

Regards,
Tino

2007-01-12 22:23:35

by Pavel Machek

[permalink] [raw]
Subject: Re: 2.6.20-rc3 regression: suspend to RAM broken on Mac mini Core Duo

Hi!

> > >> > It didn't. It looks like it is unusable, becuase it isn't reliable in
> > >> > 2.6.20-rc3.
> > >>
> > >> Is this issue still present in -rc4?
> > >
> > >I used 2.6.20-rc4 in single user mode, and applied 2 patches from
> > >netdev to get wake on LAN support. This way I was able to set up an
> > >automatic suspend/resume loop. It looked good, but after e.g. 20
> > >minutes, the resume hang. So it is reproduceable with 2.6.20-rc4.
> > >Unfortunately, I can not test the same with 2.6.18, as the wake on LAN
> > >patches need 2.6.20-rc.
> >
> > Hmm, do you mean this is the first time of this kind of testing?
> > Is this issue related to LAN driver?
> > I guess you should be able to set up an automatic suspend/resume loop
> > with /proc/acpi/alarm, and test similar with 2.6.18.
>
> Thanks for the hint. I just used /proc/acpi/alarm to set up a
> suspend/resume loop and did ca. 100 cycles in a row with 2.6.18.2 in
> single user mode, without a failure.

Can you do similar test on 2.6.20 -- w/o network driver loaded (and
generaly minimum drivers?)
Pavel

--
Thanks for all the (sleeping) penguins.

2007-01-13 03:05:33

by Tino Keitel

[permalink] [raw]
Subject: Re: 2.6.20-rc3 regression: suspend to RAM broken on Mac mini Core Duo

On Fri, Jan 12, 2007 at 14:50:25 +0000, Pavel Machek wrote:
> Hi!
>
> > > >> > It didn't. It looks like it is unusable, becuase it isn't reliable in
> > > >> > 2.6.20-rc3.
> > > >>
> > > >> Is this issue still present in -rc4?
> > > >
> > > >I used 2.6.20-rc4 in single user mode, and applied 2 patches from
> > > >netdev to get wake on LAN support. This way I was able to set up an
> > > >automatic suspend/resume loop. It looked good, but after e.g. 20
> > > >minutes, the resume hang. So it is reproduceable with 2.6.20-rc4.
> > > >Unfortunately, I can not test the same with 2.6.18, as the wake on LAN
> > > >patches need 2.6.20-rc.
> > >
> > > Hmm, do you mean this is the first time of this kind of testing?
> > > Is this issue related to LAN driver?
> > > I guess you should be able to set up an automatic suspend/resume loop
> > > with /proc/acpi/alarm, and test similar with 2.6.18.
> >
> > Thanks for the hint. I just used /proc/acpi/alarm to set up a
> > suspend/resume loop and did ca. 100 cycles in a row with 2.6.18.2 in
> > single user mode, without a failure.
>
> Can you do similar test on 2.6.20 -- w/o network driver loaded (and
> generaly minimum drivers?)

I think I found the problem. In 2.6.18, I had a slightly different
config. With 2.6.20-rc4, I had sucessful suspend/resume cycles without
the USB DVB-T box attached. I tweaked the USB options a bit and
activated some options (CONFIG_USB_SUSPEND,
CONFIG_USB_MULTITHREAD_PROBE, CONFIG_USB_EHCI_SPLIT_ISO,
CONFIG_USB_EHCI_ROOT_HUB_TT, CONFIG_USB_EHCI_TT_NEWSCHED) and now I can
suspend/resume without hangs. At least I haven't seen one until now.

Thanks for you patience and regards,
Tino

2007-01-13 03:45:17

by Tino Keitel

[permalink] [raw]
Subject: Re: 2.6.20-rc3 regression: suspend to RAM broken on Mac mini Core Duo

On Sat, Jan 13, 2007 at 04:05:28 +0100, Tino Keitel wrote:

[...]

> I think I found the problem. In 2.6.18, I had a slightly different
> config. With 2.6.20-rc4, I had sucessful suspend/resume cycles without
> the USB DVB-T box attached. I tweaked the USB options a bit and
> activated some options (CONFIG_USB_SUSPEND,
> CONFIG_USB_MULTITHREAD_PROBE, CONFIG_USB_EHCI_SPLIT_ISO,
> CONFIG_USB_EHCI_ROOT_HUB_TT, CONFIG_USB_EHCI_TT_NEWSCHED) and now I can
> suspend/resume without hangs. At least I haven't seen one until now.

Just after I sent the mail, I had 2 failures again. :-(

Regards,
Tino

2007-01-13 10:18:30

by Pavel Machek

[permalink] [raw]
Subject: Re: 2.6.20-rc3 regression: suspend to RAM broken on Mac mini Core Duo

On Sat 2007-01-13 04:45:12, Tino Keitel wrote:
> On Sat, Jan 13, 2007 at 04:05:28 +0100, Tino Keitel wrote:
>
> [...]
>
> > I think I found the problem. In 2.6.18, I had a slightly different
> > config. With 2.6.20-rc4, I had sucessful suspend/resume cycles without
> > the USB DVB-T box attached. I tweaked the USB options a bit and
> > activated some options (CONFIG_USB_SUSPEND,
> > CONFIG_USB_MULTITHREAD_PROBE, CONFIG_USB_EHCI_SPLIT_ISO,
> > CONFIG_USB_EHCI_ROOT_HUB_TT, CONFIG_USB_EHCI_TT_NEWSCHED) and now I can
> > suspend/resume without hangs. At least I haven't seen one until now.
>
> Just after I sent the mail, I had 2 failures again. :-(

CONFIG_USB_MULTITHREAD_PROBE is known bad.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

2007-01-13 11:02:59

by Tino Keitel

[permalink] [raw]
Subject: Re: 2.6.20-rc3 regression: suspend to RAM broken on Mac mini Core Duo

On Sat, Jan 13, 2007 at 04:45:12 +0100, Tino Keitel wrote:
> On Sat, Jan 13, 2007 at 04:05:28 +0100, Tino Keitel wrote:
>
> [...]
>
> > I think I found the problem. In 2.6.18, I had a slightly different
> > config. With 2.6.20-rc4, I had sucessful suspend/resume cycles without
> > the USB DVB-T box attached. I tweaked the USB options a bit and
> > activated some options (CONFIG_USB_SUSPEND,
> > CONFIG_USB_MULTITHREAD_PROBE, CONFIG_USB_EHCI_SPLIT_ISO,
> > CONFIG_USB_EHCI_ROOT_HUB_TT, CONFIG_USB_EHCI_TT_NEWSCHED) and now I can
> > suspend/resume without hangs. At least I haven't seen one until now.
>
> Just after I sent the mail, I had 2 failures again. :-(

PM_TRACE revealed that the Ethernet driver (sky2) failed to resume. I
removed the patches for wake on LAN and hope that it works now.

Regards,
Tino