2007-01-30 23:14:53

by Robert Hancock

[permalink] [raw]
Subject: Re: [linux-usb-devel] 2.6.20-rc6 SCSI error: I/O error - trouble with mass storage devices ?!

Alan Stern wrote:

> The log revealed that the phone's firmware returns garbage values in the
> Residue field for some WRITEs. This patch should take care of it.
>
> Alan Stern

Is it just me, or should some of these device quirk entries that keep
being added be made unconditional? Adding entries for every single
device that shows up with these problems seems like not a very scalable
approach. These devices obviously work in Windows, can't we just emulate
its behavior here?

--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [email protected]
Home Page: http://www.roberthancock.com/


2007-01-31 01:05:00

by Greg KH

[permalink] [raw]
Subject: Re: [linux-usb-devel] 2.6.20-rc6 SCSI error: I/O error - trouble with mass storage devices ?!

On Tue, Jan 30, 2007 at 05:12:54PM -0600, Robert Hancock wrote:
> Alan Stern wrote:
>
> >The log revealed that the phone's firmware returns garbage values in the
> >Residue field for some WRITEs. This patch should take care of it.
> >
> >Alan Stern
>
> Is it just me, or should some of these device quirk entries that keep
> being added be made unconditional? Adding entries for every single
> device that shows up with these problems seems like not a very scalable
> approach. These devices obviously work in Windows, can't we just emulate
> its behavior here?

If you can figure out a way to dynamically detect broken devices like
this, sure, that would be great.

thanks,

greg k-h

2007-01-31 01:07:25

by Robert Hancock

[permalink] [raw]
Subject: Re: [linux-usb-devel] 2.6.20-rc6 SCSI error: I/O error - trouble with mass storage devices ?!

Greg KH wrote:
> On Tue, Jan 30, 2007 at 05:12:54PM -0600, Robert Hancock wrote:
>> Alan Stern wrote:
>>
>>> The log revealed that the phone's firmware returns garbage values in the
>>> Residue field for some WRITEs. This patch should take care of it.
>>>
>>> Alan Stern
>> Is it just me, or should some of these device quirk entries that keep
>> being added be made unconditional? Adding entries for every single
>> device that shows up with these problems seems like not a very scalable
>> approach. These devices obviously work in Windows, can't we just emulate
>> its behavior here?
>
> If you can figure out a way to dynamically detect broken devices like
> this, sure, that would be great.

For at least some of these quirks, would there be any harm in applying
them to all devices?

--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [email protected]
Home Page: http://www.roberthancock.com/

2007-01-31 15:21:04

by Alan Stern

[permalink] [raw]
Subject: Re: [linux-usb-devel] 2.6.20-rc6 SCSI error: I/O error - trouble with mass storage devices ?!

On Tue, 30 Jan 2007, Robert Hancock wrote:

> Alan Stern wrote:
>
> > The log revealed that the phone's firmware returns garbage values in the
> > Residue field for some WRITEs. This patch should take care of it.
> >
> > Alan Stern
>
> Is it just me, or should some of these device quirk entries that keep
> being added be made unconditional? Adding entries for every single
> device that shows up with these problems seems like not a very scalable
> approach. These devices obviously work in Windows, can't we just emulate
> its behavior here?

I have had the same thought...

Just because Windows (and a bunch of clueless firmware writers) does
something wrong shouldn't mean that we do it too. The fact is, these
devices are in violation of the appropriate SCSI and USB specifications.

Ignoring the residue value can actually lead to undiscovered errors.
According to the spec, it's perfectly legal for a device to return an
error indication there and nowhere else.

Alan Stern