2007-01-31 03:57:46

by Daniel Walker

Subject: [PATCH 01/23] clocksource: drop clocksource-add-verification-watchdog-helper-fix.patch

Drop.

Signed-Off-By: Daniel Walker <[email protected]>

---
kernel/time/clocksource.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)

Index: linux-2.6.19/kernel/time/clocksource.c
===================================================================
--- linux-2.6.19.orig/kernel/time/clocksource.c
+++ linux-2.6.19/kernel/time/clocksource.c
@@ -28,7 +28,6 @@
#include <linux/sysdev.h>
#include <linux/init.h>
#include <linux/module.h>
-#include <linux/tick.h>

/* XXX - Would like a better way for initializing curr_clocksource */
extern struct clocksource clocksource_jiffies;
@@ -107,16 +106,8 @@ static void clocksource_watchdog(unsigne
/* Initialized ? */
if (!(cs->flags & CLOCK_SOURCE_WATCHDOG)) {
if ((cs->flags & CLOCK_SOURCE_IS_CONTINUOUS) &&
- (watchdog->flags & CLOCK_SOURCE_IS_CONTINUOUS)) {
+ (watchdog->flags & CLOCK_SOURCE_IS_CONTINUOUS))
cs->flags |= CLOCK_SOURCE_VALID_FOR_HRES;
- /*
- * We just marked the clocksource as
- * highres-capable, notify the rest of the
- * system as well so that we transition
- * into high-res mode:
- */
- tick_clock_notify();
- }
cs->flags |= CLOCK_SOURCE_WATCHDOG;
cs->wd_last = csnow;
} else {

--

2007-01-31 12:48:59

by Ingo Molnar

Subject: Re: [PATCH 01/23] clocksource: drop clocksource-add-verification-watchdog-helper-fix.patch

* Daniel Walker <[email protected]> wrote:

> Drop.

i'm summarily replying to your 4 'Drop' patches: what you didnt explain
is /why/ you dropped these patches. I.e. why you think they are bad and
how you think your solution is better. Without doing such analysis you
shouldnt just be dropping patches of others like this.

Ingo