2007-02-16 13:46:43

by Adam J. Richter

[permalink] [raw]
Subject: Patch: move struct sysfs_dirent to private header

Hi Greg,

This is a resubmission of a patch that fell through the
cracks long ago. I've posted it a couple of times, and don't recall
anyone objecting to it.

struct sysfs_dirent is private to the fs/sysfs/ subtree. It is
not even referenced as an opaque structure outside of that subtree.

The following patch moves the declaration from
include/linux/sysfs.h to fs/sysfs/sysfs.h, making it clearer
that nothing else in the kernel dereferences it.

I have been running this patch for years. Please integrate
and forward upstream if there are no objections.

Note that while this patch was generated by stgit, it
was not generated from a tree pulled from kernel.org, so perhaps
a git command that thinks that this patch was generated from a
common ancestor might get confused (I'm not sure). You may want
to integrate it by running patch and checking in the change.

The patch is against 2.6.20-git11.

Adam Richter


Attachments:
(No filename) (925.00 B)
sysfs-dirent.diff (1.31 kB)
Download all attachments