2007-02-26 22:41:36

by David Miller

[permalink] [raw]
Subject: cpufreq build regression added today


Dave, please test your const'ification changes, else you'll
leave some of us const'ipated :-)

drivers/cpufreq/cpufreq.c: In function 'cpufreq_register_driver'
drivers/cpufreq/cpufreq.c:1767: error: assignment of read-only location

Thanks.


2007-02-26 22:46:52

by Dave Jones

[permalink] [raw]
Subject: Re: cpufreq build regression added today

On Mon, Feb 26, 2007 at 02:41:34PM -0800, David Miller wrote:
>
> Dave, please test your const'ification changes, else you'll
> leave some of us const'ipated :-)
>
> drivers/cpufreq/cpufreq.c: In function 'cpufreq_register_driver'
> drivers/cpufreq/cpufreq.c:1767: error: assignment of read-only location

Damn you're fast.
That stuff wasn't near ready to go to mainline, I've asked Linus
to revert. Mea Culpa.

Dave

--
http://www.codemonkey.org.uk

2007-02-27 07:58:55

by Olaf Hering

[permalink] [raw]
Subject: Re: cpufreq build regression added today

On Mon, Feb 26, Dave Jones wrote:

> On Mon, Feb 26, 2007 at 02:41:34PM -0800, David Miller wrote:
> >
> > Dave, please test your const'ification changes, else you'll
> > leave some of us const'ipated :-)
> >
> > drivers/cpufreq/cpufreq.c: In function 'cpufreq_register_driver'
> > drivers/cpufreq/cpufreq.c:1767: error: assignment of read-only location
>
> Damn you're fast.
> That stuff wasn't near ready to go to mainline, I've asked Linus
> to revert. Mea Culpa.

e5524f355a0d272ba5233537a896a668db1f3008 is partly broken as well.

-struct agp_bridge_driver uninorth_agp_driver = {
+struct const agp_bridge_driver uninorth_agp_driver = {

2007-02-27 15:50:34

by Dave Jones

[permalink] [raw]
Subject: Re: cpufreq build regression added today

On Tue, Feb 27, 2007 at 08:59:37AM +0100, Olaf Hering wrote:
> On Mon, Feb 26, Dave Jones wrote:
>
> > On Mon, Feb 26, 2007 at 02:41:34PM -0800, David Miller wrote:
> > >
> > > Dave, please test your const'ification changes, else you'll
> > > leave some of us const'ipated :-)
> > >
> > > drivers/cpufreq/cpufreq.c: In function 'cpufreq_register_driver'
> > > drivers/cpufreq/cpufreq.c:1767: error: assignment of read-only location
> >
> > Damn you're fast.
> > That stuff wasn't near ready to go to mainline, I've asked Linus
> > to revert. Mea Culpa.
>
> e5524f355a0d272ba5233537a896a668db1f3008 is partly broken as well.

It's not my week.
Fixed in agpgart.git, and asked Linus to pull.

Dave

--
http://www.codemonkey.org.uk