2007-05-01 20:43:55

by Geert Uytterhoeven

[permalink] [raw]
Subject: [patch 06/33] m68k: CROSS_COMPILE = m68k-linux-gnu-

Recent cross-compilers are called m68k-linux-gnu-gcc instead of m68k-linux-gcc

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
arch/m68k/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-m68k-2.6.21.orig/arch/m68k/Makefile
+++ linux-m68k-2.6.21/arch/m68k/Makefile
@@ -21,7 +21,7 @@ AS += -m68020
LDFLAGS := -m m68kelf
ifneq ($(COMPILE_ARCH),$(ARCH))
# prefix for cross-compiling binaries
- CROSS_COMPILE = m68k-linux-
+ CROSS_COMPILE = m68k-linux-gnu-
endif

ifdef CONFIG_SUN3

--
Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


2007-05-01 22:56:10

by Ville Syrjälä

[permalink] [raw]
Subject: Re: [patch 06/33] m68k: CROSS_COMPILE = m68k-linux-gnu-

On Tue, May 01, 2007 at 10:32:40PM +0200, Geert Uytterhoeven wrote:
> Recent cross-compilers are called m68k-linux-gnu-gcc instead of m68k-linux-gcc
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> arch/m68k/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-m68k-2.6.21.orig/arch/m68k/Makefile
> +++ linux-m68k-2.6.21/arch/m68k/Makefile
> @@ -21,7 +21,7 @@ AS += -m68020
> LDFLAGS := -m m68kelf
> ifneq ($(COMPILE_ARCH),$(ARCH))
> # prefix for cross-compiling binaries
> - CROSS_COMPILE = m68k-linux-
> + CROSS_COMPILE = m68k-linux-gnu-
> endif
>
> ifdef CONFIG_SUN3

What about using ?= so the user can override it. I sent a patch doing
just that but never got any response.

--
Ville Syrj?l?
[email protected]
http://www.sci.fi/~syrjala/

2007-05-06 11:26:21

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [patch 06/33] m68k: CROSS_COMPILE = m68k-linux-gnu-

On Wed, 2 May 2007, Ville Syrj?l? wrote:
> On Tue, May 01, 2007 at 10:32:40PM +0200, Geert Uytterhoeven wrote:
> > Recent cross-compilers are called m68k-linux-gnu-gcc instead of m68k-linux-gcc
> >
> > Signed-off-by: Geert Uytterhoeven <[email protected]>
> > ---
> > arch/m68k/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- linux-m68k-2.6.21.orig/arch/m68k/Makefile
> > +++ linux-m68k-2.6.21/arch/m68k/Makefile
> > @@ -21,7 +21,7 @@ AS += -m68020
> > LDFLAGS := -m m68kelf
> > ifneq ($(COMPILE_ARCH),$(ARCH))
> > # prefix for cross-compiling binaries
> > - CROSS_COMPILE = m68k-linux-
> > + CROSS_COMPILE = m68k-linux-gnu-
> > endif
> >
> > ifdef CONFIG_SUN3
>
> What about using ?= so the user can override it. I sent a patch doing
> just that but never got any response.

I just gave it a try, and compilation failed because it used plain gcc
instead of m68k-linux-gnu-gcc.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2007-05-06 12:55:58

by Ville Syrjälä

[permalink] [raw]
Subject: Re: [patch 06/33] m68k: CROSS_COMPILE = m68k-linux-gnu-

On Sun, May 06, 2007 at 01:26:17PM +0200, Geert Uytterhoeven wrote:
> On Wed, 2 May 2007, Ville Syrj?l? wrote:
> > On Tue, May 01, 2007 at 10:32:40PM +0200, Geert Uytterhoeven wrote:
> > > Recent cross-compilers are called m68k-linux-gnu-gcc instead of m68k-linux-gcc
> > >
> > > Signed-off-by: Geert Uytterhoeven <[email protected]>
> > > ---
> > > arch/m68k/Makefile | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > --- linux-m68k-2.6.21.orig/arch/m68k/Makefile
> > > +++ linux-m68k-2.6.21/arch/m68k/Makefile
> > > @@ -21,7 +21,7 @@ AS += -m68020
> > > LDFLAGS := -m m68kelf
> > > ifneq ($(COMPILE_ARCH),$(ARCH))
> > > # prefix for cross-compiling binaries
> > > - CROSS_COMPILE = m68k-linux-
> > > + CROSS_COMPILE = m68k-linux-gnu-
> > > endif
> > >
> > > ifdef CONFIG_SUN3
> >
> > What about using ?= so the user can override it. I sent a patch doing
> > just that but never got any response.
>
> I just gave it a try, and compilation failed because it used plain gcc
> instead of m68k-linux-gnu-gcc.

Argh. You're correct of course. Apparently I never tried it without
setting CROSS_COMPILE. The problem is in the top level Makefile:
CROSS_COMPILE ?=
and
export CROSS_COMPILE

If I remove those it works, but I don't know if removing them is a good
idea in general (especially the export). Maybe the ?= thing can be
removed and the export can be moved after including the arch Makefile?

--
Ville Syrj?l?
[email protected]
http://www.sci.fi/~syrjala/