On Sat, Mar 03, 2007 at 05:21:40AM +0000, Christoph Hellwig wrote:
> Umm, I can't remember the updated driver ever beeig posted for review.
> And to be honest I'd be surprised if it's in a good shape already.
Of course it's not anywhere near good shape. Almost all items from my
review were completely ignored, and we have another totoally substandard
wireless driver with crappy thread handling, a huge number of broken private
ioctls and partially absymal codingstyle.
And I didn't even get a reply to my mail addressing the concerns above.
On Mon, 2007-05-07 at 11:41 +0100, Christoph Hellwig wrote:
> On Sat, Mar 03, 2007 at 05:21:40AM +0000, Christoph Hellwig wrote:
> > Umm, I can't remember the updated driver ever beeig posted for review.
> > And to be honest I'd be surprised if it's in a good shape already.
>
> Of course it's not anywhere near good shape. Almost all items from my
> review were completely ignored, and we have another totoally substandard
> wireless driver with crappy thread handling, a huge number of broken private
> ioctls and partially absymal codingstyle.
- things like 11d.[ch] don't have business of being in a driver,
this should be somewhere in common code.
There is no common code for this. mac80211 will eventually grow a
utility library that libertas will hopefully be able to attach to.
- please get rid of the ENTER/LEAVE macros
People have said that many drivers do this, and it's quite useful for
debugging.
- please get rid of all your private ioctls and iwpriv stuff
(should I add !!!! here)
Any ioctls that have equivalents in WEXT or ethtool can certainly be
removed. Mesh ones like fwt_reset, bt_reset, mesh_get_ttl, etc have no
current equivalents and will need to stick around. I've already removed
all the ones that were relevant for WPA and moved them to standard WEXT
calls.
- most of types.h should not be there but you should be using
the types from include/linux/*80211*
I've already updated libertas-2.6 git with a ton of updates for this.
In any case, lets push off any merge until 2.6.23 so the rest of the
comments can be dealt with:
- the __le* annotation issue you mentioned in the mail is important.
- there shouldn't be a LICENSE file in individual driver directories,
especially if it's just plain old GPLv2.
- please get rid of setting -DFOO flags in the Makefile, just use
these directly as config symbols.
- there shouldn't be a README file in the driver directory, this
should be in Documentation/
- please don't use wlan_* foo types. a) this should be structs, not
typedefs, and b) wlan is an utterly generic name for beeing inside
a driver.
- there seems to be lots of tabs vs spaces messups
- there's an awful lot of headers without clear divided
responsibilities,
there should be only a few ones left (internal interfaces and hw
interface basically)
- having lowercase names for lots of hw commands is a very bad idea
for readability
- etc
Dan
> And I didn't even get a reply to my mail addressing the concerns above.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, May 07, 2007 at 08:03:43AM -0400, Dan Williams wrote:
> On Mon, 2007-05-07 at 11:41 +0100, Christoph Hellwig wrote:
> > Of course it's not anywhere near good shape. Almost all items from my
> > review were completely ignored, and we have another totoally substandard
> > wireless driver with crappy thread handling, a huge number of broken private
> > ioctls and partially absymal codingstyle.
> I've already updated libertas-2.6 git with a ton of updates for this.
>
> In any case, lets push off any merge until 2.6.23 so the rest of the
> comments can be dealt with:
Alright...Jeff, would you please pull the following branch for upstream ASAP:
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git revert-libertas
Thanks,
John
--
John W. Linville
[email protected]
John W. Linville wrote:
> On Mon, May 07, 2007 at 08:03:43AM -0400, Dan Williams wrote:
>> On Mon, 2007-05-07 at 11:41 +0100, Christoph Hellwig wrote:
>
>>> Of course it's not anywhere near good shape. Almost all items from my
>>> review were completely ignored, and we have another totoally substandard
>>> wireless driver with crappy thread handling, a huge number of broken private
>>> ioctls and partially absymal codingstyle.
>
>> I've already updated libertas-2.6 git with a ton of updates for this.
>>
>> In any case, lets push off any merge until 2.6.23 so the rest of the
>> comments can be dealt with:
>
> Alright...Jeff, would you please pull the following branch for upstream ASAP:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git revert-libertas
This is leading from behind :/ We don't need to blow about in the wind
here. If you reviewed the driver in depth -- which I assumed because of
the trust placed in you as wireless maintainer -- then this situation
really should not be happening. You need to know the status of new
drivers you are pushing upstream: what work is left to do, what has been
done, what state the driver is in.
I view this request as a failure of the trust network :(
For my part, I _did_ review it. Twice. Once in the early days, and
once when I pulled it into my netdev-2.6.git tree. libertas needs the
changes mentioned in this thread. But the driver is in workable shape
to be USED while being improved. I strongly dislike people being cowed
into not merging a driver for years, because the driver in question does
not meet Christoph's idea of perfection.
Open source is about release early, release often. Not "hide code in a
dark corner until Christoph thinks it is perfect." We have high
standards for upstream merged code, but that standard is not perfection.
Perfect is the enemy of good.
I would rather see the libertas-2.6 git changes pulled into upstream,
and am not inclined to revert a WORKING DRIVER at this point, a driver
that is actively maintained and has seen quite a bit of improvement
since it initially appeared.
IMO, Linux users best served by avoiding this silly song and dance, now
that the driver is upstream.
Plus, that leaves the kernel history less polluted.
Jeff
On Mon, 2007-05-07 at 11:22 -0400, Jeff Garzik wrote:
> John W. Linville wrote:
> > On Mon, May 07, 2007 at 08:03:43AM -0400, Dan Williams wrote:
> >> On Mon, 2007-05-07 at 11:41 +0100, Christoph Hellwig wrote:
> >
> >>> Of course it's not anywhere near good shape. Almost all items from my
> >>> review were completely ignored, and we have another totoally substandard
> >>> wireless driver with crappy thread handling, a huge number of broken private
> >>> ioctls and partially absymal codingstyle.
> >
> >> I've already updated libertas-2.6 git with a ton of updates for this.
> >>
> >> In any case, lets push off any merge until 2.6.23 so the rest of the
> >> comments can be dealt with:
> >
> > Alright...Jeff, would you please pull the following branch for upstream ASAP:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git revert-libertas
>
> This is leading from behind :/ We don't need to blow about in the wind
> here. If you reviewed the driver in depth -- which I assumed because of
> the trust placed in you as wireless maintainer -- then this situation
> really should not be happening. You need to know the status of new
> drivers you are pushing upstream: what work is left to do, what has been
> done, what state the driver is in.
>
> I view this request as a failure of the trust network :(
>
> For my part, I _did_ review it. Twice. Once in the early days, and
> once when I pulled it into my netdev-2.6.git tree. libertas needs the
> changes mentioned in this thread. But the driver is in workable shape
> to be USED while being improved. I strongly dislike people being cowed
> into not merging a driver for years, because the driver in question does
> not meet Christoph's idea of perfection.
>
> Open source is about release early, release often. Not "hide code in a
> dark corner until Christoph thinks it is perfect." We have high
> standards for upstream merged code, but that standard is not perfection.
> Perfect is the enemy of good.
>
> I would rather see the libertas-2.6 git changes pulled into upstream,
> and am not inclined to revert a WORKING DRIVER at this point, a driver
> that is actively maintained and has seen quite a bit of improvement
> since it initially appeared.
>
> IMO, Linux users best served by avoiding this silly song and dance, now
> that the driver is upstream.
Ok, somebody make an executive decision then. As it stands, the driver
_does_ work. Everyone understands it needs the cleanups that Christoph
has mentioned, and those of us who work on it certainly will keep
cleaning it up to hopefully match Christoph's expectations. Some of
that has already been done in upstream git.
So, either we push it off until 2.6.23, or it gets merged as-is and we
clean it up as we go along, which we'll certainly do.
Dan
> Plus, that leaves the kernel history less polluted.
>
> Jeff
>
>
>
>
Dan Williams wrote:
> So, either we push it off until 2.6.23, or it gets merged as-is and we
> clean it up as we go along, which we'll certainly do.
Um, it was merged a while ago.
That's why John's email, and my own, are discussing the revert of the
driver, not the merge of the driver.
The executive decision has been made.
Jeff
On Mon, May 07, 2007 at 11:22:34AM -0400, Jeff Garzik wrote:
> Open source is about release early, release often. Not "hide code in a
> dark corner until Christoph thinks it is perfect." We have high
> standards for upstream merged code, but that standard is not perfection.
> Perfect is the enemy of good.
>
> I would rather see the libertas-2.6 git changes pulled into upstream,
> and am not inclined to revert a WORKING DRIVER at this point, a driver
> that is actively maintained and has seen quite a bit of improvement
> since it initially appeared.
Perhaps I was a bit hasty. Given Dan's response I thought that I
had missed something.
But, you are right -- the driver works now, and Dan and company are
sure to be around to keep working on it.
> Plus, that leaves the kernel history less polluted.
Consider the request withdrawn.
Thanks,
John
--
John W. Linville
[email protected]
On Mon, May 07, 2007 at 11:48:46AM -0400, Jeff Garzik wrote:
> Dan Williams wrote:
> >So, either we push it off until 2.6.23, or it gets merged as-is and we
> >clean it up as we go along, which we'll certainly do.
>
> Um, it was merged a while ago.
>
> That's why John's email, and my own, are discussing the revert of the
> driver, not the merge of the driver.
>
> The executive decision has been made.
Yep, let's keep it -- and keep Dan and Marcelo on the hook... :-)
John
--
John W. Linville
[email protected]
On Mon, May 07, 2007 at 11:22:34AM -0400, Jeff Garzik wrote:
> John W. Linville wrote:
> >On Mon, May 07, 2007 at 08:03:43AM -0400, Dan Williams wrote:
> >>On Mon, 2007-05-07 at 11:41 +0100, Christoph Hellwig wrote:
> >
> >>>Of course it's not anywhere near good shape. Almost all items from my
> >>>review were completely ignored, and we have another totoally substandard
> >>>wireless driver with crappy thread handling, a huge number of broken
> >>>private
> >>>ioctls and partially absymal codingstyle.
> >
> >>I've already updated libertas-2.6 git with a ton of updates for this.
> >>
> >>In any case, lets push off any merge until 2.6.23 so the rest of the
> >>comments can be dealt with:
> >
> >Alright...Jeff, would you please pull the following branch for upstream
> >ASAP:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git revert-libertas
>
> This is leading from behind :/ We don't need to blow about in the wind
> here. If you reviewed the driver in depth -- which I assumed because of
> the trust placed in you as wireless maintainer -- then this situation
> really should not be happening. You need to know the status of new
> drivers you are pushing upstream: what work is left to do, what has been
> done, what state the driver is in.
>
> I view this request as a failure of the trust network :(
>
> For my part, I _did_ review it. Twice. Once in the early days, and
> once when I pulled it into my netdev-2.6.git tree. libertas needs the
> changes mentioned in this thread. But the driver is in workable shape
> to be USED while being improved. I strongly dislike people being cowed
> into not merging a driver for years, because the driver in question does
> not meet Christoph's idea of perfection.
It's a shame to expose new ABI bits that we expect to change to
mainline. Getting rid of obsolete interfaces is next to impossible so
the introduction of new interfaces really does warrant serious
consideration.
Can we come up with a scheme to keep the new ioctls introduced by this
driver from leaking over into distro-land before they get reworked?
Like preemptively adding a deprecation printk?
--
Mathematics is the supreme nostalgia of our time.
Matt Mackall wrote:
> On Mon, May 07, 2007 at 11:22:34AM -0400, Jeff Garzik wrote:
>>For my part, I _did_ review it. Twice. Once in the early days, and
>>once when I pulled it into my netdev-2.6.git tree. libertas needs the
>>changes mentioned in this thread. But the driver is in workable shape
>>to be USED while being improved. I strongly dislike people being cowed
>>into not merging a driver for years, because the driver in question does
>>not meet Christoph's idea of perfection.
>
>
> It's a shame to expose new ABI bits that we expect to change to
> mainline. Getting rid of obsolete interfaces is next to impossible so
> the introduction of new interfaces really does warrant serious
> consideration.
>
> Can we come up with a scheme to keep the new ioctls introduced by this
> driver from leaking over into distro-land before they get reworked?
> Like preemptively adding a deprecation printk?
And it isn't only ioctls, but just having code there to set a bad
example, and added overhead of maintaining APIs used by the
driver.
Two things on top of a lot of people's pet peeves list are lack of
good review bandwidth, and poor driver code! So it is sad this was
merged without Christoph's comments being addressed. "it works for
me, we can fix it later" is probably a big reason for quality
problems of some parts of the kernel.
As for Christoph's idea of perfection... it usually isn't a bad
thing. And he is quite reasonable if you explain your good reason
to disagree or do something differently. The attitude of ignoring
comments can be really demotivating for a reviewer.
--
SUSE Labs, Novell Inc.
On 5/7/07, Jeff Garzik <[email protected]> wrote:
> Open source is about release early, release often. Not "hide code in a
> dark corner until Christoph thinks it is perfect." We have high
> standards for upstream merged code, but that standard is not perfection.
Please. This has nothing to do with Christoph. (1) the driver seems to
break every Linux coding style convention known to man and (2) adds a
new ABI with bunch of ioctls() that apparently haven't been reviewed
properly. That's just not acceptable for mainline kernel!
Pekka
From: "Pekka Enberg" <[email protected]>
Date: Tue, 8 May 2007 12:47:34 +0300
> On 5/7/07, Jeff Garzik <[email protected]> wrote:
> > Open source is about release early, release often. Not "hide code in a
> > dark corner until Christoph thinks it is perfect." We have high
> > standards for upstream merged code, but that standard is not perfection.
>
> Please. This has nothing to do with Christoph. (1) the driver seems to
> break every Linux coding style convention known to man and (2) adds a
> new ABI with bunch of ioctls() that apparently haven't been reviewed
> properly. That's just not acceptable for mainline kernel!
I completely agree, these things should be corrected and if the the
author is being totally unresponsive to Christoph's review that's even
worse.
Every piece of code that I've written that Christoph has reviewed has
become significantly better because of his review.
David Miller wrote:
> From: "Pekka Enberg" <[email protected]>
>> On 5/7/07, Jeff Garzik <[email protected]> wrote:
>>> Open source is about release early, release often. Not "hide code in a
>>> dark corner until Christoph thinks it is perfect." We have high
>>> standards for upstream merged code, but that standard is not perfection.
>> Please. This has nothing to do with Christoph. (1) the driver seems to
>> break every Linux coding style convention known to man and (2) adds a
>> new ABI with bunch of ioctls() that apparently haven't been reviewed
>> properly. That's just not acceptable for mainline kernel!
> I completely agree, these things should be corrected and if the the
> author is being totally unresponsive to Christoph's review that's even
> worse.
Um, the maintainer replied yesterday morning[1] that libertas-2.6.git
has already been updated for these requests, will be updated some more,
and overall was responsive to the entire list of Christoph requests.
I'm mainly concerned with removing the unnecessary ioctls before 2.6.22
release, since that affects userspace. The vast majority of other stuff
is cosmetic, which is being worked on, but lower priority in my book.
Jeff
[1] Message-ID <[email protected]>
Nick Piggin wrote:
> Two things on top of a lot of people's pet peeves list are lack of
> good review bandwidth, and poor driver code! So it is sad this was
> merged without Christoph's comments being addressed. "it works for
> me, we can fix it later" is probably a big reason for quality
> problems of some parts of the kernel.
>
> As for Christoph's idea of perfection... it usually isn't a bad
> thing. And he is quite reasonable if you explain your good reason
> to disagree or do something differently. The attitude of ignoring
> comments can be really demotivating for a reviewer.
I guess it's a good thing that the maintainer was not ignoring the
review comments, then...
(please review the thread before replying, next time)
Jeff
On Tue, 2007-05-08 at 16:55 -0400, Jeff Garzik wrote:
> David Miller wrote:
> > From: "Pekka Enberg" <[email protected]>
> >> On 5/7/07, Jeff Garzik <[email protected]> wrote:
> >>> Open source is about release early, release often. Not "hide code in a
> >>> dark corner until Christoph thinks it is perfect." We have high
> >>> standards for upstream merged code, but that standard is not perfection.
> >> Please. This has nothing to do with Christoph. (1) the driver seems to
> >> break every Linux coding style convention known to man and (2) adds a
> >> new ABI with bunch of ioctls() that apparently haven't been reviewed
> >> properly. That's just not acceptable for mainline kernel!
>
> > I completely agree, these things should be corrected and if the the
> > author is being totally unresponsive to Christoph's review that's even
> > worse.
>
> Um, the maintainer replied yesterday morning[1] that libertas-2.6.git
> has already been updated for these requests, will be updated some more,
> and overall was responsive to the entire list of Christoph requests.
>
> I'm mainly concerned with removing the unnecessary ioctls before 2.6.22
> release, since that affects userspace. The vast majority of other stuff
> is cosmetic, which is being worked on, but lower priority in my book.
I'll audit the list of ioctls and remove ones that may be objectionable,
and we'll go back through them after 2.6.22 and add back in ones that
are actually required. Keep the API/ABI small and expand if necessary.
What's the timeframe required here? Linville said a few days at the
most.
Dan
Dan Williams wrote:
> I'll audit the list of ioctls and remove ones that may be objectionable,
> and we'll go back through them after 2.6.22 and add back in ones that
> are actually required. Keep the API/ABI small and expand if necessary.
> What's the timeframe required here? Linville said a few days at the
> most.
Ideally, before 2.6.22-rc1. No set date, but generally it's a week or
two after merge window opens.
But even if you miss -rc1, we MUST get in the ioctl removal before
2.6.22 release. This is certainly exception to the "nothing but bug
fixes" rule -- or perhaps it is following the rule, if you consider the
ioctls' existence a bug :)
Getting the CodingStyle fixes in before 2.6.22-rc1 would be nice, but,
as I noted, lower priority than serious stuff like ioctl consideration.
Jeff
Jeff Garzik wrote:
> Nick Piggin wrote:
>
>> Two things on top of a lot of people's pet peeves list are lack of
>> good review bandwidth, and poor driver code! So it is sad this was
>> merged without Christoph's comments being addressed. "it works for
>> me, we can fix it later" is probably a big reason for quality
>> problems of some parts of the kernel.
>>
>> As for Christoph's idea of perfection... it usually isn't a bad
>> thing. And he is quite reasonable if you explain your good reason
>> to disagree or do something differently. The attitude of ignoring
>> comments can be really demotivating for a reviewer.
>
>
> I guess it's a good thing that the maintainer was not ignoring the
> review comments, then...
My rant was not directed at the driver author...
--
SUSE Labs, Novell Inc.
On Tue, May 08, 2007 at 06:40:54PM -0400, Jeff Garzik wrote:
> Dan Williams wrote:
> >I'll audit the list of ioctls and remove ones that may be objectionable,
> >and we'll go back through them after 2.6.22 and add back in ones that
> >are actually required. Keep the API/ABI small and expand if necessary.
> >What's the timeframe required here? Linville said a few days at the
> >most.
>
> Ideally, before 2.6.22-rc1. No set date, but generally it's a week or
> two after merge window opens.
>
> But even if you miss -rc1, we MUST get in the ioctl removal before
> 2.6.22 release. This is certainly exception to the "nothing but bug
> fixes" rule -- or perhaps it is following the rule, if you consider the
> ioctls' existence a bug :)
>
> Getting the CodingStyle fixes in before 2.6.22-rc1 would be nice, but,
> as I noted, lower priority than serious stuff like ioctl consideration.
There is also a bunch of updates pending. I'm sending them over this
week.
Dan: I'll be sending everything thats currently in our tree but not
mainline.
On Tue, 2007-05-08 at 20:41 -0300, Marcelo Tosatti wrote:
> On Tue, May 08, 2007 at 06:40:54PM -0400, Jeff Garzik wrote:
> > Dan Williams wrote:
> > >I'll audit the list of ioctls and remove ones that may be objectionable,
> > >and we'll go back through them after 2.6.22 and add back in ones that
> > >are actually required. Keep the API/ABI small and expand if necessary.
> > >What's the timeframe required here? Linville said a few days at the
> > >most.
> >
> > Ideally, before 2.6.22-rc1. No set date, but generally it's a week or
> > two after merge window opens.
> >
> > But even if you miss -rc1, we MUST get in the ioctl removal before
> > 2.6.22 release. This is certainly exception to the "nothing but bug
> > fixes" rule -- or perhaps it is following the rule, if you consider the
> > ioctls' existence a bug :)
> >
> > Getting the CodingStyle fixes in before 2.6.22-rc1 would be nice, but,
> > as I noted, lower priority than serious stuff like ioctl consideration.
>
> There is also a bunch of updates pending. I'm sending them over this
> week.
>
> Dan: I'll be sending everything thats currently in our tree but not
> mainline.
I'm going through the ioctls as we speak... what else was pending?
Louis has a few on libertas-dev list. We also need to pull wireless-2.6
into libertas before we send linville a pull request, I think.
Dan
On Tue, 08 May 2007 21:27:00 -0400 Dan Williams wrote:
> On Tue, 2007-05-08 at 20:41 -0300, Marcelo Tosatti wrote:
> > On Tue, May 08, 2007 at 06:40:54PM -0400, Jeff Garzik wrote:
> > > Dan Williams wrote:
> > > >I'll audit the list of ioctls and remove ones that may be objectionable,
> > > >and we'll go back through them after 2.6.22 and add back in ones that
> > > >are actually required. Keep the API/ABI small and expand if necessary.
> > > >What's the timeframe required here? Linville said a few days at the
> > > >most.
> > >
> > > Ideally, before 2.6.22-rc1. No set date, but generally it's a week or
> > > two after merge window opens.
> > >
> > > But even if you miss -rc1, we MUST get in the ioctl removal before
> > > 2.6.22 release. This is certainly exception to the "nothing but bug
> > > fixes" rule -- or perhaps it is following the rule, if you consider the
> > > ioctls' existence a bug :)
> > >
> > > Getting the CodingStyle fixes in before 2.6.22-rc1 would be nice, but,
> > > as I noted, lower priority than serious stuff like ioctl consideration.
> >
> > There is also a bunch of updates pending. I'm sending them over this
> > week.
> >
> > Dan: I'll be sending everything thats currently in our tree but not
> > mainline.
>
> I'm going through the ioctls as we speak... what else was pending?
All of the printk format warnings & cast warnings from 2.6.21-mm2 ??
drivers/net/wireless/libertas/rx.c: In function 'libertas_process_rxed_packet':
drivers/net/wireless/libertas/rx.c:213: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
drivers/net/wireless/libertas/rx.c:213: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'
drivers/net/wireless/libertas/rx.c: In function 'process_rxed_802_11_packet':
drivers/net/wireless/libertas/rx.c:367: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
drivers/net/wireless/libertas/rx.c:367: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'
drivers/net/wireless/libertas/tx.c: In function 'SendSinglePacket':
drivers/net/wireless/libertas/tx.c:81: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
drivers/net/wireless/libertas/cmd.c: In function 'libertas_queue_cmd':
drivers/net/wireless/libertas/cmd.c:950: warning: cast from pointer to integer of different size
drivers/net/wireless/libertas/cmd.c: In function 'DownloadcommandToStation':
drivers/net/wireless/libertas/cmd.c:979: warning: cast from pointer to integer of different size
drivers/net/wireless/libertas/cmd.c:979: warning: cast from pointer to integer of different size
drivers/net/wireless/libertas/cmd.c: In function 'libertas_prepare_and_send_command':
drivers/net/wireless/libertas/cmd.c:1177: warning: cast from pointer to integer of different size
drivers/net/wireless/libertas/scan.c: In function 'InterpretBSSDescriptionWithIE':
drivers/net/wireless/libertas/scan.c:1118: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
drivers/net/wireless/libertas/scan.c: In function 'libertas_get_scan':
drivers/net/wireless/libertas/scan.c:1586: warning: format '%d' expects type 'int', but argument 5 has type 'long unsigned int'
drivers/net/wireless/libertas/join.c: In function 'libertas_cmd_80211_ad_hoc_join':
drivers/net/wireless/libertas/join.c:789: warning: cast from pointer to integer of different size
drivers/net/wireless/libertas/ioctl.c: In function 'wlan_set_linkmode_ioctl':
drivers/net/wireless/libertas/ioctl.c:696: warning: cast from pointer to integer of different size
drivers/net/wireless/libertas/ioctl.c: In function 'wlan_set_radiomode_ioctl':
drivers/net/wireless/libertas/ioctl.c:728: warning: cast from pointer to integer of different size
drivers/net/wireless/libertas/ioctl.c: In function 'wlan_set_debugmode_ioctl':
drivers/net/wireless/libertas/ioctl.c:757: warning: cast from pointer to integer of different size
drivers/net/wireless/libertas/ioctl.c: In function 'wlan_fwt_cleanup_ioctl':
drivers/net/wireless/libertas/ioctl.c:1779: warning: cast to pointer from integer of different size
drivers/net/wireless/libertas/ioctl.c: In function 'wlan_fwt_time_ioctl':
drivers/net/wireless/libertas/ioctl.c:1810: warning: cast to pointer from integer of different size
drivers/net/wireless/libertas/ioctl.c: In function 'wlan_mesh_get_ttl_ioctl':
drivers/net/wireless/libertas/ioctl.c:1839: warning: cast to pointer from integer of different size
drivers/net/wireless/libertas/ioctl.c: In function 'libertas_do_ioctl':
drivers/net/wireless/libertas/ioctl.c:1947: warning: cast from pointer to integer of different size
drivers/net/wireless/libertas/ioctl.c:2025: warning: cast from pointer to integer of different size
drivers/net/wireless/libertas/ioctl.c:2171: warning: cast from pointer to integer of different size
drivers/net/wireless/libertas/ioctl.c:2188: warning: cast to pointer from integer of different size
drivers/net/wireless/libertas/ioctl.c:2192: warning: cast to pointer from integer of different size
drivers/net/wireless/libertas/ioctl.c:2196: warning: cast to pointer from integer of different size
drivers/net/wireless/libertas/debugfs.c: In function 'libertas_parse_ssid':
drivers/net/wireless/libertas/debugfs.c:279: warning: comparison of distinct pointer types lacks a cast
drivers/net/wireless/libertas/debugfs.c: In function 'wlan_debugfs_read':
drivers/net/wireless/libertas/debugfs.c:1823: warning: cast to pointer from integer of different size
drivers/net/wireless/libertas/debugfs.c:1825: warning: cast to pointer from integer of different size
drivers/net/wireless/libertas/debugfs.c:1827: warning: cast to pointer from integer of different size
drivers/net/wireless/libertas/debugfs.c: In function 'wlan_debugfs_write':
drivers/net/wireless/libertas/debugfs.c:1884: warning: cast to pointer from integer of different size
drivers/net/wireless/libertas/debugfs.c:1886: warning: cast to pointer from integer of different size
drivers/net/wireless/libertas/debugfs.c:1888: warning: cast to pointer from integer of different size
drivers/net/wireless/libertas/debugfs.c: At top level:
drivers/net/wireless/libertas/debugfs.c:1900: warning: initialization from incompatible pointer type
drivers/net/wireless/libertas/debugfs.c: In function 'libertas_debug_init':
drivers/net/wireless/libertas/debugfs.c:1919: warning: cast from pointer to integer of different size
drivers/net/wireless/libertas/if_usb.c: In function '__if_usb_submit_rx_urb':
drivers/net/wireless/libertas/if_usb.c:393: warning: passing argument 4 of 'usb_fill_bulk_urb' makes pointer from integer without a cast
> Louis has a few on libertas-dev list. We also need to pull wireless-2.6
> into libertas before we send linville a pull request, I think.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
On Wed, 2007-05-09 at 14:25 -0700, Randy Dunlap wrote:
> On Tue, 08 May 2007 21:27:00 -0400 Dan Williams wrote:
>
> > On Tue, 2007-05-08 at 20:41 -0300, Marcelo Tosatti wrote:
> > > On Tue, May 08, 2007 at 06:40:54PM -0400, Jeff Garzik wrote:
> > > > Dan Williams wrote:
> > > > >I'll audit the list of ioctls and remove ones that may be objectionable,
> > > > >and we'll go back through them after 2.6.22 and add back in ones that
> > > > >are actually required. Keep the API/ABI small and expand if necessary.
> > > > >What's the timeframe required here? Linville said a few days at the
> > > > >most.
> > > >
> > > > Ideally, before 2.6.22-rc1. No set date, but generally it's a week or
> > > > two after merge window opens.
> > > >
> > > > But even if you miss -rc1, we MUST get in the ioctl removal before
> > > > 2.6.22 release. This is certainly exception to the "nothing but bug
> > > > fixes" rule -- or perhaps it is following the rule, if you consider the
> > > > ioctls' existence a bug :)
> > > >
> > > > Getting the CodingStyle fixes in before 2.6.22-rc1 would be nice, but,
> > > > as I noted, lower priority than serious stuff like ioctl consideration.
> > >
> > > There is also a bunch of updates pending. I'm sending them over this
> > > week.
> > >
> > > Dan: I'll be sending everything thats currently in our tree but not
> > > mainline.
> >
> > I'm going through the ioctls as we speak... what else was pending?
>
> All of the printk format warnings & cast warnings from 2.6.21-mm2 ??
I can fix those up; but setting KBUILD_VERBOSE=1 and recompiling doesn't
show any of them in current libertas-2.6; -Wall is definitely defined.
Is there another way to enable something give yet more verbose debug
output?
Thanks,
Dan
>
> drivers/net/wireless/libertas/rx.c: In function 'libertas_process_rxed_packet':
> drivers/net/wireless/libertas/rx.c:213: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
> drivers/net/wireless/libertas/rx.c:213: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'
> drivers/net/wireless/libertas/rx.c: In function 'process_rxed_802_11_packet':
> drivers/net/wireless/libertas/rx.c:367: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
> drivers/net/wireless/libertas/rx.c:367: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'
> drivers/net/wireless/libertas/tx.c: In function 'SendSinglePacket':
> drivers/net/wireless/libertas/tx.c:81: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
> drivers/net/wireless/libertas/cmd.c: In function 'libertas_queue_cmd':
> drivers/net/wireless/libertas/cmd.c:950: warning: cast from pointer to integer of different size
> drivers/net/wireless/libertas/cmd.c: In function 'DownloadcommandToStation':
> drivers/net/wireless/libertas/cmd.c:979: warning: cast from pointer to integer of different size
> drivers/net/wireless/libertas/cmd.c:979: warning: cast from pointer to integer of different size
> drivers/net/wireless/libertas/cmd.c: In function 'libertas_prepare_and_send_command':
> drivers/net/wireless/libertas/cmd.c:1177: warning: cast from pointer to integer of different size
> drivers/net/wireless/libertas/scan.c: In function 'InterpretBSSDescriptionWithIE':
> drivers/net/wireless/libertas/scan.c:1118: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
> drivers/net/wireless/libertas/scan.c: In function 'libertas_get_scan':
> drivers/net/wireless/libertas/scan.c:1586: warning: format '%d' expects type 'int', but argument 5 has type 'long unsigned int'
> drivers/net/wireless/libertas/join.c: In function 'libertas_cmd_80211_ad_hoc_join':
> drivers/net/wireless/libertas/join.c:789: warning: cast from pointer to integer of different size
> drivers/net/wireless/libertas/ioctl.c: In function 'wlan_set_linkmode_ioctl':
> drivers/net/wireless/libertas/ioctl.c:696: warning: cast from pointer to integer of different size
> drivers/net/wireless/libertas/ioctl.c: In function 'wlan_set_radiomode_ioctl':
> drivers/net/wireless/libertas/ioctl.c:728: warning: cast from pointer to integer of different size
> drivers/net/wireless/libertas/ioctl.c: In function 'wlan_set_debugmode_ioctl':
> drivers/net/wireless/libertas/ioctl.c:757: warning: cast from pointer to integer of different size
> drivers/net/wireless/libertas/ioctl.c: In function 'wlan_fwt_cleanup_ioctl':
> drivers/net/wireless/libertas/ioctl.c:1779: warning: cast to pointer from integer of different size
> drivers/net/wireless/libertas/ioctl.c: In function 'wlan_fwt_time_ioctl':
> drivers/net/wireless/libertas/ioctl.c:1810: warning: cast to pointer from integer of different size
> drivers/net/wireless/libertas/ioctl.c: In function 'wlan_mesh_get_ttl_ioctl':
> drivers/net/wireless/libertas/ioctl.c:1839: warning: cast to pointer from integer of different size
> drivers/net/wireless/libertas/ioctl.c: In function 'libertas_do_ioctl':
> drivers/net/wireless/libertas/ioctl.c:1947: warning: cast from pointer to integer of different size
> drivers/net/wireless/libertas/ioctl.c:2025: warning: cast from pointer to integer of different size
> drivers/net/wireless/libertas/ioctl.c:2171: warning: cast from pointer to integer of different size
> drivers/net/wireless/libertas/ioctl.c:2188: warning: cast to pointer from integer of different size
> drivers/net/wireless/libertas/ioctl.c:2192: warning: cast to pointer from integer of different size
> drivers/net/wireless/libertas/ioctl.c:2196: warning: cast to pointer from integer of different size
> drivers/net/wireless/libertas/debugfs.c: In function 'libertas_parse_ssid':
> drivers/net/wireless/libertas/debugfs.c:279: warning: comparison of distinct pointer types lacks a cast
> drivers/net/wireless/libertas/debugfs.c: In function 'wlan_debugfs_read':
> drivers/net/wireless/libertas/debugfs.c:1823: warning: cast to pointer from integer of different size
> drivers/net/wireless/libertas/debugfs.c:1825: warning: cast to pointer from integer of different size
> drivers/net/wireless/libertas/debugfs.c:1827: warning: cast to pointer from integer of different size
> drivers/net/wireless/libertas/debugfs.c: In function 'wlan_debugfs_write':
> drivers/net/wireless/libertas/debugfs.c:1884: warning: cast to pointer from integer of different size
> drivers/net/wireless/libertas/debugfs.c:1886: warning: cast to pointer from integer of different size
> drivers/net/wireless/libertas/debugfs.c:1888: warning: cast to pointer from integer of different size
> drivers/net/wireless/libertas/debugfs.c: At top level:
> drivers/net/wireless/libertas/debugfs.c:1900: warning: initialization from incompatible pointer type
> drivers/net/wireless/libertas/debugfs.c: In function 'libertas_debug_init':
> drivers/net/wireless/libertas/debugfs.c:1919: warning: cast from pointer to integer of different size
> drivers/net/wireless/libertas/if_usb.c: In function '__if_usb_submit_rx_urb':
> drivers/net/wireless/libertas/if_usb.c:393: warning: passing argument 4 of 'usb_fill_bulk_urb' makes pointer from integer without a cast
>
>
>
>
> > Louis has a few on libertas-dev list. We also need to pull wireless-2.6
> > into libertas before we send linville a pull request, I think.
>
>
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
Dan Williams wrote:
> I can fix those up; but setting KBUILD_VERBOSE=1 and recompiling doesn't
> show any of them in current libertas-2.6; -Wall is definitely defined.
> Is there another way to enable something give yet more verbose debug
> output?
The copious libertas warnings are present in vanilla upstream
linux-2.6.git.
Just do "make allmodconfig && make -sj4".
Jeff
P.S. Make sure libertas is free of sparse warnings, as all drivers
should be. Read Documentation/sparse.txt.
Jeff
Dan Williams wrote:
> On Wed, 2007-05-09 at 14:25 -0700, Randy Dunlap wrote:
>> On Tue, 08 May 2007 21:27:00 -0400 Dan Williams wrote:
>>
>>> On Tue, 2007-05-08 at 20:41 -0300, Marcelo Tosatti wrote:
>>>> On Tue, May 08, 2007 at 06:40:54PM -0400, Jeff Garzik wrote:
>>>>> Dan Williams wrote:
>>>>>> I'll audit the list of ioctls and remove ones that may be objectionable,
>>>>>> and we'll go back through them after 2.6.22 and add back in ones that
>>>>>> are actually required. Keep the API/ABI small and expand if necessary.
>>>>>> What's the timeframe required here? Linville said a few days at the
>>>>>> most.
>>>>> Ideally, before 2.6.22-rc1. No set date, but generally it's a week or
>>>>> two after merge window opens.
>>>>>
>>>>> But even if you miss -rc1, we MUST get in the ioctl removal before
>>>>> 2.6.22 release. This is certainly exception to the "nothing but bug
>>>>> fixes" rule -- or perhaps it is following the rule, if you consider the
>>>>> ioctls' existence a bug :)
>>>>>
>>>>> Getting the CodingStyle fixes in before 2.6.22-rc1 would be nice, but,
>>>>> as I noted, lower priority than serious stuff like ioctl consideration.
>>>> There is also a bunch of updates pending. I'm sending them over this
>>>> week.
>>>>
>>>> Dan: I'll be sending everything thats currently in our tree but not
>>>> mainline.
>>> I'm going through the ioctls as we speak... what else was pending?
>> All of the printk format warnings & cast warnings from 2.6.21-mm2 ??
>
> I can fix those up; but setting KBUILD_VERBOSE=1 and recompiling doesn't
> show any of them in current libertas-2.6; -Wall is definitely defined.
> Is there another way to enable something give yet more verbose debug
> output?
No, I think that it's just host arch. and/or gcc dependent.
I built on x86_64. Can you do that?
> Thanks,
> Dan
>
>> drivers/net/wireless/libertas/rx.c: In function 'libertas_process_rxed_packet':
>> drivers/net/wireless/libertas/rx.c:213: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
>> drivers/net/wireless/libertas/rx.c:213: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'
>> drivers/net/wireless/libertas/rx.c: In function 'process_rxed_802_11_packet':
>> drivers/net/wireless/libertas/rx.c:367: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
>> drivers/net/wireless/libertas/rx.c:367: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'
>> drivers/net/wireless/libertas/tx.c: In function 'SendSinglePacket':
>> drivers/net/wireless/libertas/tx.c:81: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
>> drivers/net/wireless/libertas/cmd.c: In function 'libertas_queue_cmd':
>> drivers/net/wireless/libertas/cmd.c:950: warning: cast from pointer to integer of different size
>> drivers/net/wireless/libertas/cmd.c: In function 'DownloadcommandToStation':
>> drivers/net/wireless/libertas/cmd.c:979: warning: cast from pointer to integer of different size
>> drivers/net/wireless/libertas/cmd.c:979: warning: cast from pointer to integer of different size
>> drivers/net/wireless/libertas/cmd.c: In function 'libertas_prepare_and_send_command':
>> drivers/net/wireless/libertas/cmd.c:1177: warning: cast from pointer to integer of different size
>> drivers/net/wireless/libertas/scan.c: In function 'InterpretBSSDescriptionWithIE':
>> drivers/net/wireless/libertas/scan.c:1118: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
>> drivers/net/wireless/libertas/scan.c: In function 'libertas_get_scan':
>> drivers/net/wireless/libertas/scan.c:1586: warning: format '%d' expects type 'int', but argument 5 has type 'long unsigned int'
>> drivers/net/wireless/libertas/join.c: In function 'libertas_cmd_80211_ad_hoc_join':
>> drivers/net/wireless/libertas/join.c:789: warning: cast from pointer to integer of different size
>> drivers/net/wireless/libertas/ioctl.c: In function 'wlan_set_linkmode_ioctl':
>> drivers/net/wireless/libertas/ioctl.c:696: warning: cast from pointer to integer of different size
>> drivers/net/wireless/libertas/ioctl.c: In function 'wlan_set_radiomode_ioctl':
>> drivers/net/wireless/libertas/ioctl.c:728: warning: cast from pointer to integer of different size
>> drivers/net/wireless/libertas/ioctl.c: In function 'wlan_set_debugmode_ioctl':
>> drivers/net/wireless/libertas/ioctl.c:757: warning: cast from pointer to integer of different size
>> drivers/net/wireless/libertas/ioctl.c: In function 'wlan_fwt_cleanup_ioctl':
>> drivers/net/wireless/libertas/ioctl.c:1779: warning: cast to pointer from integer of different size
>> drivers/net/wireless/libertas/ioctl.c: In function 'wlan_fwt_time_ioctl':
>> drivers/net/wireless/libertas/ioctl.c:1810: warning: cast to pointer from integer of different size
>> drivers/net/wireless/libertas/ioctl.c: In function 'wlan_mesh_get_ttl_ioctl':
>> drivers/net/wireless/libertas/ioctl.c:1839: warning: cast to pointer from integer of different size
>> drivers/net/wireless/libertas/ioctl.c: In function 'libertas_do_ioctl':
>> drivers/net/wireless/libertas/ioctl.c:1947: warning: cast from pointer to integer of different size
>> drivers/net/wireless/libertas/ioctl.c:2025: warning: cast from pointer to integer of different size
>> drivers/net/wireless/libertas/ioctl.c:2171: warning: cast from pointer to integer of different size
>> drivers/net/wireless/libertas/ioctl.c:2188: warning: cast to pointer from integer of different size
>> drivers/net/wireless/libertas/ioctl.c:2192: warning: cast to pointer from integer of different size
>> drivers/net/wireless/libertas/ioctl.c:2196: warning: cast to pointer from integer of different size
>> drivers/net/wireless/libertas/debugfs.c: In function 'libertas_parse_ssid':
>> drivers/net/wireless/libertas/debugfs.c:279: warning: comparison of distinct pointer types lacks a cast
>> drivers/net/wireless/libertas/debugfs.c: In function 'wlan_debugfs_read':
>> drivers/net/wireless/libertas/debugfs.c:1823: warning: cast to pointer from integer of different size
>> drivers/net/wireless/libertas/debugfs.c:1825: warning: cast to pointer from integer of different size
>> drivers/net/wireless/libertas/debugfs.c:1827: warning: cast to pointer from integer of different size
>> drivers/net/wireless/libertas/debugfs.c: In function 'wlan_debugfs_write':
>> drivers/net/wireless/libertas/debugfs.c:1884: warning: cast to pointer from integer of different size
>> drivers/net/wireless/libertas/debugfs.c:1886: warning: cast to pointer from integer of different size
>> drivers/net/wireless/libertas/debugfs.c:1888: warning: cast to pointer from integer of different size
>> drivers/net/wireless/libertas/debugfs.c: At top level:
>> drivers/net/wireless/libertas/debugfs.c:1900: warning: initialization from incompatible pointer type
>> drivers/net/wireless/libertas/debugfs.c: In function 'libertas_debug_init':
>> drivers/net/wireless/libertas/debugfs.c:1919: warning: cast from pointer to integer of different size
>> drivers/net/wireless/libertas/if_usb.c: In function '__if_usb_submit_rx_urb':
>> drivers/net/wireless/libertas/if_usb.c:393: warning: passing argument 4 of 'usb_fill_bulk_urb' makes pointer from integer without a cast
>>
>>
>>
>>
>>> Louis has a few on libertas-dev list. We also need to pull wireless-2.6
>>> into libertas before we send linville a pull request, I think.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
On Wed, 2007-05-09 at 14:46 -0700, Randy Dunlap wrote:
> Dan Williams wrote:
> > On Wed, 2007-05-09 at 14:25 -0700, Randy Dunlap wrote:
> >> On Tue, 08 May 2007 21:27:00 -0400 Dan Williams wrote:
> >>
> >>> On Tue, 2007-05-08 at 20:41 -0300, Marcelo Tosatti wrote:
> >>>> On Tue, May 08, 2007 at 06:40:54PM -0400, Jeff Garzik wrote:
> >>>>> Dan Williams wrote:
> >>>>>> I'll audit the list of ioctls and remove ones that may be objectionable,
> >>>>>> and we'll go back through them after 2.6.22 and add back in ones that
> >>>>>> are actually required. Keep the API/ABI small and expand if necessary.
> >>>>>> What's the timeframe required here? Linville said a few days at the
> >>>>>> most.
> >>>>> Ideally, before 2.6.22-rc1. No set date, but generally it's a week or
> >>>>> two after merge window opens.
> >>>>>
> >>>>> But even if you miss -rc1, we MUST get in the ioctl removal before
> >>>>> 2.6.22 release. This is certainly exception to the "nothing but bug
> >>>>> fixes" rule -- or perhaps it is following the rule, if you consider the
> >>>>> ioctls' existence a bug :)
> >>>>>
> >>>>> Getting the CodingStyle fixes in before 2.6.22-rc1 would be nice, but,
> >>>>> as I noted, lower priority than serious stuff like ioctl consideration.
> >>>> There is also a bunch of updates pending. I'm sending them over this
> >>>> week.
> >>>>
> >>>> Dan: I'll be sending everything thats currently in our tree but not
> >>>> mainline.
> >>> I'm going through the ioctls as we speak... what else was pending?
> >> All of the printk format warnings & cast warnings from 2.6.21-mm2 ??
> >
> > I can fix those up; but setting KBUILD_VERBOSE=1 and recompiling doesn't
> > show any of them in current libertas-2.6; -Wall is definitely defined.
> > Is there another way to enable something give yet more verbose debug
> > output?
>
> No, I think that it's just host arch. and/or gcc dependent.
>
> I built on x86_64. Can you do that?
Trying to scrape one up. Should be doable by the end of today.
Dan
>
> > Thanks,
> > Dan
> >
> >> drivers/net/wireless/libertas/rx.c: In function 'libertas_process_rxed_packet':
> >> drivers/net/wireless/libertas/rx.c:213: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
> >> drivers/net/wireless/libertas/rx.c:213: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'
> >> drivers/net/wireless/libertas/rx.c: In function 'process_rxed_802_11_packet':
> >> drivers/net/wireless/libertas/rx.c:367: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
> >> drivers/net/wireless/libertas/rx.c:367: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'
> >> drivers/net/wireless/libertas/tx.c: In function 'SendSinglePacket':
> >> drivers/net/wireless/libertas/tx.c:81: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
> >> drivers/net/wireless/libertas/cmd.c: In function 'libertas_queue_cmd':
> >> drivers/net/wireless/libertas/cmd.c:950: warning: cast from pointer to integer of different size
> >> drivers/net/wireless/libertas/cmd.c: In function 'DownloadcommandToStation':
> >> drivers/net/wireless/libertas/cmd.c:979: warning: cast from pointer to integer of different size
> >> drivers/net/wireless/libertas/cmd.c:979: warning: cast from pointer to integer of different size
> >> drivers/net/wireless/libertas/cmd.c: In function 'libertas_prepare_and_send_command':
> >> drivers/net/wireless/libertas/cmd.c:1177: warning: cast from pointer to integer of different size
> >> drivers/net/wireless/libertas/scan.c: In function 'InterpretBSSDescriptionWithIE':
> >> drivers/net/wireless/libertas/scan.c:1118: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
> >> drivers/net/wireless/libertas/scan.c: In function 'libertas_get_scan':
> >> drivers/net/wireless/libertas/scan.c:1586: warning: format '%d' expects type 'int', but argument 5 has type 'long unsigned int'
> >> drivers/net/wireless/libertas/join.c: In function 'libertas_cmd_80211_ad_hoc_join':
> >> drivers/net/wireless/libertas/join.c:789: warning: cast from pointer to integer of different size
> >> drivers/net/wireless/libertas/ioctl.c: In function 'wlan_set_linkmode_ioctl':
> >> drivers/net/wireless/libertas/ioctl.c:696: warning: cast from pointer to integer of different size
> >> drivers/net/wireless/libertas/ioctl.c: In function 'wlan_set_radiomode_ioctl':
> >> drivers/net/wireless/libertas/ioctl.c:728: warning: cast from pointer to integer of different size
> >> drivers/net/wireless/libertas/ioctl.c: In function 'wlan_set_debugmode_ioctl':
> >> drivers/net/wireless/libertas/ioctl.c:757: warning: cast from pointer to integer of different size
> >> drivers/net/wireless/libertas/ioctl.c: In function 'wlan_fwt_cleanup_ioctl':
> >> drivers/net/wireless/libertas/ioctl.c:1779: warning: cast to pointer from integer of different size
> >> drivers/net/wireless/libertas/ioctl.c: In function 'wlan_fwt_time_ioctl':
> >> drivers/net/wireless/libertas/ioctl.c:1810: warning: cast to pointer from integer of different size
> >> drivers/net/wireless/libertas/ioctl.c: In function 'wlan_mesh_get_ttl_ioctl':
> >> drivers/net/wireless/libertas/ioctl.c:1839: warning: cast to pointer from integer of different size
> >> drivers/net/wireless/libertas/ioctl.c: In function 'libertas_do_ioctl':
> >> drivers/net/wireless/libertas/ioctl.c:1947: warning: cast from pointer to integer of different size
> >> drivers/net/wireless/libertas/ioctl.c:2025: warning: cast from pointer to integer of different size
> >> drivers/net/wireless/libertas/ioctl.c:2171: warning: cast from pointer to integer of different size
> >> drivers/net/wireless/libertas/ioctl.c:2188: warning: cast to pointer from integer of different size
> >> drivers/net/wireless/libertas/ioctl.c:2192: warning: cast to pointer from integer of different size
> >> drivers/net/wireless/libertas/ioctl.c:2196: warning: cast to pointer from integer of different size
> >> drivers/net/wireless/libertas/debugfs.c: In function 'libertas_parse_ssid':
> >> drivers/net/wireless/libertas/debugfs.c:279: warning: comparison of distinct pointer types lacks a cast
> >> drivers/net/wireless/libertas/debugfs.c: In function 'wlan_debugfs_read':
> >> drivers/net/wireless/libertas/debugfs.c:1823: warning: cast to pointer from integer of different size
> >> drivers/net/wireless/libertas/debugfs.c:1825: warning: cast to pointer from integer of different size
> >> drivers/net/wireless/libertas/debugfs.c:1827: warning: cast to pointer from integer of different size
> >> drivers/net/wireless/libertas/debugfs.c: In function 'wlan_debugfs_write':
> >> drivers/net/wireless/libertas/debugfs.c:1884: warning: cast to pointer from integer of different size
> >> drivers/net/wireless/libertas/debugfs.c:1886: warning: cast to pointer from integer of different size
> >> drivers/net/wireless/libertas/debugfs.c:1888: warning: cast to pointer from integer of different size
> >> drivers/net/wireless/libertas/debugfs.c: At top level:
> >> drivers/net/wireless/libertas/debugfs.c:1900: warning: initialization from incompatible pointer type
> >> drivers/net/wireless/libertas/debugfs.c: In function 'libertas_debug_init':
> >> drivers/net/wireless/libertas/debugfs.c:1919: warning: cast from pointer to integer of different size
> >> drivers/net/wireless/libertas/if_usb.c: In function '__if_usb_submit_rx_urb':
> >> drivers/net/wireless/libertas/if_usb.c:393: warning: passing argument 4 of 'usb_fill_bulk_urb' makes pointer from integer without a cast
> >>
> >>
> >>
> >>
> >>> Louis has a few on libertas-dev list. We also need to pull wireless-2.6
> >>> into libertas before we send linville a pull request, I think.
>
>
On Wed, 2007-05-09 at 17:41 -0400, Jeff Garzik wrote:
> Dan Williams wrote:
> > I can fix those up; but setting KBUILD_VERBOSE=1 and recompiling doesn't
> > show any of them in current libertas-2.6; -Wall is definitely defined.
> > Is there another way to enable something give yet more verbose debug
> > output?
>
>
> The copious libertas warnings are present in vanilla upstream
> linux-2.6.git.
>
> Just do "make allmodconfig && make -sj4".
>
> Jeff
>
>
> P.S. Make sure libertas is free of sparse warnings, as all drivers
> should be. Read Documentation/sparse.txt.
Sparse stuff fixed. Still getting working on 64-bit compiles.
Dan
> Jeff
>
>
>
On Thu, 2007-05-10 at 12:56 -0400, Dan Williams wrote:
> On Wed, 2007-05-09 at 14:46 -0700, Randy Dunlap wrote:
> > Dan Williams wrote:
> > > On Wed, 2007-05-09 at 14:25 -0700, Randy Dunlap wrote:
> > >> On Tue, 08 May 2007 21:27:00 -0400 Dan Williams wrote:
> > >>
> > >>> On Tue, 2007-05-08 at 20:41 -0300, Marcelo Tosatti wrote:
> > >>>> On Tue, May 08, 2007 at 06:40:54PM -0400, Jeff Garzik wrote:
> > >>>>> Dan Williams wrote:
> > >>>>>> I'll audit the list of ioctls and remove ones that may be objectionable,
> > >>>>>> and we'll go back through them after 2.6.22 and add back in ones that
> > >>>>>> are actually required. Keep the API/ABI small and expand if necessary.
> > >>>>>> What's the timeframe required here? Linville said a few days at the
> > >>>>>> most.
> > >>>>> Ideally, before 2.6.22-rc1. No set date, but generally it's a week or
> > >>>>> two after merge window opens.
> > >>>>>
> > >>>>> But even if you miss -rc1, we MUST get in the ioctl removal before
> > >>>>> 2.6.22 release. This is certainly exception to the "nothing but bug
> > >>>>> fixes" rule -- or perhaps it is following the rule, if you consider the
> > >>>>> ioctls' existence a bug :)
> > >>>>>
> > >>>>> Getting the CodingStyle fixes in before 2.6.22-rc1 would be nice, but,
> > >>>>> as I noted, lower priority than serious stuff like ioctl consideration.
> > >>>> There is also a bunch of updates pending. I'm sending them over this
> > >>>> week.
> > >>>>
> > >>>> Dan: I'll be sending everything thats currently in our tree but not
> > >>>> mainline.
> > >>> I'm going through the ioctls as we speak... what else was pending?
> > >> All of the printk format warnings & cast warnings from 2.6.21-mm2 ??
> > >
> > > I can fix those up; but setting KBUILD_VERBOSE=1 and recompiling doesn't
> > > show any of them in current libertas-2.6; -Wall is definitely defined.
> > > Is there another way to enable something give yet more verbose debug
> > > output?
> >
> > No, I think that it's just host arch. and/or gcc dependent.
> >
> > I built on x86_64. Can you do that?
>
> Trying to scrape one up. Should be doable by the end of today.
Done; working on getting the (19) patches to linville.
Dan
> Dan
>
> >
> > > Thanks,
> > > Dan
> > >
> > >> drivers/net/wireless/libertas/rx.c: In function 'libertas_process_rxed_packet':
> > >> drivers/net/wireless/libertas/rx.c:213: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
> > >> drivers/net/wireless/libertas/rx.c:213: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'
> > >> drivers/net/wireless/libertas/rx.c: In function 'process_rxed_802_11_packet':
> > >> drivers/net/wireless/libertas/rx.c:367: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
> > >> drivers/net/wireless/libertas/rx.c:367: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'
> > >> drivers/net/wireless/libertas/tx.c: In function 'SendSinglePacket':
> > >> drivers/net/wireless/libertas/tx.c:81: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
> > >> drivers/net/wireless/libertas/cmd.c: In function 'libertas_queue_cmd':
> > >> drivers/net/wireless/libertas/cmd.c:950: warning: cast from pointer to integer of different size
> > >> drivers/net/wireless/libertas/cmd.c: In function 'DownloadcommandToStation':
> > >> drivers/net/wireless/libertas/cmd.c:979: warning: cast from pointer to integer of different size
> > >> drivers/net/wireless/libertas/cmd.c:979: warning: cast from pointer to integer of different size
> > >> drivers/net/wireless/libertas/cmd.c: In function 'libertas_prepare_and_send_command':
> > >> drivers/net/wireless/libertas/cmd.c:1177: warning: cast from pointer to integer of different size
> > >> drivers/net/wireless/libertas/scan.c: In function 'InterpretBSSDescriptionWithIE':
> > >> drivers/net/wireless/libertas/scan.c:1118: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
> > >> drivers/net/wireless/libertas/scan.c: In function 'libertas_get_scan':
> > >> drivers/net/wireless/libertas/scan.c:1586: warning: format '%d' expects type 'int', but argument 5 has type 'long unsigned int'
> > >> drivers/net/wireless/libertas/join.c: In function 'libertas_cmd_80211_ad_hoc_join':
> > >> drivers/net/wireless/libertas/join.c:789: warning: cast from pointer to integer of different size
> > >> drivers/net/wireless/libertas/ioctl.c: In function 'wlan_set_linkmode_ioctl':
> > >> drivers/net/wireless/libertas/ioctl.c:696: warning: cast from pointer to integer of different size
> > >> drivers/net/wireless/libertas/ioctl.c: In function 'wlan_set_radiomode_ioctl':
> > >> drivers/net/wireless/libertas/ioctl.c:728: warning: cast from pointer to integer of different size
> > >> drivers/net/wireless/libertas/ioctl.c: In function 'wlan_set_debugmode_ioctl':
> > >> drivers/net/wireless/libertas/ioctl.c:757: warning: cast from pointer to integer of different size
> > >> drivers/net/wireless/libertas/ioctl.c: In function 'wlan_fwt_cleanup_ioctl':
> > >> drivers/net/wireless/libertas/ioctl.c:1779: warning: cast to pointer from integer of different size
> > >> drivers/net/wireless/libertas/ioctl.c: In function 'wlan_fwt_time_ioctl':
> > >> drivers/net/wireless/libertas/ioctl.c:1810: warning: cast to pointer from integer of different size
> > >> drivers/net/wireless/libertas/ioctl.c: In function 'wlan_mesh_get_ttl_ioctl':
> > >> drivers/net/wireless/libertas/ioctl.c:1839: warning: cast to pointer from integer of different size
> > >> drivers/net/wireless/libertas/ioctl.c: In function 'libertas_do_ioctl':
> > >> drivers/net/wireless/libertas/ioctl.c:1947: warning: cast from pointer to integer of different size
> > >> drivers/net/wireless/libertas/ioctl.c:2025: warning: cast from pointer to integer of different size
> > >> drivers/net/wireless/libertas/ioctl.c:2171: warning: cast from pointer to integer of different size
> > >> drivers/net/wireless/libertas/ioctl.c:2188: warning: cast to pointer from integer of different size
> > >> drivers/net/wireless/libertas/ioctl.c:2192: warning: cast to pointer from integer of different size
> > >> drivers/net/wireless/libertas/ioctl.c:2196: warning: cast to pointer from integer of different size
> > >> drivers/net/wireless/libertas/debugfs.c: In function 'libertas_parse_ssid':
> > >> drivers/net/wireless/libertas/debugfs.c:279: warning: comparison of distinct pointer types lacks a cast
> > >> drivers/net/wireless/libertas/debugfs.c: In function 'wlan_debugfs_read':
> > >> drivers/net/wireless/libertas/debugfs.c:1823: warning: cast to pointer from integer of different size
> > >> drivers/net/wireless/libertas/debugfs.c:1825: warning: cast to pointer from integer of different size
> > >> drivers/net/wireless/libertas/debugfs.c:1827: warning: cast to pointer from integer of different size
> > >> drivers/net/wireless/libertas/debugfs.c: In function 'wlan_debugfs_write':
> > >> drivers/net/wireless/libertas/debugfs.c:1884: warning: cast to pointer from integer of different size
> > >> drivers/net/wireless/libertas/debugfs.c:1886: warning: cast to pointer from integer of different size
> > >> drivers/net/wireless/libertas/debugfs.c:1888: warning: cast to pointer from integer of different size
> > >> drivers/net/wireless/libertas/debugfs.c: At top level:
> > >> drivers/net/wireless/libertas/debugfs.c:1900: warning: initialization from incompatible pointer type
> > >> drivers/net/wireless/libertas/debugfs.c: In function 'libertas_debug_init':
> > >> drivers/net/wireless/libertas/debugfs.c:1919: warning: cast from pointer to integer of different size
> > >> drivers/net/wireless/libertas/if_usb.c: In function '__if_usb_submit_rx_urb':
> > >> drivers/net/wireless/libertas/if_usb.c:393: warning: passing argument 4 of 'usb_fill_bulk_urb' makes pointer from integer without a cast
> > >>
> > >>
> > >>
> > >>
> > >>> Louis has a few on libertas-dev list. We also need to pull wireless-2.6
> > >>> into libertas before we send linville a pull request, I think.
> >
> >
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html