2007-05-10 07:23:01

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: include files: convert "include" subdirectory to UTF-8

On Wed, 9 May 2007, Linux Kernel Mailing List wrote:
> diff --git a/include/asm-m68k/atarihw.h b/include/asm-m68k/atarihw.h
> index f28acd0..6211363 100644
> --- a/include/asm-m68k/atarihw.h
> +++ b/include/asm-m68k/atarihw.h
> @@ -2,7 +2,7 @@
> ** linux/atarihw.h -- This header defines some macros and pointers for
> ** the various Atari custom hardware registers.
> **
> -** Copyright 1994 by Bj?rn Brauel
> +** Copyright 1994 by Bj”rn Brauel
> **
> ** 5/1/94 Roman Hodek:
> ** Added definitions for TT specific chips.
> diff --git a/include/asm-m68k/atariints.h b/include/asm-m68k/atariints.h
> index 0ed454f..ce6c445 100644
> --- a/include/asm-m68k/atariints.h
> +++ b/include/asm-m68k/atariints.h
> @@ -1,7 +1,7 @@
> /*
> ** atariints.h -- Atari Linux interrupt handling structs and prototypes
> **
> -** Copyright 1994 by Bj?rn Brauel
> +** Copyright 1994 by Bj”rn Brauel
> **
> ** 5/2/94 Roman Hodek:
> ** TT interrupt definitions added.

These two seem to have failed.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


2007-05-10 08:18:56

by Adrian Bunk

[permalink] [raw]
Subject: Re: include files: convert "include" subdirectory to UTF-8

On Thu, May 10, 2007 at 09:22:44AM +0200, Geert Uytterhoeven wrote:
> On Wed, 9 May 2007, Linux Kernel Mailing List wrote:
> > diff --git a/include/asm-m68k/atarihw.h b/include/asm-m68k/atarihw.h
> > index f28acd0..6211363 100644
> > --- a/include/asm-m68k/atarihw.h
> > +++ b/include/asm-m68k/atarihw.h
> > @@ -2,7 +2,7 @@
> > ** linux/atarihw.h -- This header defines some macros and pointers for
> > ** the various Atari custom hardware registers.
> > **
> > -** Copyright 1994 by Bj?rn Brauel
> > +** Copyright 1994 by Bj”rn Brauel
> > **
> > ** 5/1/94 Roman Hodek:
> > ** Added definitions for TT specific chips.
> > diff --git a/include/asm-m68k/atariints.h b/include/asm-m68k/atariints.h
> > index 0ed454f..ce6c445 100644
> > --- a/include/asm-m68k/atariints.h
> > +++ b/include/asm-m68k/atariints.h
> > @@ -1,7 +1,7 @@
> > /*
> > ** atariints.h -- Atari Linux interrupt handling structs and prototypes
> > **
> > -** Copyright 1994 by Bj?rn Brauel
> > +** Copyright 1994 by Bj”rn Brauel
> > **
> > ** 5/2/94 Roman Hodek:
> > ** TT interrupt definitions added.
>
> These two seem to have failed.

They changed from wrong and invalid UTF-8 to wrong and valid UTF-8.

I saw this when applying the patch, but I wasn't sure which character
would be correct in this name.

> Gr{oetje,eeting}s,
>
> Geert

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

2007-05-10 08:49:20

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: include files: convert "include" subdirectory to UTF-8

On Thu, 10 May 2007, Adrian Bunk wrote:
> On Thu, May 10, 2007 at 09:22:44AM +0200, Geert Uytterhoeven wrote:
> > On Wed, 9 May 2007, Linux Kernel Mailing List wrote:
> > > diff --git a/include/asm-m68k/atarihw.h b/include/asm-m68k/atarihw.h
> > > index f28acd0..6211363 100644
> > > --- a/include/asm-m68k/atarihw.h
> > > +++ b/include/asm-m68k/atarihw.h
> > > @@ -2,7 +2,7 @@
> > > ** linux/atarihw.h -- This header defines some macros and pointers for
> > > ** the various Atari custom hardware registers.
> > > **
> > > -** Copyright 1994 by Bj?rn Brauel
> > > +** Copyright 1994 by Bj”rn Brauel
> > > **
> > > ** 5/1/94 Roman Hodek:
> > > ** Added definitions for TT specific chips.
> > > diff --git a/include/asm-m68k/atariints.h b/include/asm-m68k/atariints.h
> > > index 0ed454f..ce6c445 100644
> > > --- a/include/asm-m68k/atariints.h
> > > +++ b/include/asm-m68k/atariints.h
> > > @@ -1,7 +1,7 @@
> > > /*
> > > ** atariints.h -- Atari Linux interrupt handling structs and prototypes
> > > **
> > > -** Copyright 1994 by Bj?rn Brauel
> > > +** Copyright 1994 by Bj”rn Brauel
> > > **
> > > ** 5/2/94 Roman Hodek:
> > > ** TT interrupt definitions added.
> >
> > These two seem to have failed.
>
> They changed from wrong and invalid UTF-8 to wrong and valid UTF-8.
>
> I saw this when applying the patch, but I wasn't sure which character
> would be correct in this name.

I checked a very old source tree and a few encodings. In IBM850 it's an
o-umlaut, which is what I expected in the first place.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2007-05-10 09:56:31

by Jan Engelhardt

[permalink] [raw]
Subject: Re: include files: convert "include" subdirectory to UTF-8


On May 10 2007 10:48, Geert Uytterhoeven wrote:
>> > > **
>> > > -** Copyright 1994 by Bj?rn Brauel
>> > > +** Copyright 1994 by Bj”rn Brauel
>> > > **
>> > > ** 5/2/94 Roman Hodek:
>> > > ** TT interrupt definitions added.
>> >
>> > These two seem to have failed.
>>
>> They changed from wrong and invalid UTF-8 to wrong and valid UTF-8.
>>
>> I saw this when applying the patch, but I wasn't sure which character
>> would be correct in this name.
>
>I checked a very old source tree and a few encodings. In IBM850 it's an
>o-umlaut, which is what I expected in the first place.

Make sure it does not accidentally map to a ø in some charsets :p


Jan
--