2007-05-12 20:10:12

by Lukas Hejtmanek

[permalink] [raw]
Subject: Reboot PATCH (ACPI related)

Hello,

why the attached patch is still not included in mainline kernel? It fixes boot
problems after suspend to RAM.

--
Luk?? Hejtm?nek


Attachments:
(No filename) (139.00 B)
reboot.patch (563.00 B)
Download all attachments

2007-05-13 06:44:35

by Andrew Morton

[permalink] [raw]
Subject: Re: Reboot PATCH (ACPI related)

On Sat, 12 May 2007 22:10:07 +0200 Lukas Hejtmanek <[email protected]> wrote:

> why the attached patch is still not included in mainline kernel? It fixes boot
> problems after suspend to RAM.
>
> --
> Lukáš Hejtmánek
>
>
> [reboot.patch text/x-diff (564B)]
> --- arch/i386/kernel/reboot.c.old 2006-06-18 03:49:35.000000000 +0200
> +++ arch/i386/kernel/reboot.c 2006-07-01 17:29:23.000000000 +0200
> @@ -31,6 +31,12 @@
> #ifdef CONFIG_SMP
> static int reboot_cpu = -1;
> #endif
> +#ifdef CONFIG_ACPI
> +extern u32 acpi_disable(void);
> +#else
> +static u32 acpi_disable(void){};
> +#endif
> +
> static int __init reboot_setup(char *str)
> {
> while(1) {
> @@ -322,6 +328,7 @@
>
> void machine_emergency_restart(void)
> {
> + acpi_disable();
> if (!reboot_thru_bios) {
> if (efi_enabled) {
> efi.reset_system(EFI_RESET_COLD, EFI_SUCCESS, 0, NULL);

We'd prefer to fix the problem, whatever it is, rather than just turning
APCI off.

Please ensure that a full bug report has been entered at bugzilla.kernel.org,
thanks.

2007-05-14 12:00:00

by Lukas Hejtmanek

[permalink] [raw]
Subject: Re: Reboot PATCH (ACPI related)

On Sat, May 12, 2007 at 11:44:13PM -0700, Andrew Morton wrote:
> We'd prefer to fix the problem, whatever it is, rather than just turning
> APCI off.
>
> Please ensure that a full bug report has been entered at bugzilla.kernel.org,
> thanks.

The patch resulted from the following bug report:
http://bugzilla.kernel.org/show_bug.cgi?id=6655

--
Luk?? Hejtm?nek