On Sun, May 13, 2007 at 11:27:31AM +0200, Jan Engelhardt wrote:
> On May 12 2007 20:20, Linus Torvalds wrote:
> >
> >Ok, the merge window has closed, and 2.6.22-rc1 is out there.
>
> I have hit a randconfig compile failure. .config attached.
>
> LD .tmp_vmlinux1
> drivers/built-in.o: In function `acpi_bus_generate_event':
> (.text+0x233f7): undefined reference to `event_is_open'
> drivers/built-in.o: In function `acpi_bus_get_power':
> (.text+0x236ad): undefined reference to `acpi_power_get_inferred_state'
> drivers/built-in.o: In function `acpi_bus_set_power':
> (.text+0x237c3): undefined reference to `acpi_power_transition'
> drivers/built-in.o: In function `acpi_bus_set_power':
> (.text+0x23835): undefined reference to `acpi_power_transition'
> drivers/built-in.o: In function `sony_pic_fanspeed_store':
> sony-laptop.c:(.text+0x91930): undefined reference to `ec_write'
> drivers/built-in.o: In function `sony_pic_fanspeed_show':
> sony-laptop.c:(.text+0x9195d): undefined reference to `ec_read'
> make: *** [.tmp_vmlinux1] Error 1
I actually can't reproduce it with your .config.
>From a clean tree, running make fires up the oldconfig which fixes the
many missing/garbled dependencies. In any case SONY_LAPTOP depends on
ACPI which always build EC statically if selected.
clues?
--
mattia
:wq!
On May 14 2007 10:55, Mattia Dongili wrote:
>On Sun, May 13, 2007 at 11:27:31AM +0200, Jan Engelhardt wrote:
>> On May 12 2007 20:20, Linus Torvalds wrote:
>> >
>> >Ok, the merge window has closed, and 2.6.22-rc1 is out there.
>>
>> I have hit a randconfig compile failure. .config attached.
>>
>> LD .tmp_vmlinux1
>> drivers/built-in.o: In function `acpi_bus_generate_event':
>> (.text+0x233f7): undefined reference to `event_is_open'
>> drivers/built-in.o: In function `acpi_bus_get_power':
>> (.text+0x236ad): undefined reference to `acpi_power_get_inferred_state'
>> drivers/built-in.o: In function `acpi_bus_set_power':
>> (.text+0x237c3): undefined reference to `acpi_power_transition'
>> drivers/built-in.o: In function `acpi_bus_set_power':
>> (.text+0x23835): undefined reference to `acpi_power_transition'
>> drivers/built-in.o: In function `sony_pic_fanspeed_store':
>> sony-laptop.c:(.text+0x91930): undefined reference to `ec_write'
>> drivers/built-in.o: In function `sony_pic_fanspeed_show':
>> sony-laptop.c:(.text+0x9195d): undefined reference to `ec_read'
>> make: *** [.tmp_vmlinux1] Error 1
>
>I actually can't reproduce it with your .config.
But I can. Did you try it on x86_64? From 2.6.22-rc1 [
commit 39403865d2e4590802553370a56c9ab93131e4ee in /linux-2.6.git] ?
bzip2 -cd randconfig-1.bz2 >.config
make -j8
HOSTLD scripts/kconfig/conf
scripts/kconfig/conf -s arch/x86_64/Kconfig
drivers/macintosh/Kconfig:116:warning: 'select' used by config symbol '
drivers/net/Kconfig:2283:warning: 'select' used by config symbol 'UCC_G
drivers/input/keyboard/Kconfig:170:warning: 'select' used by config sym
drivers/input/mouse/Kconfig:181:warning: 'select' used by config symbol
CHK include/linux/version.h
UPD include/linux/version.h
CHK include/linux/utsrelease.h
UPD include/linux/utsrelease.h
SYMLINK include/asm -> include/asm-x86_64
>>From a clean tree, running make fires up the oldconfig which fixes the
>many missing/garbled dependencies. In any case SONY_LAPTOP depends on
>ACPI which always build EC statically if selected.
I really presume it is something on x86_64, because doing
gzip -cd /proc/config.gz
make
on i386 seemed to compile fine - including the sony modules.
Jan
--
On Mon, 14 May 2007 07:49:31 +0200 (MEST) Jan Engelhardt wrote:
>
> On May 14 2007 10:55, Mattia Dongili wrote:
> >On Sun, May 13, 2007 at 11:27:31AM +0200, Jan Engelhardt wrote:
> >> On May 12 2007 20:20, Linus Torvalds wrote:
> >> >
> >> >Ok, the merge window has closed, and 2.6.22-rc1 is out there.
> >>
> >> I have hit a randconfig compile failure. .config attached.
> >>
> >> LD .tmp_vmlinux1
> >> drivers/built-in.o: In function `acpi_bus_generate_event':
> >> (.text+0x233f7): undefined reference to `event_is_open'
> >> drivers/built-in.o: In function `acpi_bus_get_power':
> >> (.text+0x236ad): undefined reference to `acpi_power_get_inferred_state'
> >> drivers/built-in.o: In function `acpi_bus_set_power':
> >> (.text+0x237c3): undefined reference to `acpi_power_transition'
> >> drivers/built-in.o: In function `acpi_bus_set_power':
> >> (.text+0x23835): undefined reference to `acpi_power_transition'
> >> drivers/built-in.o: In function `sony_pic_fanspeed_store':
> >> sony-laptop.c:(.text+0x91930): undefined reference to `ec_write'
> >> drivers/built-in.o: In function `sony_pic_fanspeed_show':
> >> sony-laptop.c:(.text+0x9195d): undefined reference to `ec_read'
> >> make: *** [.tmp_vmlinux1] Error 1
> >
> >I actually can't reproduce it with your .config.
>
> But I can. Did you try it on x86_64? From 2.6.22-rc1 [
> commit 39403865d2e4590802553370a56c9ab93131e4ee in /linux-2.6.git] ?
>
> bzip2 -cd randconfig-1.bz2 >.config
> make -j8
Yes, build easily fails for me also.
> HOSTLD scripts/kconfig/conf
> scripts/kconfig/conf -s arch/x86_64/Kconfig
> drivers/macintosh/Kconfig:116:warning: 'select' used by config symbol '
> drivers/net/Kconfig:2283:warning: 'select' used by config symbol 'UCC_G
> drivers/input/keyboard/Kconfig:170:warning: 'select' used by config sym
> drivers/input/mouse/Kconfig:181:warning: 'select' used by config symbol
> CHK include/linux/version.h
> UPD include/linux/version.h
> CHK include/linux/utsrelease.h
> UPD include/linux/utsrelease.h
> SYMLINK include/asm -> include/asm-x86_64
>
>
> >>From a clean tree, running make fires up the oldconfig which fixes the
> >many missing/garbled dependencies. In any case SONY_LAPTOP depends on
> >ACPI which always build EC statically if selected.
>
> I really presume it is something on x86_64, because doing
>
> gzip -cd /proc/config.gz
> make
>
> on i386 seemed to compile fine - including the sony modules.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
On Mon, May 14, 2007 at 10:45:46AM -0700, Randy Dunlap wrote:
> On Mon, 14 May 2007 07:49:31 +0200 (MEST) Jan Engelhardt wrote:
>
> >
> > On May 14 2007 10:55, Mattia Dongili wrote:
> > >On Sun, May 13, 2007 at 11:27:31AM +0200, Jan Engelhardt wrote:
> > >> On May 12 2007 20:20, Linus Torvalds wrote:
> > >> >
> > >> >Ok, the merge window has closed, and 2.6.22-rc1 is out there.
> > >>
> > >> I have hit a randconfig compile failure. .config attached.
> > >>
> > >> LD .tmp_vmlinux1
> > >> drivers/built-in.o: In function `acpi_bus_generate_event':
> > >> (.text+0x233f7): undefined reference to `event_is_open'
> > >> drivers/built-in.o: In function `acpi_bus_get_power':
> > >> (.text+0x236ad): undefined reference to `acpi_power_get_inferred_state'
> > >> drivers/built-in.o: In function `acpi_bus_set_power':
> > >> (.text+0x237c3): undefined reference to `acpi_power_transition'
> > >> drivers/built-in.o: In function `acpi_bus_set_power':
> > >> (.text+0x23835): undefined reference to `acpi_power_transition'
> > >> drivers/built-in.o: In function `sony_pic_fanspeed_store':
> > >> sony-laptop.c:(.text+0x91930): undefined reference to `ec_write'
> > >> drivers/built-in.o: In function `sony_pic_fanspeed_show':
> > >> sony-laptop.c:(.text+0x9195d): undefined reference to `ec_read'
> > >> make: *** [.tmp_vmlinux1] Error 1
> > >
> > >I actually can't reproduce it with your .config.
> >
> > But I can. Did you try it on x86_64? From 2.6.22-rc1 [
> > commit 39403865d2e4590802553370a56c9ab93131e4ee in /linux-2.6.git] ?
> >
> > bzip2 -cd randconfig-1.bz2 >.config
> > make -j8
>
> Yes, build easily fails for me also.
ok, as far as sony-laptop is concerned a dependency on ACPI_EC suffices
to fix the link failure, but I guess that would just hide the real
issue.
IOW: why does ACPI_EC, ACPI_SYSTEM and ACPI_POWER are not set when the
ACPI symbol is?
Given the drivers/acpi/Kconfig portion
if ACPI
...
config ACPI_EC
bool
default y
help
...
config ACPI_POWER
bool
default y
config ACPI_SYSTEM
bool
default y
help
...
...
endif
I'd expect the 3 symbols to be all set when CONFIG_ACPI=y.
What am I overseeing?
--
mattia
:wq!
On Wed, 16 May 2007 00:42:08 +0900 Mattia Dongili wrote:
> On Mon, May 14, 2007 at 10:45:46AM -0700, Randy Dunlap wrote:
> > On Mon, 14 May 2007 07:49:31 +0200 (MEST) Jan Engelhardt wrote:
> >
> > >
> > > On May 14 2007 10:55, Mattia Dongili wrote:
> > > >On Sun, May 13, 2007 at 11:27:31AM +0200, Jan Engelhardt wrote:
> > > >> On May 12 2007 20:20, Linus Torvalds wrote:
> > > >> >
> > > >> >Ok, the merge window has closed, and 2.6.22-rc1 is out there.
> > > >>
> > > >> I have hit a randconfig compile failure. .config attached.
> > > >>
> > > >> LD .tmp_vmlinux1
> > > >> drivers/built-in.o: In function `acpi_bus_generate_event':
> > > >> (.text+0x233f7): undefined reference to `event_is_open'
> > > >> drivers/built-in.o: In function `acpi_bus_get_power':
> > > >> (.text+0x236ad): undefined reference to `acpi_power_get_inferred_state'
> > > >> drivers/built-in.o: In function `acpi_bus_set_power':
> > > >> (.text+0x237c3): undefined reference to `acpi_power_transition'
> > > >> drivers/built-in.o: In function `acpi_bus_set_power':
> > > >> (.text+0x23835): undefined reference to `acpi_power_transition'
> > > >> drivers/built-in.o: In function `sony_pic_fanspeed_store':
> > > >> sony-laptop.c:(.text+0x91930): undefined reference to `ec_write'
> > > >> drivers/built-in.o: In function `sony_pic_fanspeed_show':
> > > >> sony-laptop.c:(.text+0x9195d): undefined reference to `ec_read'
> > > >> make: *** [.tmp_vmlinux1] Error 1
> > > >
> > > >I actually can't reproduce it with your .config.
> > >
> > > But I can. Did you try it on x86_64? From 2.6.22-rc1 [
> > > commit 39403865d2e4590802553370a56c9ab93131e4ee in /linux-2.6.git] ?
> > >
> > > bzip2 -cd randconfig-1.bz2 >.config
> > > make -j8
> >
> > Yes, build easily fails for me also.
>
> ok, as far as sony-laptop is concerned a dependency on ACPI_EC suffices
> to fix the link failure, but I guess that would just hide the real
> issue.
> IOW: why does ACPI_EC, ACPI_SYSTEM and ACPI_POWER are not set when the
> ACPI symbol is?
>
> Given the drivers/acpi/Kconfig portion
>
> if ACPI
> ...
> config ACPI_EC
> bool
> default y
> help
> ...
>
> config ACPI_POWER
> bool
> default y
>
> config ACPI_SYSTEM
> bool
> default y
> help
> ...
> ...
> endif
>
> I'd expect the 3 symbols to be all set when CONFIG_ACPI=y.
> What am I overseeing?
I think that this is just 'make randconfig' throwing a curve ball.
ACPI depends on PM, but PM=n. In my experience, randconfig is a
good tool for testing oddball configs, but the results are not
always something that is fixable or needs to be fixed.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
On Tue, May 15, 2007 at 10:46:21AM -0700, Randy Dunlap wrote:
> On Wed, 16 May 2007 00:42:08 +0900 Mattia Dongili wrote:
...
> > Given the drivers/acpi/Kconfig portion
> >
> > if ACPI
> > ...
> > config ACPI_EC
> > bool
> > default y
> > help
> > ...
> >
> > config ACPI_POWER
> > bool
> > default y
> >
> > config ACPI_SYSTEM
> > bool
> > default y
> > help
> > ...
> > ...
> > endif
> >
> > I'd expect the 3 symbols to be all set when CONFIG_ACPI=y.
> > What am I overseeing?
>
> I think that this is just 'make randconfig' throwing a curve ball.
> ACPI depends on PM, but PM=n. In my experience, randconfig is a
> good tool for testing oddball configs, but the results are not
> always something that is fixable or needs to be fixed.
It looks like Kconfig does the right thing on i386 though. Not the same
on x84_64.
--
mattia
:wq!