2007-05-21 19:28:53

by Chris Wright

[permalink] [raw]
Subject: [patch 10/69] kbuild: fixdep segfault on pathological string-o-death

-stable review patch. If anyone has any objections, please let us know.
---------------------

From: Andy Green <[email protected]>

build scripts: fixdep blows segfault on string CONFIG_MODULE seen

The string "CONFIG_MODULE" appearing anywhere in a source file causes
fixdep to segfault. This string appeared in the wild in the current
mISDN sources (I think they meant CONFIG_MODULES). But it shouldn't
segfault (esp as CONFIG_MODULE appeared in a quoted string).

Signed-off-by: Andy Green <[email protected]>
Signed-off-by: Sam Ravnborg <[email protected]>
Signed-off-by: Chris Wright <[email protected]>
---

This is not an important fix per see - but I do not like SEGV during compilation...
Will be pushed to Linus today.

Sam

scripts/basic/fixdep.c | 2 ++
1 file changed, 2 insertions(+)

--- linux-2.6.21.1.orig/scripts/basic/fixdep.c
+++ linux-2.6.21.1/scripts/basic/fixdep.c
@@ -249,6 +249,8 @@ void parse_config_file(char *map, size_t
found:
if (!memcmp(q - 7, "_MODULE", 7))
q -= 7;
+ if( (q-p-7) < 0 )
+ continue;
use_config(p+7, q-p-7);
}
}

--