2007-05-21 19:22:29

by Chris Wright

[permalink] [raw]
Subject: [patch 45/69] IPMI: fix SI address space settings

-stable review patch. If anyone has any objections, please let us know.
---------------------

From: Corey Minyard <[email protected]>

Fix a rather obvious error that Patrick found in the setup routines. Need to
set the proper address space in the ACPI case.

Signed-off-by: Corey Minyard <[email protected]>
Cc: Patrick Schoeller <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Chris Wright <[email protected]>
---

drivers/char/ipmi/ipmi_si_intf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.21.1.orig/drivers/char/ipmi/ipmi_si_intf.c
+++ linux-2.6.21.1/drivers/char/ipmi/ipmi_si_intf.c
@@ -1859,10 +1859,10 @@ static __devinit int try_init_acpi(struc

if (spmi->addr.space_id == ACPI_ADR_SPACE_SYSTEM_MEMORY) {
info->io_setup = mem_setup;
- info->io.addr_type = IPMI_IO_ADDR_SPACE;
+ info->io.addr_type = IPMI_MEM_ADDR_SPACE;
} else if (spmi->addr.space_id == ACPI_ADR_SPACE_SYSTEM_IO) {
info->io_setup = port_setup;
- info->io.addr_type = IPMI_MEM_ADDR_SPACE;
+ info->io.addr_type = IPMI_IO_ADDR_SPACE;
} else {
kfree(info);
printk("ipmi_si: Unknown ACPI I/O Address type\n");

--