2007-05-27 09:48:16

by Mike Houston

[permalink] [raw]
Subject: 2.6.22-rc3 - VMI does not compile unless himem enabled

While building kernels for vmware guests, I noticed that the
paravirt VMI driver in 2.6.22-rc3 does not compile when highmem
support is disabled. This did not occur in 2.6.21

CC arch/i386/kernel/vmi.o
arch/i386/kernel/vmi.c: In function `vmi_update_pte':
arch/i386/kernel/vmi.c:422: error: dereferencing pointer to
incomplete type
arch/i386/kernel/vmi.c:422: error: `init_mm' undeclared (first use in
this function)
arch/i386/kernel/vmi.c:422: error: (Each undeclared identifier is
reported only once
arch/i386/kernel/vmi.c:422: error: for each function it appears in.)
arch/i386/kernel/vmi.c: In function `vmi_update_pte_defer':
arch/i386/kernel/vmi.c:428: error: dereferencing pointer to
incomplete type
arch/i386/kernel/vmi.c:428: error: `init_mm' undeclared (first use in
this function)
arch/i386/kernel/vmi.c: In function `vmi_set_pte_at':
arch/i386/kernel/vmi.c:441: error: dereferencing pointer to
incomplete type
arch/i386/kernel/vmi.c:441: error: `init_mm' undeclared (first use in
this function)
make[1]: *** [arch/i386/kernel/vmi.o] Error 1
make: *** [arch/i386/kernel] Error 2

This does not occur if himem support is enabled.

Mike Houston


2007-05-28 16:28:31

by Mike Houston

[permalink] [raw]
Subject: Re: 2.6.22-rc3 - VMI does not compile unless himem enabled

On Mon, 28 May 2007 12:11:35 +0200
"Michal Piotrowski" <[email protected]> wrote:

> Hi Mike,
>
> On 27/05/07, Mike Houston <[email protected]> wrote:
> > While building kernels for vmware guests, I noticed that the
> > paravirt VMI driver in 2.6.22-rc3 does not compile when highmem
> > support is disabled. This did not occur in 2.6.21

> Please try this patch
> http://lkml.org/lkml/diff/2007/5/24/143/1

Thank you Michal, Alexey Dobriyan replied off list and
showed me the fix that already went into -mm and it did indeed solve
the problem and the paravirt in the vmware guests works fine. Nice of
you folks to help me when I missed the ball. Sorry for missing that.

Mike Houston