2007-05-14 16:10:44

by Vitaliy Ivanov

[permalink] [raw]
Subject: USB adutux device number

Hello,

I'm not sure if it's correct place to deal with the issue.

In Documentation/devices.txt there is no info about adutux driver that
is included in the kernel:
...
65 = /dev/usb/usblcd USBLCD Interface ([email protected])
66 = /dev/usb/cpad0 Synaptics cPad (mouse/LCD)
96 = /dev/usb/hiddev0 1st USB HID device
...
...

The driver itself includes the following (drivers/usb/misc/adutux.c):

#ifdef CONFIG_USB_DYNAMIC_MINORS
#define ADU_MINOR_BASE 0
#else
#define ADU_MINOR_BASE 67
#endif

We need to update Documentation/devices.txt with this information. The
number of devices is 16.

I found an old mail tread for this:
http://www.uwsg.iu.edu/hypermail/linux/kernel/0609.3/2173.html
But I don't see anything related to adu devices in devices.txt at all.

Please let me know what is the reason of this. If needed I will create
a patch for this.

-- V


2007-05-15 12:05:50

by Vitaliy Ivanov

[permalink] [raw]
Subject: Re: USB adutux device number

Did any of USB fellows has a chance to look at this issue?

It can be critical to customers as this 67 minor number is listed in
the driver code only and not all of them going through the code.

-- Vitaliy


On 5/14/07, Vitaliy Ivanov <[email protected]> wrote:
> Hello,
>
> I'm not sure if it's correct place to deal with the issue.
>
> In Documentation/devices.txt there is no info about adutux driver that
> is included in the kernel:
> ...
> 65 = /dev/usb/usblcd USBLCD Interface ([email protected])
> 66 = /dev/usb/cpad0 Synaptics cPad (mouse/LCD)
> 96 = /dev/usb/hiddev0 1st USB HID device
> ...
> ...
>
> The driver itself includes the following (drivers/usb/misc/adutux.c):
>
> #ifdef CONFIG_USB_DYNAMIC_MINORS
> #define ADU_MINOR_BASE 0
> #else
> #define ADU_MINOR_BASE 67
> #endif
>
> We need to update Documentation/devices.txt with this information. The
> number of devices is 16.
>
> I found an old mail tread for this:
> http://www.uwsg.iu.edu/hypermail/linux/kernel/0609.3/2173.html
> But I don't see anything related to adu devices in devices.txt at all.
>
> Please let me know what is the reason of this. If needed I will create
> a patch for this.
>
> -- V
>

2007-06-01 17:15:20

by Greg KH

[permalink] [raw]
Subject: Re: USB adutux device number

On Tue, May 15, 2007 at 03:05:41PM +0300, Vitaliy Ivanov wrote:
> Did any of USB fellows has a chance to look at this issue?
>
> It can be critical to customers as this 67 minor number is listed in
> the driver code only and not all of them going through the code.

Yeah, someone reverted all of the USB minor numbers in this file, I'll
work to fix it up again...

thanks,

greg k-h