2007-06-12 07:40:22

by Yoshinori Sato

[permalink] [raw]
Subject: [PATCH] CONFIG_INET depend on CONFIG_SYSCTL

It cannot build with CONFIG_SYSCTL=n and CONFIG_INET=y.
In case of CONFIG_INET=y it should become CONFIG_SYSCTL=y.

Signed-off-by: Yoshinori Sato <[email protected]>

diff --git a/net/Kconfig b/net/Kconfig
index f3de729..2e9a885 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -34,6 +34,7 @@ source "net/iucv/Kconfig"

config INET
bool "TCP/IP networking"
+ select SYSCTL
---help---
These are the protocols used on the Internet and on most local
Ethernets. It is highly recommended to say Y here (this will enlarge

--
Yoshinori Sato
<[email protected]>


2007-06-12 08:09:01

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] CONFIG_INET depend on CONFIG_SYSCTL

From: Yoshinori Sato <[email protected]>
Date: Tue, 12 Jun 2007 16:38:55 +0900

> It cannot build with CONFIG_SYSCTL=n and CONFIG_INET=y.
> In case of CONFIG_INET=y it should become CONFIG_SYSCTL=y.
>
> Signed-off-by: Yoshinori Sato <[email protected]>

1) Please post networking patches to [email protected]
which has been added to the CC:

2) It is much better to add the appropriate CONFIG_SYSCTL
ifdefs to the INET code than to force it on for everyone.

2007-06-13 06:00:42

by Yoshinori Sato

[permalink] [raw]
Subject: Re: [PATCH] CONFIG_INET depend on CONFIG_SYSCTL

At Tue, 12 Jun 2007 01:08:55 -0700 (PDT),
David Miller wrote:
>
> From: Yoshinori Sato <[email protected]>
> Date: Tue, 12 Jun 2007 16:38:55 +0900
>
> > It cannot build with CONFIG_SYSCTL=n and CONFIG_INET=y.
> > In case of CONFIG_INET=y it should become CONFIG_SYSCTL=y.
> >
> > Signed-off-by: Yoshinori Sato <[email protected]>
>
> 1) Please post networking patches to [email protected]
> which has been added to the CC:

It was understood.

> 2) It is much better to add the appropriate CONFIG_SYSCTL
> ifdefs to the INET code than to force it on for everyone.

It examined that, but many corrections become necessary.

--
Yoshinori Sato
<[email protected]>

2007-06-13 06:05:39

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] CONFIG_INET depend on CONFIG_SYSCTL

From: Yoshinori Sato <[email protected]>
Date: Wed, 13 Jun 2007 14:59:16 +0900

> At Tue, 12 Jun 2007 01:08:55 -0700 (PDT),
> David Miller wrote:
>
> > 2) It is much better to add the appropriate CONFIG_SYSCTL
> > ifdefs to the INET code than to force it on for everyone.
>
> It examined that, but many corrections become necessary.

I understand, but embedded people will not be happy that
SYSFS is a requirement for IPV4 networking. Every little
bit of space savings matters for them.

2007-06-22 07:42:44

by Yoshinori Sato

[permalink] [raw]
Subject: Re: [PATCH] CONFIG_INET depend on CONFIG_SYSCTL

At Tue, 12 Jun 2007 23:05:45 -0700 (PDT),
David Miller wrote:
>
> From: Yoshinori Sato <[email protected]>
> Date: Wed, 13 Jun 2007 14:59:16 +0900
>
> > At Tue, 12 Jun 2007 01:08:55 -0700 (PDT),
> > David Miller wrote:
> >
> > > 2) It is much better to add the appropriate CONFIG_SYSCTL
> > > ifdefs to the INET code than to force it on for everyone.
> >
> > It examined that, but many corrections become necessary.
>
> I understand, but embedded people will not be happy that
> SYSFS is a requirement for IPV4 networking. Every little
> bit of space savings matters for them.

A reply became late, sorry.

I do not check it in detail, but there seem to be part a few
depending SYSFS.
I need to check whether can separate a SYSFS depending part.

It may take time, but tries to check it.

> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

--
Yoshinori Sato
<[email protected]>