2007-06-14 17:23:21

by Oleg Nesterov

[permalink] [raw]
Subject: [PATCH] adb_probe_task: remove unneeded flush_signals() call

adb_probe_task() is forked by "events" thread, all signals are ignored,
no need to play with signal blocking/flushing.

Signed-off-by: Oleg Nesterov <[email protected]>

--- sig/drivers/macintosh/adb.c~3_adb 2007-05-21 13:57:51.000000000 +0400
+++ sig/drivers/macintosh/adb.c 2007-06-14 21:09:58.000000000 +0400
@@ -248,21 +248,15 @@ static int adb_scan_bus(void)
static int
adb_probe_task(void *x)
{
- sigset_t blocked;
-
strcpy(current->comm, "kadbprobe");

- sigfillset(&blocked);
- sigprocmask(SIG_BLOCK, &blocked, NULL);
- flush_signals(current);
-
printk(KERN_INFO "adb: starting probe task...\n");
do_adb_reset_bus();
printk(KERN_INFO "adb: finished probe task...\n");
-
+
adb_probe_task_pid = 0;
up(&adb_probe_mutex);
-
+
return 0;
}