2007-06-16 10:24:53

by Thomas Gleixner

[permalink] [raw]
Subject: [patch-mm 00/25] High resolution timer updates and x86_64 support - V2

The following patch series contains:

- dyntick bugfixes for -mm (caused by the cpuidle changes in ACPI)

- updates and improvements to high resolution timer / dynticks

- high resolution timer / dynticks support for x86_64

The x86_64 support is based on an initial patch from Chris Wright. Thanks Chris !

The patch set has been tested in the -hrt and -rt trees for quite a while
and the initial problems have been sorted out. Thanks to the folks from the
PowerTop project for testing and feedback.

The -hrt tree at http://www.tglx.de/projects/hrtimers/2.6.22-rc4/ contains
also an hpet force patch series from Venki Pallipadi, but I leave this up to
Venki to send it mainline wards.

Changes since V1:

- simplified the idle breakage fixup

- fixed a resume bug (making the famous VAIO work again)

- added a clocksource settimeofday hook for PPC (Tony Breeds)

Thanks,

tglx
--


2007-06-16 14:41:50

by Alistair John Strachan

[permalink] [raw]
Subject: Re: [patch-mm 00/25] High resolution timer updates and x86_64 support - V2

On Saturday 16 June 2007 11:36:00 Thomas Gleixner wrote:
> The -hrt tree at http://www.tglx.de/projects/hrtimers/2.6.22-rc4/ contains
> also an hpet force patch series from Venki Pallipadi, but I leave this up
> to Venki to send it mainline wards.

What's the status on the nForce "hpet force fix" (Subject: "Enable hidden HPET
on NVidia motherboards") that also exists? I think if one board can have its
HPET forced, so can another.

Last I heard we were waiting on NVIDIA to confirm whether Mikko's logic was
supported by specifications? Any update on this?

--
Cheers,
Alistair.

Final year Computer Science undergraduate.
1F2 55 South Clerk Street, Edinburgh, UK.

2007-06-16 19:06:34

by Thomas Gleixner

[permalink] [raw]
Subject: Re: [patch-mm 00/25] High resolution timer updates and x86_64 support - V2

On Sat, 2007-06-16 at 15:41 +0100, Alistair John Strachan wrote:
> On Saturday 16 June 2007 11:36:00 Thomas Gleixner wrote:
> > The -hrt tree at http://www.tglx.de/projects/hrtimers/2.6.22-rc4/ contains
> > also an hpet force patch series from Venki Pallipadi, but I leave this up
> > to Venki to send it mainline wards.
>
> What's the status on the nForce "hpet force fix" (Subject: "Enable hidden HPET
> on NVidia motherboards") that also exists? I think if one board can have its
> HPET forced, so can another.
>
> Last I heard we were waiting on NVIDIA to confirm whether Mikko's logic was
> supported by specifications? Any update on this?

The full hpet force enable series is maintained by Venki and updates
should go to him. I can add the patch to my -hrt queue for testing.

tglx


2007-06-16 23:04:24

by Nigel Cunningham

[permalink] [raw]
Subject: Re: [patch-mm 00/25] High resolution timer updates and x86_64 support - V2

Hi all.

I'm currently running with the combined patch applied all the time, and it
seems to be working fine here, including with hibernation.

Regards,

Nigel
--
Nigel, Michelle and Alisdair Cunningham
5 Mitchell Street
Cobden 3266
Victoria, Australia


Attachments:
(No filename) (255.00 B)
(No filename) (189.00 B)
Download all attachments

2007-06-18 20:07:41

by Valdis Klētnieks

[permalink] [raw]
Subject: Re: [patch-mm 00/25] High resolution timer updates and x86_64 support - V2

On Sat, 16 Jun 2007 10:36:00 -0000, Thomas Gleixner said:
> The following patch series contains:
>
> - dyntick bugfixes for -mm (caused by the cpuidle changes in ACPI)
>
> - updates and improvements to high resolution timer / dynticks
>
> - high resolution timer / dynticks support for x86_64

Am running with the 22-rc4-mm2-hrt4 patch on my Latitude D820. Mostly seems
to work, but for some reason the Intel 'powertop' util thinks it's 100% busy:

PowerTOP version 1.7 (C) 2007 Intel Corporation

Cn Avg residency (5s) P-states (frequencies)
C0 (cpu running) (100.0%)
C1 0.0ms ( 0.0%) 2.00 Ghz 0.0%
C2 0.0ms ( 0.0%) 1.67 Ghz 0.0%
C3 0.0ms ( 0.0%) 1333 Mhz 0.0%
1000 Mhz 100.0%

In reality:

[/sys/devices/system/cpu/cpu0/cpuidle] for i in */*; do echo -n "$i: "; cat $i; done
state0/latency: 1
state0/power: 1000
state0/time: 0
state0/usage: 3
state1/latency: 1
state1/power: 500
state1/time: 1756017623
state1/usage: 1837402
state2/latency: 57
state2/power: 100
state2/time: -159524787
state2/usage: 15007443

I think we have a 32/64 bit issue on state2/time which is probably borking
things up....


Attachments:
(No filename) (226.00 B)

2007-06-18 20:24:47

by Pallipadi, Venkatesh

[permalink] [raw]
Subject: RE: [patch-mm 00/25] High resolution timer updates and x86_64 support - V2



>-----Original Message-----
>From: [email protected] [mailto:[email protected]]
>Sent: Monday, June 18, 2007 1:07 PM
>To: Thomas Gleixner
>Cc: LKML; Andrew Morton; Ingo Molnar; Andi Kleen; Chris
>Wright; Arjan van de Ven; Pallipadi, Venkatesh
>Subject: Re: [patch-mm 00/25] High resolution timer updates
>and x86_64 support - V2
>
>On Sat, 16 Jun 2007 10:36:00 -0000, Thomas Gleixner said:
>> The following patch series contains:
>>
>> - dyntick bugfixes for -mm (caused by the cpuidle changes in ACPI)
>>
>> - updates and improvements to high resolution timer / dynticks
>>
>> - high resolution timer / dynticks support for x86_64
>
>Am running with the 22-rc4-mm2-hrt4 patch on my Latitude D820.
> Mostly seems
>to work, but for some reason the Intel 'powertop' util thinks
>it's 100% busy:
>
> PowerTOP version 1.7 (C) 2007 Intel Corporation
>
>Cn Avg residency (5s) P-states (frequencies)
>C0 (cpu running) (100.0%)
>C1 0.0ms ( 0.0%) 2.00 Ghz 0.0%
>C2 0.0ms ( 0.0%) 1.67 Ghz 0.0%
>C3 0.0ms ( 0.0%) 1333 Mhz 0.0%
> 1000 Mhz 100.0%
>
>In reality:
>
>[/sys/devices/system/cpu/cpu0/cpuidle] for i in */*; do echo
>-n "$i: "; cat $i; done
>state0/latency: 1
>state0/power: 1000
>state0/time: 0
>state0/usage: 3
>state1/latency: 1
>state1/power: 500
>state1/time: 1756017623
>state1/usage: 1837402
>state2/latency: 57
>state2/power: 100
>state2/time: -159524787
>state2/usage: 15007443
>

The problem is powertop only understands /proc/acpi/processor/CPU*/power
for
and not /sys..cpuidle for the moment.

I had a patch in recent cpuidle fixes series that makes /proc interface
active
again with cpuidle which should correct this. Those patches are not in
rc4-mm2-hrt4, but are there in latest rc4-hrt and rc5-hrt series.

Thanks,
Venki

2007-06-18 21:50:53

by Valdis Klētnieks

[permalink] [raw]
Subject: Re: [patch-mm 00/25] High resolution timer updates and x86_64 support - V2

On Mon, 18 Jun 2007 13:24:33 PDT, "Pallipadi, Venkatesh" said:

> >state2/time: -159524787
> >state2/usage: 15007443
> >
>
> The problem is powertop only understands /proc/acpi/processor/CPU*/power
> for
> and not /sys..cpuidle for the moment.
>
> I had a patch in recent cpuidle fixes series that makes /proc interface
> active
> again with cpuidle which should correct this. Those patches are not in
> rc4-mm2-hrt4, but are there in latest rc4-hrt and rc5-hrt series.

OK, so I've got a 32/64 bug that isn't the cause of *this* issue because
powertop isn't looking at the broken value.

A quick check shows that the keep_proc_acpi_power_around_001.patch from
rc5-hrt will apply to rc4-mm2-hrt - I'll give that a try tonight and report
back...


Attachments:
(No filename) (226.00 B)

2007-06-18 22:10:57

by Pallipadi, Venkatesh

[permalink] [raw]
Subject: RE: [patch-mm 00/25] High resolution timer updates and x86_64 support - V2



>-----Original Message-----
>From: [email protected] [mailto:[email protected]]
>Sent: Monday, June 18, 2007 2:50 PM
>To: Pallipadi, Venkatesh
>Cc: Thomas Gleixner; LKML; Andrew Morton; Ingo Molnar; Andi
>Kleen; Chris Wright; Arjan van de Ven
>Subject: Re: [patch-mm 00/25] High resolution timer updates
>and x86_64 support - V2
>
>On Mon, 18 Jun 2007 13:24:33 PDT, "Pallipadi, Venkatesh" said:
>
>> >state2/time: -159524787
>> >state2/usage: 15007443
>> >
>>
>> The problem is powertop only understands
>/proc/acpi/processor/CPU*/power
>> for
>> and not /sys..cpuidle for the moment.
>>
>> I had a patch in recent cpuidle fixes series that makes
>/proc interface
>> active
>> again with cpuidle which should correct this. Those patches
>are not in
>> rc4-mm2-hrt4, but are there in latest rc4-hrt and rc5-hrt series.
>
>OK, so I've got a 32/64 bug that isn't the cause of *this*
>issue because
>powertop isn't looking at the broken value.
>

Yes. The output does indicate a bug in cpuidle /sysfs part. Will look at
sysfs output of cpuidle and fix those issues soon.

Thanks,
Venki

2007-06-19 01:56:29

by Arjan van de Ven

[permalink] [raw]
Subject: Re: [patch-mm 00/25] High resolution timer updates and x86_64 support - V2

On Mon, 2007-06-18 at 16:06 -0400, [email protected] wrote:
> On Sat, 16 Jun 2007 10:36:00 -0000, Thomas Gleixner said:
> > The following patch series contains:
> >
> > - dyntick bugfixes for -mm (caused by the cpuidle changes in ACPI)
> >
> > - updates and improvements to high resolution timer / dynticks
> >
> > - high resolution timer / dynticks support for x86_64
>
> Am running with the 22-rc4-mm2-hrt4 patch on my Latitude D820. Mostly seems
> to work, but for some reason the Intel 'powertop' util thinks it's 100% busy:
>
> PowerTOP version 1.7 (C) 2007 Intel Corporation
>
> Cn Avg residency (5s) P-states (frequencies)
> C0 (cpu running) (100.0%)
> C1 0.0ms ( 0.0%) 2.00 Ghz 0.0%
> C2 0.0ms ( 0.0%) 1.67 Ghz 0.0%
> C3 0.0ms ( 0.0%) 1333 Mhz 0.0%
> 1000 Mhz 100.0%
>
> In reality:


looks like something broke the /proc/acpi/processor/*/power file
data....

can you check in that file to see if there is actual C-state time
accounting going on?
(it is in mainline, so if it's not then it's an -mm or -hrt bug)

--
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org

2007-06-19 11:29:19

by Valdis Klētnieks

[permalink] [raw]
Subject: Re: [patch-mm 00/25] High resolution timer updates and x86_64 support - V2

On Mon, 18 Jun 2007 17:49:44 EDT, [email protected] said:

> A quick check shows that the keep_proc_acpi_power_around_001.patch from
> rc5-hrt will apply to rc4-mm2-hrt - I'll give that a try tonight and report
> back...

Confirming - I backported that patch from rc5-hrt to rc4-mm2-hrt, and
now powertop is reporting sane values again:

PowerTOP version 1.7 (C) 2007 Intel Corporation

Cn Avg residency (5s) P-states (frequencies)
C0 (cpu running) (15.8%)
C1 0.0ms ( 0.0%) 2.00 Ghz 0.0%
C2 0.6ms ( 7.9%) 1.67 Ghz 0.0%
C3 0.7ms (76.3%) 1333 Mhz 0.0%
1000 Mhz 100.0%



Attachments:
(No filename) (226.00 B)