2007-06-17 23:44:07

by Adrian Bunk

Subject: [2.6 patch] include/linux/kprobes.h: always offer show_registers() prototype

Allow gcc to perform show_registers() type checking also with
CONFIG_KPROBES=n.

Signed-off-by: Adrian Bunk <[email protected]>

---

This patch has been sent on:
- 27 Apr 2007
- 27 Mar 2007

include/linux/kprobes.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

--- linux-2.6.21-rc4-mm1/include/linux/kprobes.h.old 2007-03-26 15:28:27.000000000 +0200
+++ linux-2.6.21-rc4-mm1/include/linux/kprobes.h 2007-03-26 15:32:23.000000000 +0200
@@ -163,7 +163,6 @@
extern void arch_arm_kprobe(struct kprobe *p);
extern void arch_disarm_kprobe(struct kprobe *p);
extern int arch_init_kprobes(void);
-extern void show_registers(struct pt_regs *regs);
extern kprobe_opcode_t *get_insn_slot(void);
extern void free_insn_slot(kprobe_opcode_t *slot, int dirty);
extern void kprobes_inc_nmissed_count(struct kprobe *p);
@@ -241,4 +240,7 @@
{
}
#endif /* CONFIG_KPROBES */
+
+void show_registers(struct pt_regs *regs);
+
#endif /* _LINUX_KPROBES_H */

2007-06-18 06:27:18

by S. P. Prasanna

Subject: Re: [2.6 patch] include/linux/kprobes.h: always offer show_registers() prototype

On Mon, Jun 18, 2007 at 01:43:04AM +0200, Adrian Bunk wrote:
> Allow gcc to perform show_registers() type checking also with
> CONFIG_KPROBES=n.
>
Adrian,

Please implement it as Andrew suggested, when this was patch was posted
eariler. Refer this discussion thread below.

http://lkml.org/lkml/2007/4/27/576

NACK

Thanks
Prasanna

> Signed-off-by: Adrian Bunk <[email protected]>
>
> ---
>
> This patch has been sent on:
> - 27 Apr 2007
> - 27 Mar 2007
>
> include/linux/kprobes.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> --- linux-2.6.21-rc4-mm1/include/linux/kprobes.h.old 2007-03-26 15:28:27.000000000 +0200
> +++ linux-2.6.21-rc4-mm1/include/linux/kprobes.h 2007-03-26 15:32:23.000000000 +0200
> @@ -163,7 +163,6 @@
> extern void arch_arm_kprobe(struct kprobe *p);
> extern void arch_disarm_kprobe(struct kprobe *p);
> extern int arch_init_kprobes(void);
> -extern void show_registers(struct pt_regs *regs);
> extern kprobe_opcode_t *get_insn_slot(void);
> extern void free_insn_slot(kprobe_opcode_t *slot, int dirty);
> extern void kprobes_inc_nmissed_count(struct kprobe *p);
> @@ -241,4 +240,7 @@
> {
> }
> #endif /* CONFIG_KPROBES */
> +
> +void show_registers(struct pt_regs *regs);
> +
> #endif /* _LINUX_KPROBES_H */

--
Prasanna S.P.
Linux Technology Center
India Software Labs, IBM Bangalore
Email: [email protected]
Ph: 91-80-41776329