2007-06-20 01:35:28

by Qi Yong

Subject: [patch] add printk_ratelimit to atkbd_interrupt

Add printk_ratelimit() to atkbd_interrupt(). I get "Spurious ACK" messages flushing on my
screen. This patch helps to read the screen.

Signed-off-by: Qi Yong <[email protected]>
--
diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
index be1fe46..13e6bd4 100644
--- a/drivers/input/keyboard/atkbd.c
+++ b/drivers/input/keyboard/atkbd.c
@@ -408,9 +408,10 @@ static irqreturn_t atkbd_interrupt(struct serio *serio, unsigned char data,
goto out;
case ATKBD_RET_ACK:
case ATKBD_RET_NAK:
- printk(KERN_WARNING "atkbd.c: Spurious %s on %s. "
- "Some program might be trying access hardware directly.\n",
- data == ATKBD_RET_ACK ? "ACK" : "NAK", serio->phys);
+ if (printk_ratelimit())
+ printk(KERN_WARNING "atkbd.c: Spurious %s on %s. "
+ "Some program might be trying access hardware directly.\n",
+ data == ATKBD_RET_ACK ? "ACK" : "NAK", serio->phys);
goto out;
case ATKBD_RET_HANGEUL:
case ATKBD_RET_HANJA:

2007-06-20 04:13:20

by Dmitry Torokhov

Subject: Re: [patch] add printk_ratelimit to atkbd_interrupt

On Tuesday 19 June 2007 21:17, Qi Yong wrote:
> Add printk_ratelimit() to atkbd_interrupt(). I get "Spurious ACK" messages flushing on my
> screen. This patch helps to read the screen.
>

Will apply, thank you.

Do you have any idea why you are getting spurios ACK messages? Do you have
an application fiddling with keyboard port or do you have blink driver
enabled?

--
Dmitry

2007-06-20 07:58:46

by Qi Yong

Subject: Re: [patch] add printk_ratelimit to atkbd_interrupt

Dmitry Torokhov wrote:
> On Tuesday 19 June 2007 21:17, Qi Yong wrote:
>
>> Add printk_ratelimit() to atkbd_interrupt(). I get "Spurious ACK" messages flushing on my
>> screen. This patch helps to read the screen.
>>
>>
>
> Will apply, thank you.
>
> Do you have any idea why you are getting spurios ACK messages? Do you have
> an application fiddling with keyboard port or do you have blink driver
> enabled?

No idea. It is at boot time.
Yes, i have CONFIG_BLINK=y.

(add CC: Michal Piotrowski)

--
Qi Yong

2007-06-21 03:07:28

by Dmitry Torokhov

Subject: Re: [patch] add printk_ratelimit to atkbd_interrupt

On Wednesday 20 June 2007 03:34, Qi Yong wrote:
> Dmitry Torokhov wrote:
> > On Tuesday 19 June 2007 21:17, Qi Yong wrote:
> >
> >> Add printk_ratelimit() to atkbd_interrupt(). I get "Spurious ACK" messages flushing on my
> >> screen. This patch helps to read the screen.
> >>
> >>
> >
> > Will apply, thank you.
> >
> > Do you have any idea why you are getting spurios ACK messages? Do you have
> > an application fiddling with keyboard port or do you have blink driver
> > enabled?
>
> No idea. It is at boot time.
> Yes, i have CONFIG_BLINK=y.

Disable it.

--
Dmitry