2007-08-04 13:03:25

by Adrian Bunk

Subject: [2.6 patch] drivers/video/geode/lxfb_core.c: cleanups

This pacth contains the following cleanups:
- make the needlessly global geode_modedb[] static
- lxfb_setup(): remove an unused variable

Signed-off-by: Adrian Bunk <[email protected]>

---

drivers/video/geode/lxfb_core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

6ff33bdabb002b71b60258da40b3021b0d0a1ee2
diff --git a/drivers/video/geode/lxfb_core.c b/drivers/video/geode/lxfb_core.c
index 5e30b40..2932863 100644
--- a/drivers/video/geode/lxfb_core.c
+++ b/drivers/video/geode/lxfb_core.c
@@ -34,7 +34,7 @@ static int fbsize;
* we try to make it something sane - 640x480-60 is sane
*/

-const struct fb_videomode geode_modedb[] __initdata = {
+static const struct fb_videomode geode_modedb[] __initdata = {
/* 640x480-60 */
{ NULL, 60, 640, 480, 39682, 48, 8, 25, 2, 88, 2,
FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
@@ -561,8 +561,6 @@ static struct pci_driver lxfb_driver = {
#ifndef MODULE
static int __init lxfb_setup(char *options)
{
- char *opt;
-
if (!options || !*options)
return 0;

2007-08-04 13:24:28

by Eugene Teo

Subject: Re: [2.6 patch] drivers/video/geode/lxfb_core.c: cleanups

<quote sender="Adrian Bunk">
> This pacth contains the following cleanups:
> - make the needlessly global geode_modedb[] static
> - lxfb_setup(): remove an unused variable

I have submitted a patch for the 2nd cleanup:
http://marc.info/?l=linux-mm-commits&m=118616305111463&w=2

Thanks,
Eugene