2007-08-04 13:17:49

by Prakash Punnoor

[permalink] [raw]
Subject: Re: 2.6.23-rc1, KVM-AMD problem

Am Montag 30 Juli 2007 schrieb Avi Kivity:
> Alistair John Strachan wrote:
[...]
> > Basically, the installer seems to work fine, but Windows seemed to have
> > problems after installing post-SP2 updates. Maybe that's why not
> > everybody is seeing it yet.
>
> How about the attached patch? (I haven't yet tried to reproduce, but
> this can cause an AMD-only oops).

commit 80917728e43e248155c019f743655806b582b099
Author: Avi Kivity <[email protected]>
Date: Mon Jul 30 15:56:36 2007 +0300

KVM: x86 emulator: disable writeback for debug register instructions

These are handled internally by the instruction.

Signed-off-by: Avi Kivity <[email protected]>

diff --git a/drivers/kvm/x86_emulate.c b/drivers/kvm/x86_emulate.c
index 1a90ba0..2136da5 100644
--- a/drivers/kvm/x86_emulate.c
+++ b/drivers/kvm/x86_emulate.c
@@ -1222,11 +1222,13 @@ twobyte_insn:
}
break;
case 0x21: /* mov from dr to reg */
+ no_wb = 1;
if (modrm_mod != 3)
goto cannot_emulate;
rc = emulator_get_dr(ctxt, modrm_reg, &_regs[modrm_rm]);
break;
case 0x23: /* mov from reg to dr */
+ no_wb = 1;
if (modrm_mod != 3)
goto cannot_emulate;
rc = emulator_set_dr(ctxt, modrm_reg, _regs[modrm_rm]);


Unfortunately this doesn't seem to have made it into 2.6.23-rc2. I need it as
well, to make Windows XP boot up w/o hanging or reebooting my host machine.

Cheers,
--
(?= =?)
//\ Prakash Punnoor /\\
V_/ \_V


Attachments:
(No filename) (1.60 kB)
signature.asc (189.00 B)
This is a digitally signed message part.
Download all attachments

2007-08-04 14:24:20

by Alistair John Strachan

[permalink] [raw]
Subject: Re: 2.6.23-rc1, KVM-AMD problem

On Saturday 04 August 2007 14:17:34 Prakash Punnoor wrote:
> Unfortunately this doesn't seem to have made it into 2.6.23-rc2. I need it
> as well, to make Windows XP boot up w/o hanging or reebooting my host
> machine.

It isn't in 2.6.23-rc2. I guess Avi should re-send to Linus and hopefully
it'll be in -rc3. Thanks for pointing this out.

--
Cheers,
Alistair.

137/1 Warrender Park Road, Edinburgh, UK.