2007-08-06 11:55:12

by Thomas Klein

[permalink] [raw]
Subject: [RESEND][PATCH 1/3] ehea: Fix workqueue handling

Fix: Workqueue ehea_driver_wq was not destroyed

Signed-off-by: Thomas Klein <[email protected]>

---
drivers/net/ehea/ehea.h | 2 +-
drivers/net/ehea/ehea_main.c | 1 +
2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea/ehea.h
index 8ee2c2c..d67f97b 100644
--- a/drivers/net/ehea/ehea.h
+++ b/drivers/net/ehea/ehea.h
@@ -39,7 +39,7 @@
#include <asm/io.h>

#define DRV_NAME "ehea"
-#define DRV_VERSION "EHEA_0072"
+#define DRV_VERSION "EHEA_0073"

/* eHEA capability flags */
#define DLPAR_PORT_ADD_REM 1
diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c
index 58702f5..d43ab0f 100644
--- a/drivers/net/ehea/ehea_main.c
+++ b/drivers/net/ehea/ehea_main.c
@@ -3099,6 +3099,7 @@ out:

static void __exit ehea_module_exit(void)
{
+ destroy_workqueue(ehea_driver_wq);
driver_remove_file(&ehea_driver.driver, &driver_attr_capabilities);
ibmebus_unregister_driver(&ehea_driver);
ehea_destroy_busmap();
--
1.5.2



2007-08-07 21:57:37

by Jeff Garzik

[permalink] [raw]
Subject: Re: [RESEND][PATCH 1/3] ehea: Fix workqueue handling

Thomas Klein wrote:
> Fix: Workqueue ehea_driver_wq was not destroyed
>
> Signed-off-by: Thomas Klein <[email protected]>
>
> ---
> drivers/net/ehea/ehea.h | 2 +-
> drivers/net/ehea/ehea_main.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletions(-)

applied 1-3 to #upstream-fixes