2007-08-11 00:55:48

by Yinghai Lu

[permalink] [raw]
Subject: [PATCH] x86: make io-apic not connected pin print complete

[PATCH] x86: make io-apic not connected pin print complete

normally will have two segment not connected pin
pin0, and pin after 15...

so need to print out "not connected\n" for previous segment,
before print out connected pins info...

Signed-off-by: Yinghai Lu <[email protected]>

diff --git a/arch/x86_64/kernel/io_apic.c b/arch/x86_64/kernel/io_apic.c
index 050141c..a591679 100644
--- a/arch/x86_64/kernel/io_apic.c
+++ b/arch/x86_64/kernel/io_apic.c
@@ -874,6 +874,10 @@ static void __init setup_IO_APIC_irqs(void)
apic_printk(APIC_VERBOSE, ", %d-%d", mp_ioapics[apic].mpc_apicid, pin);
continue;
}
+ if (!first_notcon) {
+ apic_printk(APIC_VERBOSE, " not connected.\n");
+ first_notcon = 1;
+ }

irq = pin_2_irq(idx, apic, pin);
add_pin_to_irq(irq, apic, pin);
@@ -884,7 +888,7 @@ static void __init setup_IO_APIC_irqs(void)
}

if (!first_notcon)
- apic_printk(APIC_VERBOSE," not connected.\n");
+ apic_printk(APIC_VERBOSE, " not connected.\n");
}

/*
diff --git a/arch/i386/kernel/io_apic.c b/arch/i386/kernel/io_apic.c
index 893df82..39cf860 100644
--- a/arch/i386/kernel/io_apic.c
+++ b/arch/i386/kernel/io_apic.c
@@ -1301,6 +1301,11 @@ static void __init setup_IO_APIC_irqs(void)
continue;
}

+ if (!first_notcon) {
+ apic_printk(APIC_VERBOSE, " not connected.\n");
+ first_notcon = 1;
+ }
+
entry.trigger = irq_trigger(idx);
entry.polarity = irq_polarity(idx);