2007-08-15 08:45:18

by YAMAMOTO Takashi

Subject: Re: [-mm PATCH 4/9] Memory controller memory accounting (v4)

> YAMAMOTO Takashi wrote:
> >> + lock_meta_page(page);
> >> + /*
> >> + * Check if somebody else beat us to allocating the meta_page
> >> + */
> >> + race_mp = page_get_meta_page(page);
> >> + if (race_mp) {
> >> + kfree(mp);
> >> + mp = race_mp;
> >> + atomic_inc(&mp->ref_cnt);
> >> + res_counter_uncharge(&mem->res, 1);
> >> + goto done;
> >> + }
> >
> > i think you need css_put here.
>
> Thats correct. We do need css_put in this path.
>
> Thanks,
> Vaidy

v5 still seems to have the problem.

YAMAMOTO Takashi

2007-08-15 10:05:32

by Balbir Singh

Subject: Re: [-mm PATCH 4/9] Memory controller memory accounting (v4)

YAMAMOTO Takashi wrote:
>> YAMAMOTO Takashi wrote:
>>>> + lock_meta_page(page);
>>>> + /*
>>>> + * Check if somebody else beat us to allocating the meta_page
>>>> + */
>>>> + race_mp = page_get_meta_page(page);
>>>> + if (race_mp) {
>>>> + kfree(mp);
>>>> + mp = race_mp;
>>>> + atomic_inc(&mp->ref_cnt);
>>>> + res_counter_uncharge(&mem->res, 1);
>>>> + goto done;
>>>> + }
>>> i think you need css_put here.
>> Thats correct. We do need css_put in this path.
>>
>> Thanks,
>> Vaidy
>
> v5 still seems to have the problem.
>
> YAMAMOTO Takashi
>

Hi,

I've got the fix in v6 now, thanks for spotting it.

--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL