2007-08-18 17:38:35

by Oleg Nesterov

[permalink] [raw]
Subject: [PATCH 4/5] exec: consolidate 2 fast-paths

Now that we don't pre-allocate the new ->sighand, we can kill the first fast
path, it doesn't make sense any longer. At best, it can save one "list_empty()"
check but leads to the code duplication.

Signed-off-by: Oleg Nesterov <[email protected]>

--- t/fs/exec.c~4_FASTPATH 2007-08-18 19:10:58.000000000 +0400
+++ t/fs/exec.c 2007-08-18 19:34:12.000000000 +0400
@@ -779,16 +779,6 @@ static int de_thread(struct task_struct
struct task_struct *leader = NULL;
int count;

- /*
- * If we don't share sighandlers, then we aren't sharing anything
- * and we can just re-use it all.
- */
- if (atomic_read(&oldsighand->count) <= 1) {
- signalfd_detach(tsk);
- exit_itimers(sig);
- return 0;
- }
-
if (thread_group_empty(tsk))
goto no_thread_group;