2007-08-20 22:53:46

by Tony Jones

Subject: [patch 04/14] Convert from class_device to device for drivers/macintosh

--
Content-Disposition: inline; filename=macintosh.patch

Convert from class_device to device for macintosh. This is part of the
work to eliminate struct class_device.

---
drivers/macintosh/adb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/macintosh/adb.c
+++ b/drivers/macintosh/adb.c
@@ -875,5 +875,5 @@ adbdev_init(void)
adb_dev_class = class_create(THIS_MODULE, "adb");
if (IS_ERR(adb_dev_class))
return;
- class_device_create(adb_dev_class, NULL, MKDEV(ADB_MAJOR, 0), NULL, "adb");
+ device_create(adb_dev_class, NULL, MKDEV(ADB_MAJOR, 0), "adb");
}

--

2007-08-21 15:01:39

by Tony Jones

Subject: Re: [patch 04/14] Convert from class_device to device for drivers/macintosh

On Mon, Aug 20, 2007 at 03:48:10PM -0700, [email protected] wrote:
> --
> Content-Disposition: inline; filename=macintosh.patch
>
> Convert from class_device to device for macintosh. This is part of the
> work to eliminate struct class_device.

Signed-off-by: Tony Jones <[email protected]>

2007-08-24 05:03:58

by Benjamin Herrenschmidt

Subject: Re: [patch 04/14] Convert from class_device to device for drivers/macintosh

On Mon, 2007-08-20 at 15:48 -0700, [email protected] wrote:
> --
> Content-Disposition: inline; filename=macintosh.patch
>
> Convert from class_device to device for macintosh. This is part of the
> work to eliminate struct class_device.

Good. That stuff shouldn't have been a class in the first place. ADB is
a bus type, not a class.

Ben.

> ---
> drivers/macintosh/adb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/macintosh/adb.c
> +++ b/drivers/macintosh/adb.c
> @@ -875,5 +875,5 @@ adbdev_init(void)
> adb_dev_class = class_create(THIS_MODULE, "adb");
> if (IS_ERR(adb_dev_class))
> return;
> - class_device_create(adb_dev_class, NULL, MKDEV(ADB_MAJOR, 0), NULL, "adb");
> + device_create(adb_dev_class, NULL, MKDEV(ADB_MAJOR, 0), "adb");
> }
>