Signed-off-by: Andre Haupt <[email protected]>
---
Index: linus/scripts/checkstack.pl
===================================================================
--- linus.orig/scripts/checkstack.pl 2007-08-23 14:25:03.000000000 +0200
+++ linus/scripts/checkstack.pl 2007-08-23 14:42:13.000000000 +0200
@@ -14,7 +14,7 @@
# M68k port by Geert Uytterhoeven and Andreas Schwab
#
# Usage:
-# objdump -d vmlinux | stackcheck.pl [arch]
+# objdump -d vmlinux | scripts/checkstack.pl [arch]
#
# TODO : Port to all architectures (one regex per arch)
--
Trivial change in a comment.
Signed-off-by: Jörn Engel <[email protected]>
Signed-off-by: Andre Haupt <[email protected]>
---
Index: linus/scripts/checkstack.pl
===================================================================
--- linus.orig/scripts/checkstack.pl 2007-08-23 14:25:03.000000000 +0200
+++ linus/scripts/checkstack.pl 2007-08-23 14:42:13.000000000 +0200
@@ -14,7 +14,7 @@
# M68k port by Geert Uytterhoeven and Andreas Schwab
#
# Usage:
-# objdump -d vmlinux | stackcheck.pl [arch]
+# objdump -d vmlinux | scripts/checkstack.pl [arch]
#
# TODO : Port to all architectures (one regex per arch)
Jörn
--
Correctness comes second.
Features come third.
Performance comes last.
Maintainability is easily forgotten.
On Thu, Aug 23, 2007 at 02:55:40PM +0200, [email protected] wrote:
> Signed-off-by: Andre Haupt <[email protected]>
> ---
> Index: linus/scripts/checkstack.pl
> ===================================================================
> --- linus.orig/scripts/checkstack.pl 2007-08-23 14:25:03.000000000 +0200
> +++ linus/scripts/checkstack.pl 2007-08-23 14:42:13.000000000 +0200
> @@ -14,7 +14,7 @@
> # M68k port by Geert Uytterhoeven and Andreas Schwab
> #
> # Usage:
> -# objdump -d vmlinux | stackcheck.pl [arch]
> +# objdump -d vmlinux | scripts/checkstack.pl [arch]
>...
"make checkstack" ?
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
On Thu, 23 August 2007 15:26:39 +0200, Adrian Bunk wrote:
> On Thu, Aug 23, 2007 at 02:55:40PM +0200, [email protected] wrote:
> > Signed-off-by: Andre Haupt <[email protected]>
> > ---
> > Index: linus/scripts/checkstack.pl
> > ===================================================================
> > --- linus.orig/scripts/checkstack.pl 2007-08-23 14:25:03.000000000 +0200
> > +++ linus/scripts/checkstack.pl 2007-08-23 14:42:13.000000000 +0200
> > @@ -14,7 +14,7 @@
> > # M68k port by Geert Uytterhoeven and Andreas Schwab
> > #
> > # Usage:
> > -# objdump -d vmlinux | stackcheck.pl [arch]
> > +# objdump -d vmlinux | scripts/checkstack.pl [arch]
> >...
>
> "make checkstack" ?
If you really care about this, send a patch. An argument against it is
that some people seem to use the script independently of the linux
kernel. Not sure if all of them copy the makefile logic as well.
Does it matter?
Jörn
--
Anything that can go wrong, will.
-- Finagle's Law
On Thu, 23 Aug 2007 15:35:29 +0200 J?rn Engel wrote:
> On Thu, 23 August 2007 15:26:39 +0200, Adrian Bunk wrote:
> > On Thu, Aug 23, 2007 at 02:55:40PM +0200, [email protected] wrote:
> > > Signed-off-by: Andre Haupt <[email protected]>
> > > ---
> > > Index: linus/scripts/checkstack.pl
> > > ===================================================================
> > > --- linus.orig/scripts/checkstack.pl 2007-08-23 14:25:03.000000000 +0200
> > > +++ linus/scripts/checkstack.pl 2007-08-23 14:42:13.000000000 +0200
> > > @@ -14,7 +14,7 @@
> > > # M68k port by Geert Uytterhoeven and Andreas Schwab
> > > #
> > > # Usage:
> > > -# objdump -d vmlinux | stackcheck.pl [arch]
> > > +# objdump -d vmlinux | scripts/checkstack.pl [arch]
> > >...
> >
> > "make checkstack" ?
Yes, "make help" already lists this and the other check* scripts.
> If you really care about this, send a patch. An argument against it is
> that some people seem to use the script independently of the linux
> kernel. Not sure if all of them copy the makefile logic as well.
>
> Does it matter?
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
On Thu, 23 Aug 2007 15:13:02 +0200
J?rn Engel <[email protected]> wrote:
> Trivial change in a comment.
>
> Signed-off-by: J?rn Engel <[email protected]>
> Signed-off-by: Andre Haupt <[email protected]>
> ---
> Index: linus/scripts/checkstack.pl
> ===================================================================
> --- linus.orig/scripts/checkstack.pl 2007-08-23 14:25:03.000000000 +0200
> +++ linus/scripts/checkstack.pl 2007-08-23 14:42:13.000000000 +0200
> @@ -14,7 +14,7 @@
> # M68k port by Geert Uytterhoeven and Andreas Schwab
> #
> # Usage:
> -# objdump -d vmlinux | stackcheck.pl [arch]
> +# objdump -d vmlinux | scripts/checkstack.pl [arch]
> #
> # TODO : Port to all architectures (one regex per arch)
Thanks, I forwarded this to Andy. I prefer not to apply checkpatch
patches directly to -mm as it's still under a considerable amount of
development and anything which I apply would just get tangled up with
Andy's next update.
On Thu, 23 Aug 2007 14:11:16 -0700 Andrew Morton wrote:
> On Thu, 23 Aug 2007 15:13:02 +0200
> J?rn Engel <[email protected]> wrote:
>
> > Trivial change in a comment.
> >
> > Signed-off-by: J?rn Engel <[email protected]>
> > Signed-off-by: Andre Haupt <[email protected]>
> > ---
> > Index: linus/scripts/checkstack.pl
> > ===================================================================
> > --- linus.orig/scripts/checkstack.pl 2007-08-23 14:25:03.000000000 +0200
> > +++ linus/scripts/checkstack.pl 2007-08-23 14:42:13.000000000 +0200
> > @@ -14,7 +14,7 @@
> > # M68k port by Geert Uytterhoeven and Andreas Schwab
> > #
> > # Usage:
> > -# objdump -d vmlinux | stackcheck.pl [arch]
> > +# objdump -d vmlinux | scripts/checkstack.pl [arch]
> > #
> > # TODO : Port to all architectures (one regex per arch)
>
> Thanks, I forwarded this to Andy. I prefer not to apply checkpatch
> patches directly to -mm as it's still under a considerable amount of
> development and anything which I apply would just get tangled up with
> Andy's next update.
That's checkstack, not checkpatch...
The patch is correct, but most people use it (checkstack) via
make checkstack
AFAIK.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***