2007-08-25 09:09:11

by Michal Januszewski

Subject: [PATCH] uvesafb: select connector in Kconfig

Make uvesafb select connector instead of depending on it being already selected.

Signed-off-by: Michal Januszewski <[email protected]>
---
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index f1cc899..e152eed 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -594,7 +594,8 @@ config FB_TGA

config FB_UVESA
tristate "Userspace VESA VGA graphics support"
- depends on FB && CONNECTOR
+ depends on FB
+ select CONNECTOR
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT

2007-08-25 15:24:45

by Randy Dunlap

Subject: Re: [Linux-fbdev-devel] [PATCH] uvesafb: select connector in Kconfig

On Sat, 25 Aug 2007 10:59:31 +0200 Michal Januszewski wrote:

> Make uvesafb select connector instead of depending on it being already selected.
>
> Signed-off-by: Michal Januszewski <[email protected]>
> ---
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index f1cc899..e152eed 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -594,7 +594,8 @@ config FB_TGA
>
> config FB_UVESA
> tristate "Userspace VESA VGA graphics support"
> - depends on FB && CONNECTOR
> + depends on FB
> + select CONNECTOR
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT

There are 2 problems with this.

a. CONNECTOR depends on NET, but select won't enable NET, so if
NET is not enabled otherwise, CONNECTOR still won't build.
This is a longstanding select/kconfig issue.

b. CONNECTOR depends on NET, so if select did follow the depends
chain and enable NET, it would be enabling the networking subsystem,
which is something that should not be done quietly.

select should only be used for enabling small library-like code
(if even then). Avoid it whenever possible.


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

2007-08-26 09:44:22

by Michal Januszewski

Subject: Re: [Linux-fbdev-devel] [PATCH] uvesafb: select connector in Kconfig

On Sat, Aug 25, 2007 at 08:23:41AM -0700, Randy Dunlap wrote:

> There are 2 problems with this.
>
> a. CONNECTOR depends on NET, but select won't enable NET, so if
> NET is not enabled otherwise, CONNECTOR still won't build.
> This is a longstanding select/kconfig issue.
>
> b. CONNECTOR depends on NET, so if select did follow the depends
> chain and enable NET, it would be enabling the networking subsystem,
> which is something that should not be done quietly.
>
> select should only be used for enabling small library-like code
> (if even then). Avoid it whenever possible.

OK, thanks for pointing this out. Let's keep the original dependency
on CONNECTOR then.

Best regards,
Michal