2007-08-29 13:35:26

by Pavel Emelyanov

Subject: [PATCH] Use task_pid_nr() in ip_vs_sync.c

The sync_master_pid and sync_backup_pid are set in set_sync_pid()
and are used later for set/not-set checks and in printk. So it
is safe to use the global pid value in this case.

Signed-off-by: Pavel Emelyanov <[email protected]>

---

diff --git a/net/ipv4/ipvs/ip_vs_sync.c b/net/ipv4/ipvs/ip_vs_sync.c
index 959c08d..d0798a5 100644
--- a/net/ipv4/ipvs/ip_vs_sync.c
+++ b/net/ipv4/ipvs/ip_vs_sync.c
@@ -794,7 +794,7 @@ static int sync_thread(void *startup)

add_wait_queue(&sync_wait, &wait);

- set_sync_pid(state, current->pid);
+ set_sync_pid(state, task_pid_nr(current));
complete(tinfo->startup);

/*

2007-08-29 21:51:16

by Sukadev Bhattiprolu

Subject: Re: [PATCH] Use task_pid_nr() in ip_vs_sync.c

Pavel Emelianov [[email protected]] wrote:
| The sync_master_pid and sync_backup_pid are set in set_sync_pid()
| and are used later for set/not-set checks and in printk. So it
| is safe to use the global pid value in this case.
|
| Signed-off-by: Pavel Emelyanov <[email protected]>

Acked-by: Sukadev Bhattiprolu <[email protected]>
|
| ---
|
| diff --git a/net/ipv4/ipvs/ip_vs_sync.c b/net/ipv4/ipvs/ip_vs_sync.c
| index 959c08d..d0798a5 100644
| --- a/net/ipv4/ipvs/ip_vs_sync.c
| +++ b/net/ipv4/ipvs/ip_vs_sync.c
| @@ -794,7 +794,7 @@ static int sync_thread(void *startup)
|
| add_wait_queue(&sync_wait, &wait);
|
| - set_sync_pid(state, current->pid);
| + set_sync_pid(state, task_pid_nr(current));
| complete(tinfo->startup);
|
| /*