2007-08-14 21:30:31

by Adrian Bunk

Subject: [2.6 patch] make the dummy touchkit_ps2_detect() static

The dummy touchkit_ps2_detect() for the CONFIG_MOUSE_PS2_TOUCHKIT=n case
shouldn't be a global function.

Signed-off-by: Adrian Bunk <[email protected]>

---
64d15c53e66b200d832a6009aa24c344883bcbcf
diff --git a/drivers/input/mouse/touchkit_ps2.h b/drivers/input/mouse/touchkit_ps2.h
index 61e9dfd..8a0dd35 100644
--- a/drivers/input/mouse/touchkit_ps2.h
+++ b/drivers/input/mouse/touchkit_ps2.h
@@ -15,7 +15,8 @@
#ifdef CONFIG_MOUSE_PS2_TOUCHKIT
int touchkit_ps2_detect(struct psmouse *psmouse, int set_properties);
#else
-inline int touchkit_ps2_detect(struct psmouse *psmouse, int set_properties)
+static inline int touchkit_ps2_detect(struct psmouse *psmouse,
+ int set_properties)
{
return -ENOSYS;
}

2007-08-31 02:05:51

by Dmitry Torokhov

Subject: Re: [2.6 patch] make the dummy touchkit_ps2_detect() static

Hi Adrian,

On Tuesday 14 August 2007 17:22, Adrian Bunk wrote:
> The dummy touchkit_ps2_detect() for the CONFIG_MOUSE_PS2_TOUCHKIT=n case
> shouldn't be a global function.
>

Applied, thank you.

Btw, sorry for the long silence - I had a hard drive crash and the day
after I restored everything the disk controller decided to die as well
and write garbage all over the new disk ;(

--
Dmitry