2007-08-30 03:25:52

by Andres Salomon

[permalink] [raw]
Subject: [PATCH 0/5] ALSA: cs5535audio fixes

Hi,

Here are a bunch of fixes for the cs5535audio driver. None of these are
OLPC specific; generic chip and power management fixes, and one cleanup
patch. All have been tested on an OLPC (5536), so even though the 5535
data sheet claims to be the same, it would be nice to hear success/failure
reports from someone with a 5535.

--
Andres Salomon <[email protected]>


2007-08-30 03:52:20

by Jaya Kumar

[permalink] [raw]
Subject: Re: [PATCH 0/5] ALSA: cs5535audio fixes

On 8/29/07, Andres Salomon <[email protected]> wrote:
> Hi,
>
> Here are a bunch of fixes for the cs5535audio driver. None of these are
> OLPC specific; generic chip and power management fixes, and one cleanup
> patch. All have been tested on an OLPC (5536), so even though the 5535
> data sheet claims to be the same, it would be nice to hear success/failure
> reports from someone with a 5535.

The patches look good. I'm traveling till Sep 2nd so can't test on
5535 yet. Thanks very much for your efforts Andres.

Thanks,
jaya

Acked-by: Jaya Kumar <[email protected]>

2007-08-30 10:53:31

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH 0/5] ALSA: cs5535audio fixes

At Wed, 29 Aug 2007 23:52:08 -0400,
Jaya Kumar wrote:
>
> On 8/29/07, Andres Salomon <[email protected]> wrote:
> > Hi,
> >
> > Here are a bunch of fixes for the cs5535audio driver. None of these are
> > OLPC specific; generic chip and power management fixes, and one cleanup
> > patch. All have been tested on an OLPC (5536), so even though the 5535
> > data sheet claims to be the same, it would be nice to hear success/failure
> > reports from someone with a 5535.
>
> The patches look good. I'm traveling till Sep 2nd so can't test on
> 5535 yet. Thanks very much for your efforts Andres.

OK, let me know if it works for you. Then I'll apply them to ALSA
tree.

Thanks,

Takashi

2007-08-30 14:49:00

by Jordan Crouse

[permalink] [raw]
Subject: Re: ALSA: cs5535audio fixes

On 29/08/07 23:27 -0400, Andres Salomon wrote:
> Hi,
>
> Here are a bunch of fixes for the cs5535audio driver. None of these are
> OLPC specific; generic chip and power management fixes, and one cleanup
> patch. All have been tested on an OLPC (5536), so even though the 5535
> data sheet claims to be the same, it would be nice to hear success/failure
> reports from someone with a 5535.

These look good - and they should work fine on the 5535 - none of the patches
really change how we touch the hardware, just when we touch the hardware.

5536 is by far the more popular chip now, so I recommend we put these in,
and if by some unlucky coincidence a 5535 bug pops up, we'll deal with it
when it happens.

Jordan

--
Jordan Crouse
Systems Software Development Engineer
Advanced Micro Devices, Inc.