Resend trying to remove 8-bit characters in the email.
This patch adds the Intel Tolapai IDE mode SATA controller DID's.
Signed-off-by: Jason Gaston <[email protected]>
--- linux-2.6.23-rc4/drivers/ata/ata_piix.c.orig 2007-08-27 18:32:35.000000000 -0700
+++ linux-2.6.23-rc4/drivers/ata/ata_piix.c 2007-08-29 17:13:13.000000000 -0700
@@ -130,6 +130,7 @@
ich6m_sata_ahci = 8,
ich8_sata_ahci = 9,
piix_pata_mwdma = 10, /* PIIX3 MWDMA only */
+ tolapai_sata_ahci = 11,
/* constants for mapping table */
P0 = 0, /* port 0 */
@@ -253,6 +254,8 @@
{ 0x8086, 0x292d, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata_ahci },
/* SATA Controller IDE (ICH9M) */
{ 0x8086, 0x292e, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata_ahci },
+ /* SATA Controller IDE (Tolapai) */
+ { 0x8086, 0x5028, PCI_ANY_ID, PCI_ANY_ID, 0, 0, tolapai_sata_ahci },
{ } /* terminate list */
};
@@ -441,12 +444,25 @@
},
};
+static const struct piix_map_db tolapai_map_db = {
+ .mask = 0x3,
+ .port_enable = 0x3,
+ .map = {
+ /* PM PS SM SS MAP */
+ { P0, NA, P1, NA }, /* 00b */
+ { RV, RV, RV, RV }, /* 01b */
+ { RV, RV, RV, RV }, /* 10b */
+ { RV, RV, RV, RV },
+ },
+};
+
static const struct piix_map_db *piix_map_db_table[] = {
[ich5_sata] = &ich5_map_db,
[ich6_sata] = &ich6_map_db,
[ich6_sata_ahci] = &ich6_map_db,
[ich6m_sata_ahci] = &ich6m_map_db,
[ich8_sata_ahci] = &ich8_map_db,
+ [tolapai_sata_ahci] = &tolapai_map_db,
};
static struct ata_port_info piix_port_info[] = {
@@ -560,6 +576,17 @@
.mwdma_mask = 0x06, /* mwdma1-2 ?? CHECK 0 should be ok but slow */
.port_ops = &piix_pata_ops,
},
+
+ /* tolapai_sata_ahci: 11: */
+ {
+ .sht = &piix_sht,
+ .flags = PIIX_SATA_FLAGS | PIIX_FLAG_SCR |
+ PIIX_FLAG_AHCI,
+ .pio_mask = 0x1f, /* pio0-4 */
+ .mwdma_mask = 0x07, /* mwdma0-2 */
+ .udma_mask = ATA_UDMA6,
+ .port_ops = &piix_sata_ops,
+ },
};
static struct pci_bits piix_enable_bits[] = {
In the future, consider following the information convention we have for
patch revisions:
[PATCH 2.6.23-rc4] ata_piix: do some stuff
[PATCH 2.6.23-rc4 v2] ata_piix: do some stuff
[PATCH 2.6.23-rc4 v3] ata_piix: do some stuff
[PATCH 2.6.23-rc4 v4] ata_piix: do some stuff
etc.
Regards,
Jeff
Jason Gaston wrote:
> Resend trying to remove 8-bit characters in the email.
>
> This patch adds the Intel Tolapai IDE mode SATA controller DID's.
>
> Signed-off-by: Jason Gaston <[email protected]>
applied
>-----Original Message-----
>From: Jeff Garzik [mailto:[email protected]]
>Sent: Friday, August 31, 2007 12:51 AM
>To: Gaston, Jason D
>Cc: [email protected]; [email protected];
>[email protected]
>Subject: Re: [PATCH 2.6.23-rc4][reRESEND] ata_piix: IDE mode SATA patch
for
>Intel Tolapai
>
>Jason Gaston wrote:
>> Resend trying to remove 8-bit characters in the email.
>>
>> This patch adds the Intel Tolapai IDE mode SATA controller DID's.
>>
>> Signed-off-by: Jason Gaston <[email protected]>
>
>applied
Jeff,
I just noticed that the following section came through as spaces instead
of tabs. Do I need to resend a corrected version?
+static const struct piix_map_db tolapai_map_db = {
+ .mask = 0x3,
+ .port_enable = 0x3,
+ .map = {
+ /* PM PS SM SS MAP */
+ { P0, NA, P1, NA }, /* 00b */
+ { RV, RV, RV, RV }, /* 01b */
+ { RV, RV, RV, RV }, /* 10b */
+ { RV, RV, RV, RV },
+ },
+};
+
Thanks,
Jason
Gaston, Jason D wrote:
>> -----Original Message-----
>> From: Jeff Garzik [mailto:[email protected]]
>> Sent: Friday, August 31, 2007 12:51 AM
>> To: Gaston, Jason D
>> Cc: [email protected]; [email protected];
>> [email protected]
>> Subject: Re: [PATCH 2.6.23-rc4][reRESEND] ata_piix: IDE mode SATA patch
> for
>> Intel Tolapai
>>
>> Jason Gaston wrote:
>>> Resend trying to remove 8-bit characters in the email.
>>>
>>> This patch adds the Intel Tolapai IDE mode SATA controller DID's.
>>>
>>> Signed-off-by: Jason Gaston <[email protected]>
>> applied
>
> Jeff,
>
> I just noticed that the following section came through as spaces instead
> of tabs. Do I need to resend a corrected version?
>
> +static const struct piix_map_db tolapai_map_db = {
> + .mask = 0x3,
> + .port_enable = 0x3,
> + .map = {
> + /* PM PS SM SS MAP */
> + { P0, NA, P1, NA }, /* 00b */
> + { RV, RV, RV, RV }, /* 01b */
> + { RV, RV, RV, RV }, /* 10b */
> + { RV, RV, RV, RV },
> + },
> +};
that's always nice, yes :)
even better would be to run a script through #upstream, accomplishing
the same thing but for many drivers ;-)