2007-09-04 10:58:48

by Andreas Herrmann

Subject: [PATCH 3/4] radeonfb: fix setting of PPLL_REF_DIV for RV370 5B60

As observed with various Radeon X300: console goes blank
without fixing setting of PPLL_REF_DIV.

Signed-off-by: Andreas Herrmann <[email protected]>
---
drivers/video/aty/radeon_base.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/video/aty/radeon_base.c b/drivers/video/aty/radeon_base.c
index f672c0c..71b0c17 100644
--- a/drivers/video/aty/radeon_base.c
+++ b/drivers/video/aty/radeon_base.c
@@ -1287,7 +1287,8 @@ static void radeon_write_pll_regs(struct radeonfb_info *rinfo, struct radeon_reg
if (rinfo->family == CHIP_FAMILY_R300 ||
rinfo->family == CHIP_FAMILY_RS300 ||
rinfo->family == CHIP_FAMILY_R350 ||
- rinfo->family == CHIP_FAMILY_RV350) {
+ rinfo->family == CHIP_FAMILY_RV350 ||
+ rinfo->family == CHIP_FAMILY_RV380 ) {
if (mode->ppll_ref_div & R300_PPLL_REF_DIV_ACC_MASK) {
/* When restoring console mode, use saved PPLL_REF_DIV
* setting.
--
1.5.3

2007-09-06 12:06:41

by Benjamin Herrenschmidt

Subject: Re: [PATCH 3/4] radeonfb: fix setting of PPLL_REF_DIV for RV370 5B60

On Tue, 2007-09-04 at 13:00 +0200, [email protected] wrote:
> As observed with various Radeon X300: console goes blank
> without fixing setting of PPLL_REF_DIV.
>
> Signed-off-by: Andreas Herrmann <[email protected]>

Acked-by: Benjamin Herrenschmidt <[email protected]>

> ---
> drivers/video/aty/radeon_base.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/aty/radeon_base.c b/drivers/video/aty/radeon_base.c
> index f672c0c..71b0c17 100644
> --- a/drivers/video/aty/radeon_base.c
> +++ b/drivers/video/aty/radeon_base.c
> @@ -1287,7 +1287,8 @@ static void radeon_write_pll_regs(struct radeonfb_info *rinfo, struct radeon_reg
> if (rinfo->family == CHIP_FAMILY_R300 ||
> rinfo->family == CHIP_FAMILY_RS300 ||
> rinfo->family == CHIP_FAMILY_R350 ||
> - rinfo->family == CHIP_FAMILY_RV350) {
> + rinfo->family == CHIP_FAMILY_RV350 ||
> + rinfo->family == CHIP_FAMILY_RV380 ) {
> if (mode->ppll_ref_div & R300_PPLL_REF_DIV_ACC_MASK) {
> /* When restoring console mode, use saved PPLL_REF_DIV
> * setting.