2007-09-06 07:27:41

by Divy Le ray

[permalink] [raw]
Subject: net-26.24 broken with XFRM off

Hi Dave,

I get this error compiling net-2.6.24 with XFRM off:

[root@aries net-2.6.24]# make O=/opt/build/net-2.6.24
fatal: corrupted pack file
.git/objects/pack/pack-39c494e9d4c6488e5911ee5c06926450679e6b78.pack
fatal: corrupted pack file
.git/objects/pack/pack-39c494e9d4c6488e5911ee5c06926450679e6b78.pack
Using /mnt/net-2.6.24 as source for kernel
GEN /opt/build/net-2.6.24/Makefile
CHK include/linux/version.h
CHK include/linux/utsrelease.h
CALL /mnt/net-2.6.24/scripts/checksyscalls.sh
CHK include/linux/compile.h
GEN .version
CHK include/linux/compile.h
UPD include/linux/compile.h
CC init/version.o
LD init/built-in.o
LD .tmp_vmlinux1
net/built-in.o(.text+0x73ac2): In function `inet6_csk_xmit':
: undefined reference to `flow_cache_genid'
net/built-in.o(.text+0x73b9e): In function `inet6_csk_xmit':
: undefined reference to `flow_cache_genid'
make[1]: *** [.tmp_vmlinux1] Error 1
make: *** [_all] Error 2

I believe this commit introduced it:
commit a85d5450ddeb959bdf9e4603f9c06e9d79217cfa
Author: Noriaki TAKAMIYA <[email protected]>
Date: Fri Aug 24 23:31:39 2007 -0700

[IPV6] XFRM: Fix connected socket to use transformation.

Cheers,
Divy





2007-09-06 08:13:45

by Eric Dumazet

[permalink] [raw]
Subject: Re: net-26.24 broken with XFRM off

On Thu, 06 Sep 2007 00:25:51 -0700
Divy Le Ray <[email protected]> wrote:

> Hi Dave,
>
> I get this error compiling net-2.6.24 with XFRM off:
>
> [root@aries net-2.6.24]# make O=/opt/build/net-2.6.24
> fatal: corrupted pack file
> .git/objects/pack/pack-39c494e9d4c6488e5911ee5c06926450679e6b78.pack
> fatal: corrupted pack file
> .git/objects/pack/pack-39c494e9d4c6488e5911ee5c06926450679e6b78.pack
> Using /mnt/net-2.6.24 as source for kernel
> GEN /opt/build/net-2.6.24/Makefile
> CHK include/linux/version.h
> CHK include/linux/utsrelease.h
> CALL /mnt/net-2.6.24/scripts/checksyscalls.sh
> CHK include/linux/compile.h
> GEN .version
> CHK include/linux/compile.h
> UPD include/linux/compile.h
> CC init/version.o
> LD init/built-in.o
> LD .tmp_vmlinux1
> net/built-in.o(.text+0x73ac2): In function `inet6_csk_xmit':
> : undefined reference to `flow_cache_genid'
> net/built-in.o(.text+0x73b9e): In function `inet6_csk_xmit':
> : undefined reference to `flow_cache_genid'
> make[1]: *** [.tmp_vmlinux1] Error 1
> make: *** [_all] Error 2
>
> I believe this commit introduced it:
> commit a85d5450ddeb959bdf9e4603f9c06e9d79217cfa
> Author: Noriaki TAKAMIYA <[email protected]>
> Date: Fri Aug 24 23:31:39 2007 -0700
>
> [IPV6] XFRM: Fix connected socket to use transformation.
>

Hi Divy

I believe this problem is known.

Please check http://marc.info/?l=linux-netdev&m=118881627028135&w=2

Eric

2007-09-06 09:51:35

by David Miller

[permalink] [raw]
Subject: Re: net-26.24 broken with XFRM off

From: Eric Dumazet <[email protected]>
Date: Thu, 6 Sep 2007 10:13:26 +0200

> I believe this problem is known.
>
> Please check http://marc.info/?l=linux-netdev&m=118881627028135&w=2

I'll toss that fix into the tree, thanks.

2007-09-06 10:27:29

by Noriaki TAKAMIYA

[permalink] [raw]
Subject: Re: net-26.24 broken with XFRM off

Hi,

>> Thu, 6 Sep 2007 10:13:26 +0200
>> [Subject: Re: net-26.24 broken with XFRM off]
>> Eric Dumazet <[email protected]> wrote...

> Hi Divy
>
> I believe this problem is known.
>
> Please check http://marc.info/?l=linux-netdev&m=118881627028135&w=2

I'm sorry not to check more precisely.

As Eric said, this issue should be fixed by the patch attached in
the following mail.

Regards,

>> Mon, 03 Sep 2007 19:43:51 +0900
>> [Subject: Re: [-mm patch] IPV6 must select XFRM]
>> Masahide NAKAMURA <[email protected]> wrote...

> Thank you for catching this. the issue is caused with patch
> "[IPV6] XFRM: Fix connected socket to use transformation."
> which I sent to netdev.
> (a85d5450ddeb959bdf9e4603f9c06e9d79217cfa on net-2.6.24).
>
> I'd prefer to modify the original patch to use "ifdef CONFIG_XFRM"
> than changing kernel config depends. Does it make sense?
>
> Please review the attached patch.
>
> --
> Masahide NAKAMURA
--
Noriaki TAKAMIYA