2007-09-06 21:32:20

by Vladimir Shebordaev

Subject: [PATCH] [input] USB touchscreen

This patch fixes a nasty typo in usbtouchscreen driver.

The typo is inherited from the original mtouchusb. It
used to make the input subsytem to incorrectly
report the physical device ids to userspace that in turn
is much confusing for, e.g. XInput hotplug facilities in
setups with multiple identical touchscreens.

Signed-off-by: Vladimir Shebordaev <[email protected]>
---
drivers/input/touchscreen/usbtouchscreen.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c
index e3f2285..c32f447 100644
--- a/drivers/input/touchscreen/usbtouchscreen.c
+++ b/drivers/input/touchscreen/usbtouchscreen.c
@@ -734,7 +734,7 @@ static int usbtouch_probe(struct usb_interface *intf,
le16_to_cpu(udev->descriptor.idProduct));

usb_make_path(udev, usbtouch->phys, sizeof(usbtouch->phys));
- strlcpy(usbtouch->phys, "/input0", sizeof(usbtouch->phys));
+ strlcat(usbtouch->phys, "/input0", sizeof(usbtouch->phys));

input_dev->name = usbtouch->name;
input_dev->phys = usbtouch->phys;
--
1.5.2.2

2007-09-07 01:34:37

by Dmitry Torokhov

Subject: Re: [PATCH] [input] USB touchscreen

On Thursday 06 September 2007 17:29, Vladimir Shebordaev wrote:
> This patch fixes a nasty typo in usbtouchscreen driver.
>
> The typo is inherited from the original mtouchusb. It
> used to make the input subsytem to incorrectly
> report the physical device ids to userspace that in turn
> is much confusing for, e.g. XInput hotplug facilities in
> setups with multiple identical touchscreens.
>
> Signed-off-by: Vladimir Shebordaev <[email protected]>

Applied, thank you Vladimir.

--
Dmitry