2007-09-11 07:46:21

by Tony Breeds

Subject: Fix "no_sync_cmos_clock" logic inversion in kernel/time/ntp.c

Signed-off-by: Tony Breeds <[email protected]>

---

Seems to me that this timer will only get started on platforms that say
they don't want it?

kernel/time/ntp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: working/kernel/time/ntp.c
===================================================================
--- working.orig/kernel/time/ntp.c 2007-09-11 17:34:44.000000000 +1000
+++ working/kernel/time/ntp.c 2007-09-11 17:34:55.000000000 +1000
@@ -226,7 +226,7 @@ static void sync_cmos_clock(unsigned lon

static void notify_cmos_timer(void)
{
- if (no_sync_cmos_clock)
+ if (!no_sync_cmos_clock)
mod_timer(&sync_cmos_timer, jiffies + 1);
}


Yours Tony

linux.conf.au http://linux.conf.au/ || http://lca2008.linux.org.au/
Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!

2007-09-11 07:58:17

by Thomas Gleixner

Subject: Re: Fix "no_sync_cmos_clock" logic inversion in kernel/time/ntp.c

On Tue, 2007-09-11 at 17:46 +1000, Tony Breeds wrote:
> Signed-off-by: Tony Breeds <[email protected]>
>
> ---
>
> Seems to me that this timer will only get started on platforms that say
> they don't want it?

Hell, yes. Good catch !

tglx

> kernel/time/ntp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: working/kernel/time/ntp.c
> ===================================================================
> --- working.orig/kernel/time/ntp.c 2007-09-11 17:34:44.000000000 +1000
> +++ working/kernel/time/ntp.c 2007-09-11 17:34:55.000000000 +1000
> @@ -226,7 +226,7 @@ static void sync_cmos_clock(unsigned lon
>
> static void notify_cmos_timer(void)
> {
> - if (no_sync_cmos_clock)
> + if (!no_sync_cmos_clock)
> mod_timer(&sync_cmos_timer, jiffies + 1);
> }
>
>
> Yours Tony
>
> linux.conf.au http://linux.conf.au/ || http://lca2008.linux.org.au/
> Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!
>