2007-09-11 18:46:19

by Kristen Carlson Accardi

Subject: [patch] ata: increase allowed config flags

In anticipation of more features, increase number of config flags
allowed, and move the init flags.

Signed-off-by: Kristen Carlson Accardi <[email protected]>
Cc: Hugh Dickens <[email protected]>

Index: 2.6-mm/include/linux/libata.h
===================================================================
--- 2.6-mm.orig/include/linux/libata.h
+++ 2.6-mm/include/linux/libata.h
@@ -140,11 +140,11 @@ enum {
ATA_DFLAG_ACPI_PENDING = (1 << 5), /* ACPI resume action pending */
ATA_DFLAG_ACPI_FAILED = (1 << 6), /* ACPI on devcfg has failed */
ATA_DFLAG_AN = (1 << 7), /* device supports AN */
- ATA_DFLAG_CFG_MASK = (1 << 8) - 1,
+ ATA_DFLAG_CFG_MASK = (1 << 12) - 1,

- ATA_DFLAG_PIO = (1 << 8), /* device limited to PIO mode */
- ATA_DFLAG_NCQ_OFF = (1 << 9), /* device limited to non-NCQ mode */
- ATA_DFLAG_SPUNDOWN = (1 << 10), /* XXX: for spindown_compat */
+ ATA_DFLAG_PIO = (1 << 12), /* device limited to PIO mode */
+ ATA_DFLAG_NCQ_OFF = (1 << 13), /* device limited to non-NCQ mode */
+ ATA_DFLAG_SPUNDOWN = (1 << 14), /* XXX: for spindown_compat */
ATA_DFLAG_INIT_MASK = (1 << 16) - 1,

ATA_DFLAG_DETACH = (1 << 16),

2007-09-20 21:15:30

by Jeff Garzik

Subject: Re: [patch] ata: increase allowed config flags

Kristen Carlson Accardi wrote:
> In anticipation of more features, increase number of config flags
> allowed, and move the init flags.
>
> Signed-off-by: Kristen Carlson Accardi <[email protected]>
> Cc: Hugh Dickens <[email protected]>

applied