2007-09-20 19:10:59

by Stephen Hemminger

Subject: [PATCH 2/3] missing null termination in power supply uevent

Need to null terminate environment. Found by inspection
while looking for similar problems to platform uevent bug

Signed-off-by: Stephen Hemminger <[email protected]>


--- a/drivers/power/power_supply_sysfs.c 2007-08-18 07:50:10.000000000 -0700
+++ b/drivers/power/power_supply_sysfs.c 2007-09-20 11:42:11.000000000 -0700
@@ -289,6 +289,7 @@ int power_supply_uevent(struct device *d
if (ret)
goto out;
}
+ envp[i] = NULL;

out:
free_page((unsigned long)prop_buf);

--
Stephen Hemminger <[email protected]>

2007-09-22 06:27:58

by Anton Vorontsov

Subject: Re: [PATCH 2/3] missing null termination in power supply uevent

On Thu, Sep 20, 2007 at 12:06:10PM -0700, Stephen Hemminger wrote:
> Need to null terminate environment. Found by inspection
> while looking for similar problems to platform uevent bug
>
> Signed-off-by: Stephen Hemminger <[email protected]>

Much thanks, git-applymbox'ed to battery-2.6.git. I suppose this is
serious enough, thus should hit 2.6.23.

Though prior asking to pull I'll wait just a bit.

Thanks,

--
Anton Vorontsov
email: [email protected]
backup email: [email protected]
irc://irc.freenode.net/bd2