2007-09-28 07:28:17

by Pierre Peiffer

Subject: [resend][PATCH] Remove duplicated declarations in procfs

From: Pierre Peiffer <[email protected]>

This is a trivial patch that removes some duplicated declarations of
extern variables.

Signed-off-by: Pierre Peiffer <[email protected]>
---

fs/proc/internal.h | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/fs/proc/internal.h b/fs/proc/internal.h
index b215c35..d812816 100644
--- a/fs/proc/internal.h
+++ b/fs/proc/internal.h
@@ -50,10 +50,6 @@ extern const struct file_operations proc_maps_operations;
extern const struct file_operations proc_numa_maps_operations;
extern const struct file_operations proc_smaps_operations;

-extern const struct file_operations proc_maps_operations;
-extern const struct file_operations proc_numa_maps_operations;
-extern const struct file_operations proc_smaps_operations;
-

void free_proc_entry(struct proc_dir_entry *de);


--
Pierre

2007-09-28 07:40:16

by Andrew Morton

Subject: Re: [resend][PATCH] Remove duplicated declarations in procfs

On Fri, 28 Sep 2007 09:27:56 +0200 Pierre Peiffer <[email protected]> wrote:

> From: Pierre Peiffer <[email protected]>
>
> This is a trivial patch that removes some duplicated declarations of
> extern variables.
>
> Signed-off-by: Pierre Peiffer <[email protected]>
> ---
>
> fs/proc/internal.h | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/fs/proc/internal.h b/fs/proc/internal.h
> index b215c35..d812816 100644
> --- a/fs/proc/internal.h
> +++ b/fs/proc/internal.h
> @@ -50,10 +50,6 @@ extern const struct file_operations proc_maps_operations;
> extern const struct file_operations proc_numa_maps_operations;
> extern const struct file_operations proc_smaps_operations;
>
> -extern const struct file_operations proc_maps_operations;
> -extern const struct file_operations proc_numa_maps_operations;
> -extern const struct file_operations proc_smaps_operations;
> -
>
> void free_proc_entry(struct proc_dir_entry *de);

yup, thanks, the maps2 patches in -mm already accidentally fixed this so I haven't
bothered merging it as a standalone thing.

2007-09-28 07:49:43

by Pierre Peiffer

Subject: Re: [resend][PATCH] Remove duplicated declarations in procfs

Andrew Morton a ?crit :
>
> yup, thanks, the maps2 patches in -mm already accidentally fixed this so I haven't
> bothered merging it as a standalone thing.
>
Ok, good.

Thanks,

--
Pierre