2007-09-30 11:44:19

by Nigel Cunningham

[permalink] [raw]
Subject: Fwd: [Suspend2-devel] [patch] 2.2.10.3 build fixes

Hi Rafael et al.

This looks like it will be vanilla material, maybe 2.6.23 material?

Regards,

Nigel
---------- Forwarded Message ----------

Subject: [Suspend2-devel] [patch] 2.2.10.3 build fixes
Date: Sunday 30 September 2007
From: "Roman Dubtsov" (dubtsov gmail com)

Hi,

I have recently run into build issue with 2.6.22 and tuxonice
2.2.10.3. When building custom kernel with make-kpkg the process
failed with the message saying: "fs.h requires linux/freezer.h, which
does not exist in exported headers". Here's quick-n-dirty patch which
fixes this. Hope it is usefull.

--- 2.6.22-toi/include/linux/Kbuild.orig 2007-09-30 01:21:30.000000000 +0700
+++ 2.6.22-toi/include/linux/Kbuild 2007-09-29 23:52:52.000000000 +0700
@@ -202,6 +202,7 @@ unifdef-y += filter.h
unifdef-y += flat.h
unifdef-y += futex.h
unifdef-y += fs.h
+unifdef-y += freezer.h
unifdef-y += gameport.h
unifdef-y += generic_serial.h
unifdef-y += genhd.h


2007-09-30 19:42:00

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: Fwd: [Suspend2-devel] [patch] 2.2.10.3 build fixes

Hi,

On Sunday, 30 September 2007 13:44, Nigel Cunningham wrote:
> Hi Rafael et al.
>
> This looks like it will be vanilla material, maybe 2.6.23 material?

Well, I wouldn't like to export freezer.h . Why exactly would that be
necessary?

Greetings,
Rafael


> ---------- Forwarded Message ----------
>
> Subject: [Suspend2-devel] [patch] 2.2.10.3 build fixes
> Date: Sunday 30 September 2007
> From: "Roman Dubtsov" (dubtsov gmail com)
>
> Hi,
>
> I have recently run into build issue with 2.6.22 and tuxonice
> 2.2.10.3. When building custom kernel with make-kpkg the process
> failed with the message saying: "fs.h requires linux/freezer.h, which
> does not exist in exported headers". Here's quick-n-dirty patch which
> fixes this. Hope it is usefull.
>
> --- 2.6.22-toi/include/linux/Kbuild.orig 2007-09-30 01:21:30.000000000 +0700
> +++ 2.6.22-toi/include/linux/Kbuild 2007-09-29 23:52:52.000000000 +0700
> @@ -202,6 +202,7 @@ unifdef-y += filter.h
> unifdef-y += flat.h
> unifdef-y += futex.h
> unifdef-y += fs.h
> +unifdef-y += freezer.h
> unifdef-y += gameport.h
> unifdef-y += generic_serial.h
> unifdef-y += genhd.h
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>

--
"Premature optimization is the root of all evil." - Donald Knuth

2007-09-30 21:44:08

by Nigel Cunningham

[permalink] [raw]
Subject: Re: Fwd: [Suspend2-devel] [patch] 2.2.10.3 build fixes

Hi.

On Monday 01 October 2007 05:56:45 Rafael J. Wysocki wrote:
> Hi,
>
> On Sunday, 30 September 2007 13:44, Nigel Cunningham wrote:
> > Hi Rafael et al.
> >
> > This looks like it will be vanilla material, maybe 2.6.23 material?
>
> Well, I wouldn't like to export freezer.h . Why exactly would that be
> necessary?

A module that starts a freezeable kthread?

I can ask for more details, and will if you like.

Regards,

Nigel
--
See http://www.tuxonice.net for Howtos, FAQs, mailing
lists, wiki and bugzilla info.

2007-09-30 22:13:54

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: Fwd: [Suspend2-devel] [patch] 2.2.10.3 build fixes

On Sunday, 30 September 2007 23:43, Nigel Cunningham wrote:
> Hi.
>
> On Monday 01 October 2007 05:56:45 Rafael J. Wysocki wrote:
> > Hi,
> >
> > On Sunday, 30 September 2007 13:44, Nigel Cunningham wrote:
> > > Hi Rafael et al.
> > >
> > > This looks like it will be vanilla material, maybe 2.6.23 material?
> >
> > Well, I wouldn't like to export freezer.h . Why exactly would that be
> > necessary?
>
> A module that starts a freezeable kthread?
>
> I can ask for more details, and will if you like.

Yes, please.

Greetings,
Rafael

2007-10-02 00:17:22

by Nigel Cunningham

[permalink] [raw]
Subject: Re: Fwd: [Suspend2-devel] [patch] 2.2.10.3 build fixes

Hi.

On Monday 01 October 2007 08:28:02 Rafael J. Wysocki wrote:
> On Sunday, 30 September 2007 23:43, Nigel Cunningham wrote:
> > On Monday 01 October 2007 05:56:45 Rafael J. Wysocki wrote:
> > > On Sunday, 30 September 2007 13:44, Nigel Cunningham wrote:
> > > > Hi Rafael et al.
> > > >
> > > > This looks like it will be vanilla material, maybe 2.6.23 material?
> > >
> > > Well, I wouldn't like to export freezer.h . Why exactly would that be
> > > necessary?
> >
> > A module that starts a freezeable kthread?
> >
> > I can ask for more details, and will if you like.
>
> Yes, please.

Ah. My bad. I should have looked at it more carefully before forwarding; it's
a result of my modifications for fuse support.

Sorry for the noise.

Nigel
--
See http://www.tuxonice.net for Howtos, FAQs, mailing
lists, wiki and bugzilla info.