2007-10-07 19:40:22

by Johannes Weiner

Subject: [TRIVIAL PATCH] Remove unused variable in drivers/dma/ioatdma.c

Hi,

I found this in an `allyesconfig' build:

CC drivers/dma/ioatdma.o
drivers/dma/ioatdma.c: In function #ioat_dma_free_chan_resources#:
drivers/dma/ioatdma.c:247: warning: unused variable #chanctrl#

Hannes

Signed-off-by: Johannes Weiner <[email protected]>

diff --git a/drivers/dma/ioatdma.c b/drivers/dma/ioatdma.c
index 41b18c5..d9db64b 100644
--- a/drivers/dma/ioatdma.c
+++ b/drivers/dma/ioatdma.c
@@ -244,7 +244,6 @@ static void ioat_dma_free_chan_resources(struct dma_chan *chan)
struct ioat_dma_chan *ioat_chan = to_ioat_chan(chan);
struct ioat_device *ioat_device = to_ioat_device(chan->device);
struct ioat_desc_sw *desc, *_desc;
- u16 chanctrl;
int in_use_descs = 0;

ioat_dma_memcpy_cleanup(ioat_chan);

2007-10-07 21:05:48

by David Miller

Subject: Re: [TRIVIAL PATCH] Remove unused variable in drivers/dma/ioatdma.c

From: Johannes Weiner <[email protected]>
Date: Sun, 7 Oct 2007 21:18:49 +0200

> Hi,
>
> I found this in an `allyesconfig' build:
>
> CC drivers/dma/ioatdma.o
> drivers/dma/ioatdma.c: In function #ioat_dma_free_chan_resources#:
> drivers/dma/ioatdma.c:247: warning: unused variable #chanctrl#
>
> Hannes
>
> Signed-off-by: Johannes Weiner <[email protected]>

This exists as a patch in -mm for what seems like months.

I can't believe this one-liner hasn't been merged yet, it's
silly.

I was even chastised at one point for merging it into my net-2.6.24
tree :-)