Hi all.
Maybe I just picked a bad time to try, but...
arch/x86/kernel/alternative.c: In function 'apply_alternatives':
arch/x86/kernel/alternative.c:191: error: 'VSYSCALL_START' undeclared (first use in this function)
arch/x86/kernel/alternative.c:191: error: (Each undeclared identifier is reported only once
arch/x86/kernel/alternative.c:191: error: for each function it appears in.)
arch/x86/kernel/alternative.c:191: error: 'VSYSCALL_END' undeclared (first use in this function)
make[1]: *** [arch/x86/kernel/alternative.o] Error 1
make: *** [arch/x86/kernel] Error 2
This is UP AMD64. Config attached.
Regards,
Nigel
On Sat, Oct 13, 2007 at 11:11:31AM +1000, Nigel Cunningham wrote:
> Hi all.
>
> Maybe I just picked a bad time to try, but...
>
> arch/x86/kernel/alternative.c: In function 'apply_alternatives':
> arch/x86/kernel/alternative.c:191: error: 'VSYSCALL_START' undeclared (first use in this function)
> arch/x86/kernel/alternative.c:191: error: (Each undeclared identifier is reported only once
> arch/x86/kernel/alternative.c:191: error: for each function it appears in.)
> arch/x86/kernel/alternative.c:191: error: 'VSYSCALL_END' undeclared (first use in this function)
> make[1]: *** [arch/x86/kernel/alternative.o] Error 1
> make: *** [arch/x86/kernel] Error 2
Try this.
Include missing header for vsyscall.
Signed-off-by: Dave Jones <[email protected]>
diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c
index bd72d94..11b03d3 100644
--- a/arch/x86/kernel/alternative.c
+++ b/arch/x86/kernel/alternative.c
@@ -10,6 +10,7 @@
#include <asm/pgtable.h>
#include <asm/mce.h>
#include <asm/nmi.h>
+#include <asm/vsyscall.h>
#define MAX_PATCH_LEN (255-1)
--
http://www.codemonkey.org.uk
On Fri, 12 Oct 2007 21:22:44 -0400, Dave Jones wrote:
> On Sat, Oct 13, 2007 at 11:11:31AM +1000, Nigel Cunningham wrote:
> > Hi all.
> >
> > Maybe I just picked a bad time to try, but...
> >
> > arch/x86/kernel/alternative.c: In function 'apply_alternatives':
> > arch/x86/kernel/alternative.c:191: error: 'VSYSCALL_START' undeclared (first use in this function)
> > arch/x86/kernel/alternative.c:191: error: (Each undeclared identifier is reported only once
> > arch/x86/kernel/alternative.c:191: error: for each function it appears in.)
> > arch/x86/kernel/alternative.c:191: error: 'VSYSCALL_END' undeclared (first use in this function)
> > make[1]: *** [arch/x86/kernel/alternative.o] Error 1
> > make: *** [arch/x86/kernel] Error 2
>
> Try this.
>
> Include missing header for vsyscall.
>
> Signed-off-by: Dave Jones <[email protected]>
>
> diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c
> index bd72d94..11b03d3 100644
> --- a/arch/x86/kernel/alternative.c
> +++ b/arch/x86/kernel/alternative.c
> @@ -10,6 +10,7 @@
> #include <asm/pgtable.h>
> #include <asm/mce.h>
> #include <asm/nmi.h>
> +#include <asm/vsyscall.h>
>
> #define MAX_PATCH_LEN (255-1)
>
Fixes the problem for me, thanks Dave!
Acked-by: Jean Delvare <[email protected]>
This should be applied to Linus' tree quickly.
--
Jean Delvare
Hi Dave et al.
On Saturday 13 October 2007 11:22:44 Dave Jones wrote:
> On Sat, Oct 13, 2007 at 11:11:31AM +1000, Nigel Cunningham wrote:
> > Hi all.
> >
> > Maybe I just picked a bad time to try, but...
> >
> > arch/x86/kernel/alternative.c: In function 'apply_alternatives':
> > arch/x86/kernel/alternative.c:191: error: 'VSYSCALL_START' undeclared
(first use in this function)
> > arch/x86/kernel/alternative.c:191: error: (Each undeclared identifier is
reported only once
> > arch/x86/kernel/alternative.c:191: error: for each function it appears
in.)
> > arch/x86/kernel/alternative.c:191: error: 'VSYSCALL_END' undeclared
(first use in this function)
> > make[1]: *** [arch/x86/kernel/alternative.o] Error 1
> > make: *** [arch/x86/kernel] Error 2
>
> Try this.
>
> Include missing header for vsyscall.
>
> Signed-off-by: Dave Jones <[email protected]>
Thanks.
Compile-Tested-by: Nigel Cunningham <[email protected]>
> diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c
> index bd72d94..11b03d3 100644
> --- a/arch/x86/kernel/alternative.c
> +++ b/arch/x86/kernel/alternative.c
> @@ -10,6 +10,7 @@
> #include <asm/pgtable.h>
> #include <asm/mce.h>
> #include <asm/nmi.h>
> +#include <asm/vsyscall.h>
>
> #define MAX_PATCH_LEN (255-1)