2007-10-16 18:19:54

by Dave Jones

Subject: reduce frequency of cursor blinking

Depending on CONFIG_HZ, we blink the cursor at 20,50,60 or 200Hz.
Even if it only blinks once per 1000Hz, there's no visible difference.

Signed-off-by: Dave Jones <[email protected]>

diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index 73813c6..7d9bae5 100644
--- a/drivers/video/console/fbcon.c
+++ b/drivers/video/console/fbcon.c
@@ -433,7 +433,7 @@ static void cursor_timer_handler(unsigned long dev_addr)
struct fbcon_ops *ops = info->fbcon_par;

schedule_work(&info->queue);
- mod_timer(&ops->cursor_timer, jiffies + HZ/5);
+ mod_timer(&ops->cursor_timer, jiffies + HZ);
}

static void fbcon_add_cursor_timer(struct fb_info *info)

--
http://www.codemonkey.org.uk

2007-10-16 18:33:13

by Arjan van de Ven

Subject: Re: reduce frequency of cursor blinking

On Tue, 16 Oct 2007 14:19:11 -0400
Dave Jones <[email protected]> wrote:

> Depending on CONFIG_HZ, we blink the cursor at 20,50,60 or 200Hz.

eh no, that's 5 times per second ...

> - mod_timer(&ops->cursor_timer, jiffies + HZ/5);

2007-10-17 19:38:59

by Dave Jones

Subject: Re: reduce frequency of cursor blinking

On Tue, Oct 16, 2007 at 11:30:37AM -0700, Arjan van de Ven wrote:
> On Tue, 16 Oct 2007 14:19:11 -0400
> Dave Jones <[email protected]> wrote:
>
> > Depending on CONFIG_HZ, we blink the cursor at 20,50,60 or 200Hz.
>
> eh no, that's 5 times per second ...

Indeed. Still seems excessive though.
How about twice per second ?

Signed-off-by: Dave Jones <[email protected]>

diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index 73813c6..7d9bae5 100644
--- a/drivers/video/console/fbcon.c
+++ b/drivers/video/console/fbcon.c
@@ -433,7 +433,7 @@ static void cursor_timer_handler(unsigned long dev_addr)
struct fbcon_ops *ops = info->fbcon_par;

schedule_work(&info->queue);
- mod_timer(&ops->cursor_timer, jiffies + HZ/5);
+ mod_timer(&ops->cursor_timer, jiffies + HZ/2);
}

static void fbcon_add_cursor_timer(struct fb_info *info)
--
http://www.codemonkey.org.uk