2007-10-20 12:15:45

by Oleg Nesterov

Subject: [PATCH 2/2] blk_sync_queue() should cancel request_queue->unplug_work

(untested, needs an explicit ack/nack from maintainer)

blk_sync_queue() cancels the timer, but forgets to cancel the work.

Signed-off-by: Oleg Nesterov <[email protected]>

--- K/block/ll_rw_blk.c~2_blk 2007-10-13 14:51:42.000000000 +0400
+++ K/block/ll_rw_blk.c 2007-10-20 16:10:08.000000000 +0400
@@ -1723,6 +1723,7 @@ EXPORT_SYMBOL(blk_stop_queue);
void blk_sync_queue(struct request_queue *q)
{
del_timer_sync(&q->unplug_timer);
+ kblockd_flush_work(&q->unplug_work);
}
EXPORT_SYMBOL(blk_sync_queue);

2007-10-21 19:17:07

by Jens Axboe

Subject: Re: [PATCH 2/2] blk_sync_queue() should cancel request_queue->unplug_work

On Sat, Oct 20 2007, Oleg Nesterov wrote:
> (untested, needs an explicit ack/nack from maintainer)
>
> blk_sync_queue() cancels the timer, but forgets to cancel the work.

Applied 1-2, thanks a lot Oleg.

--
Jens Axboe